From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] Use automake (v5)
Date: Mon, 3 May 2021 12:40:24 +0200 [thread overview]
Message-ID: <YI/TGPry90KWULi1@calimero.vinschen.de> (raw)
In-Reply-To: <42e189c7-5a2a-790a-a5c5-78b66fbcc516@SystematicSw.ab.ca>
On May 2 12:25, Brian Inglis wrote:
> On 2021-05-02 09:28, Jon Turney wrote:
> > Some possible items of future work I noted:
>
> > * -Wimplicit-fallthrough, -Werror could (should?) be set in top-level
> > Makefile.am.common, rather than individual subdirs
Careful, the implicit-fallthrough values are different. Not saying they
*have* to be different, but that certainly requires code changes.
> Perhaps keep -Werror for Cygwin sources only where we can directly deal with
> new warnings generated due to prompt gcc releases with improvements under
> Cygwin (thanks to Achim and JonY).
No, -Werror should be used for all source dirs under winsup.
> With other distros' gcc releases lagging, package builds are getting more
> warnings during cygport builds, which would have to be dealt with either by
> more Cygwin patches and/or working with upstream, by toggling off -Werror,
> or specific -Wno-... options which could result in suppressing useful
> output, as well as delaying package releases.
>
> --
> Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
>
> This email may be disturbing to some readers as it contains
> too much technical detail. Reader discretion is advised.
> [Data in binary units and prefixes, physical quantities in SI.]
next prev parent reply other threads:[~2021-05-03 10:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 20:13 Jon Turney
2021-04-20 20:15 ` Jon Turney
2021-04-21 16:40 ` Corinna Vinschen
2021-04-22 11:57 ` Corinna Vinschen
2021-04-26 15:03 ` Corinna Vinschen
2021-04-27 15:54 ` Jon Turney
2021-04-27 15:50 ` Jon Turney
2021-04-27 16:52 ` Ken Brown
2021-04-27 17:00 ` Ken Brown
2021-04-27 18:32 ` Jon Turney
2021-05-02 15:28 ` Jon Turney
2021-05-02 18:25 ` Brian Inglis
2021-05-03 10:40 ` Corinna Vinschen [this message]
2021-05-03 10:43 ` Corinna Vinschen
2021-05-04 18:12 ` Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YI/TGPry90KWULi1@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).