* [PATCH] Cygwin: console: Prevent NULL pointer access in close().
@ 2021-02-22 13:30 Takashi Yano
2021-02-22 13:58 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Yano @ 2021-02-22 13:30 UTC (permalink / raw)
To: cygwin-patches
- There seems to be a case that shared_console_info is not set yet
when close() is called. This patch adds guard for such case.
---
winsup/cygwin/fhandler_console.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
index 6ded9eabf..96a8729e8 100644
--- a/winsup/cygwin/fhandler_console.cc
+++ b/winsup/cygwin/fhandler_console.cc
@@ -1393,7 +1393,7 @@ fhandler_console::close ()
release_output_mutex ();
- if (con.owner == myself->pid)
+ if (shared_console_info && con.owner == myself->pid)
{
char name[MAX_PATH];
shared_name (name, CONS_THREAD_SYNC, get_minor ());
--
2.30.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Cygwin: console: Prevent NULL pointer access in close().
2021-02-22 13:30 [PATCH] Cygwin: console: Prevent NULL pointer access in close() Takashi Yano
@ 2021-02-22 13:58 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2021-02-22 13:58 UTC (permalink / raw)
To: cygwin-patches
On Feb 22 22:30, Takashi Yano via Cygwin-patches wrote:
> - There seems to be a case that shared_console_info is not set yet
> when close() is called. This patch adds guard for such case.
> ---
> winsup/cygwin/fhandler_console.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
> index 6ded9eabf..96a8729e8 100644
> --- a/winsup/cygwin/fhandler_console.cc
> +++ b/winsup/cygwin/fhandler_console.cc
> @@ -1393,7 +1393,7 @@ fhandler_console::close ()
>
> release_output_mutex ();
>
> - if (con.owner == myself->pid)
> + if (shared_console_info && con.owner == myself->pid)
> {
> char name[MAX_PATH];
> shared_name (name, CONS_THREAD_SYNC, get_minor ());
> --
> 2.30.0
Pushed.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-22 13:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 13:30 [PATCH] Cygwin: console: Prevent NULL pointer access in close() Takashi Yano
2021-02-22 13:58 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).