From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Cc: Thomas Wolff <towo@towo.net>
Subject: Re: [ANNOUNCEMENT] Updated: dash-0.5.8-3
Date: Tue, 31 Jan 2017 15:33:00 -0000 [thread overview]
Message-ID: <20170131153245.GA8905@calimero.vinschen.de> (raw)
In-Reply-To: <40c92f1e987a9162742766816abb4a03@smtp-cloud2.xs4all.net>
[-- Attachment #1: Type: text/plain, Size: 2346 bytes --]
On Jan 31 16:01, Houder wrote:
> On Tue, 31 Jan 2017 14:16:16, Corinna Vinschen wrote:
>
> [snip]
>
> > > I'm not quite sure yet but apparently the problem is in the handling of
> > > VERASE in the termios implementation. In cooked mode it fills a char
> > > buffer with what has been typed. The code doesn't know if the bytes in
> > > the buffer are UTF-8 chars or just random bytes. So VERASE erases
> > > exactly one byte, which means, in case of UTF-8 chars it only erases the
> > > last byte of of a mulitbyte character.
> > >=20
> > > It seems the Linux termios implementation is different in that it
> > > still knows which bytes constitute a single keypress and thus knows
> > > how much byte it has to erase.
> >
> > Ok, here's what happens on Linux: The termios code support a flag
> > IUTF8. This flag determines if the termios code checks for UTF8
> > characters in the input when performing an ERASE. It checks if the
> > IUTF8 flag is set and if so, it checks in a loop if the just erased byte
> > is a UTF-8 continuation character. If so, it erases another byte.
>
> (Thank you for responding -- and your effort thus far).
>
> Agreed. One byte or more, depending on the "character" ... (which is
> not a problem in case of UTF-8 encoding -- continuation bit).
>
> Of course, the terminal driver must receive the characters encoded in
> UTF-8.
>
> Therefore the question is: 'can the same situation be created under
> under Windows?' (does Windows provide the required support?)
This has nothing to do with Windows. It's the termios implementation
inside Cygwin. I created a patch introducing the IUTF8 flag as on Linux
as well as a code snippet trying to remove entire utf-8 characters from
the input if the IUTF8 flag is set. And it's set now by default since
we default to UTF-8 anyway.
Thomas, you may want to check for the IUTF8 flag in upcoming mintty
versions and unset it if character set configured in the mintty options
dialog is != UTF-8.
I uploaded new developer snapshots to https://cygwin.com/snapshots/
with this patch. I'm also going to release a Cygwin test version
later today.
HTH,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-01-31 15:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 23:40 Eric Blake (cygwin)
2017-01-24 15:58 ` Houder
2017-01-25 1:28 ` Steven Penny
2017-01-25 13:37 ` Houder
2017-01-25 20:31 ` cyg Simple
2017-01-28 14:36 ` Houder
2017-01-26 0:14 ` Steven Penny
2017-01-28 13:44 ` Houder
2017-01-31 10:04 ` Corinna Vinschen
2017-01-31 13:16 ` Corinna Vinschen
2017-01-31 15:02 ` Houder
2017-01-31 15:33 ` Corinna Vinschen [this message]
2017-01-31 15:42 ` Eric Blake
2017-02-01 8:46 ` Houder
2017-01-31 17:54 ` Houder
2017-02-01 9:17 ` Corinna Vinschen
2017-02-13 22:03 ` Thomas Wolff
2017-02-14 8:45 ` Corinna Vinschen
2017-02-14 19:40 ` Thomas Wolff
2017-02-14 19:56 ` Eric Blake
2017-02-14 20:29 ` Thomas Wolff
2017-02-14 20:35 ` Thomas Wolff
2017-02-15 22:19 ` Thomas Wolff
2017-02-16 12:49 ` Corinna Vinschen
2017-02-16 20:32 ` Thomas Wolff
2017-02-17 7:36 ` Thomas Wolff
2017-02-17 9:43 ` Corinna Vinschen
2017-02-17 22:30 ` Thomas Wolff
2017-02-18 22:46 ` Thomas Wolff
2017-02-20 9:11 ` Corinna Vinschen
2017-02-20 21:08 ` Thomas Wolff
2017-02-20 9:07 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131153245.GA8905@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin@cygwin.com \
--cc=towo@towo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).