public inbox for cygwin@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin@cygwin.com
Subject: Re: headache on build repeatibility: octave vs BLODA ?
Date: Wed, 29 Jan 2020 15:34:00 -0000	[thread overview]
Message-ID: <20200129153428.GP3549@calimero.vinschen.de> (raw)
In-Reply-To: <20200129153218.GO3549@calimero.vinschen.de>

[-- Attachment #1: Type: text/plain, Size: 1546 bytes --]

On Jan 29 16:32, Corinna Vinschen wrote:
> On Jan 29 22:46, Takashi Yano wrote:
> > --- m4/fseeko.m4.orig   2020-01-29 21:39:37.280507900 +0900
> > +++ m4/fseeko.m4        2020-01-29 21:36:29.263747100 +0900
> > @@ -30,16 +30,19 @@
> >      HAVE_FSEEKO=0
> >    else
> >      if test $WINDOWS_64_BIT_OFF_T = 1; then

This makes me a bit suspicious... it looks like a check only
required for native builds, not for Cygwin.

> > -      REPLACE_FSEEKO=1
> > +      dnl REPLACE_FSEEKO=1
> > +      REPLACE_FSEEKO=0
> >      fi
> >      if test $gl_cv_var_stdin_large_offset = no; then
> > -      REPLACE_FSEEKO=1
> > +      dnl REPLACE_FSEEKO=1
> > +      REPLACE_FSEEKO=0
> >      fi
> >      m4_ifdef([gl_FUNC_FFLUSH_STDIN], [
> >        gl_FUNC_FFLUSH_STDIN
> >        case "$gl_cv_func_fflush_stdin" in
> >          *yes) ;;
> > -        *) REPLACE_FSEEKO=1 ;;
> > +        dnl *) REPLACE_FSEEKO=1 ;;
> > +        *) REPLACE_FSEEKO=0 ;;
> >        esac
> 
> Commit 59362c80e3a in newlib you mention in your other mail should be a
> minor change and the code looks pretty much the same in FreeBSD, while
> OpenBSD and NetBSD are more similar to the old newlib code.  Both
> implementations should be ok, in theory.
> 
> So, the question is, what exactly is this test testing?  Can it be
> extracted from the autoconf stuff and converted to a simple testcase
> which proves that the behaviour is now wrong?
> 
> If so, I'll revert commit 59362c80e3a.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-01-29 15:34 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-25 16:55 Marco Atzeri
2020-01-25 18:15 ` Brian Inglis
2020-01-27  6:54   ` Marco Atzeri
2020-01-25 20:36 ` Achim Gratz
2020-01-26  6:58   ` Marco Atzeri
2020-01-26  8:05     ` ASSI
2020-01-26  8:38       ` Marco Atzeri
2020-01-27  6:45         ` Marco Atzeri
2020-01-27 11:33           ` Takashi Yano
2020-01-28  6:41             ` Marco Atzeri
2020-01-28 14:55               ` Takashi Yano
2020-01-29  9:44               ` Corinna Vinschen
2020-01-29 12:19                 ` Marco Atzeri
2020-01-29 13:46                   ` Takashi Yano
2020-01-29 15:11                     ` Takashi Yano
2020-01-29 15:32                     ` Corinna Vinschen
2020-01-29 15:34                       ` Corinna Vinschen [this message]
2020-01-29 16:08                         ` Takashi Yano
2020-01-29 17:57                           ` Corinna Vinschen
2020-01-30 21:05                     ` Brian Inglis
2020-01-30 21:34                       ` Marco Atzeri
2020-01-28 17:26   ` ASSI
2020-01-28 20:04     ` Marco Atzeri
2020-01-28 20:21       ` Achim Gratz
2020-01-26  2:42 ` Takashi Yano
2020-01-26  5:11   ` Takashi Yano
2020-01-26 10:24     ` Marco Atzeri
2020-01-26 10:31       ` Takashi Yano
2020-01-29  0:03 ` Hans-Bernhard Bröker
2020-01-29  0:39   ` Hans-Bernhard Bröker
2020-01-29  5:10   ` Marco Atzeri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200129153428.GP3549@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).