Re: headache on build repeatibility: octave vs BLODA ?

[Takashi Yano <takashi.yano@nifty.ne.jp>]

On Wed, 29 Jan 2020 22:46:53 +0900
Takashi Yano wrote:
> On Wed, 29 Jan 2020 13:19:11 +0100
> Marco Atzeri wrote:
> > As Octave uses gnulib, it is possible that the changes in MS are causing
> > a different subset of gnulib to be used than before, may be exposing
> > a latent bug or race.
> > 
> > Unfortunately my old build tree was polluted by mistake, so I can
> > not directly compare a good build tree versus a failing one.
> 
> I found suspicious difference between the working build and the
> not-working build.
> 
> The not-working build has fflush.o, fseek.o and fseeko.o in
> build/libgnu/.libs
> directory, while the working build does not.
> 
> Also, cygoctave-7.dll of not-working build exports rpl_fflush,
> rpl_fseek and rpl_fseeko, while that of the working build does
> not.
> 
> As a test, I used following patch to forcibly remove the code
> setting REPLACE_FSEEKO to 1 in configure script, and rebuilt
> octave. This works without segmentation fault.
> 
> I do not look into the reason why this difference causes yet.

Perhaps, the cause of this behaviour change is:

commit 59362c80e3a02c011fd0ef3d7f07a20098d2a9d5
Author: Bastien Bouclet <bastien.bouclet@gmail.com>
Date:   Sat Nov 9 17:28:04 2019 +0100

    newlib: fix fseek optimization with SEEK_CUR

    The call to fflush was invalidating the read buffer, preventing relative
    seeks to positions that would have been inside the read buffer from
    being optimized. The call to srefill would then re-read mostly the same
    data that was initially in the read buffer.

Recently, I executed make only in winsup/cygwin, so this newlib
change did not affect. Therefore this change was not included in
my local cygwin1.dll binary. As for Win10 Home machine, which
causes the problem, cygwin1.dll is v3.1.2, so this is affected. 

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple