From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin@cygwin.com
Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled?
Date: Sat, 28 Aug 2021 12:03:12 +0900 [thread overview]
Message-ID: <20210828120312.ff2f26a8412c3c434f23e21b@nifty.ne.jp> (raw)
In-Reply-To: <20210828110024.be88ac6dec1ade52199ed811@nifty.ne.jp>
On Sat, 28 Aug 2021 11:00:24 +0900
Takashi Yano wrote:
> On Sat, 28 Aug 2021 02:21:11 +0900
> Takashi Yano wrote:
>
> > On Fri, 27 Aug 2021 12:00:50 -0400
> > Ken Brown wrote:
> >
> > > On 8/27/2021 7:24 AM, Takashi Yano wrote:
> > > > On Thu, 26 Aug 2021 18:18:29 -0400
> > > > Ken Brown wrote:
> > > >> On 8/26/2021 11:56 AM, Ken Brown via Cygwin wrote:
> > > [...]
> > > >> In case you want to try out my proposed change, I've just rebased the patches to
> > > >> the current master and pushed them to a new topic/pipe branch.
> > > >
> > > > Hi Ken,
> > > >
> > > > Thanks much! I tested topic/pipe branch.
> > > >
> > > > [yano@cygwin-PC ~]$ scp test.dat yano@linux-server:.
> > > > yano@linux-server's password:
> > > > test.dat 100% 100MB 95.9MB/s 00:01
> > > > [yano@cygwin-PC ~]$ scp yano@linux-server:test.dat .
> > > > yano@linux-server's password:
> > > > test.dat 100% 100MB 8.0MB/s 00:12
> > > >
> > > > yano@linux-server:~$ scp yano@cygwin-PC:test.dat .
> > > > yano@cygwin-PC's password:
> > > > test.dat 100% 100MB 109.7MB/s 00:00
> > > > yano@linux-server:~$ scp test.dat yano@cygwin-PC:.
> > > > yano@cygwin-PC's password:
> > > > test.dat 100% 100MB 31.4MB/s 00:03
> > > >
> > > > As shown above, outgoing transfer-rate has been improved upto near
> > > > theoretical limit. However, incoming transfer-rate is not improved
> > > > much.
> > > >
> > > > I digged further and found the first patch attached solves the issue
> > > > as follows.
> > > >
> > > > [yano@cygwin-PC ~]$ scp yano@linux-server:test.dat .
> > > > yano@linux-server's password:
> > > > test.dat 100% 100MB 112.8MB/s 00:00
> > > >
> > > > yano@linux-server2:~$ scp test.dat yano@cygwin-PC:.
> > > > yano@cygwin-PC's password:
> > > > test.dat 100% 100MB 102.5MB/s 00:00
> > >
> > > Great!
> > >
> > > > I also tested the case:
> > > >>>> https://cygwin.com/pipermail/cygwin/2021-March/247987.html
> > > >>>> which seems to be the same issue with
> > > >>>> https://stackoverflow.com/questions/10385424/good-alternatives-to-cygwin-cygwin-doesnt-support-natively-support-win32-app
> > > >
> > > > Unfortunately, topic/pipe does not help.
> > > >
> > > > I confirmed that applying the second patch attached, which reverts
> > > > to create() rather than nt_create(), and setting CYGWIN=pipe_byte
> > > > fixes the problem.
> > > >
> > > > What do you think of this alternative implementation which does
> > > > not use nt_create()?
> > >
> > > Two years ago I thought I needed nt_create to avoid problems when calling
> > > set_pipe_non_blocking. Are you saying that's not an issue? Is
> > > set_pipe_non_blocking unnecessary? Is that the point of your modification to
> > > raw_read?
> >
> > Yes. Instead of making windows read function itself non-blocking,
> > it is possible to check if the pipe can be read before read using
> > PeekNamedPipe(). If the pipe cannot be read right now, EAGAIN is
> > returned.
>
> As for writint to pipe, set_pipe_non_blocking seems to take effect
> and be necessary.
So, the following patch seems to be appropriate.
diff --git a/winsup/cygwin/fhandler_pipe.cc b/winsup/cygwin/fhandler_pipe.cc
index b3af4a0a0..82f5de3f4 100644
--- a/winsup/cygwin/fhandler_pipe.cc
+++ b/winsup/cygwin/fhandler_pipe.cc
@@ -48,6 +48,8 @@ fhandler_pipe::set_pipe_non_blocking (bool nonblocking)
IO_STATUS_BLOCK io;
FILE_PIPE_INFORMATION fpi;
+ if ((openflags & O_ACCMODE) == O_RDONLY)
+ return; /* Do nothing for read pipe */
fpi.ReadMode = FILE_PIPE_BYTE_STREAM_MODE;
fpi.CompletionMode = nonblocking ? FILE_PIPE_COMPLETE_OPERATION
: FILE_PIPE_QUEUE_OPERATION;
--
Takashi Yano <takashi.yano@nifty.ne.jp>
next prev parent reply other threads:[~2021-08-28 3:03 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 19:49 Chris Roehrig
2021-08-24 23:43 ` Mark Geisert
2021-08-25 0:35 ` Chris Roehrig
2021-08-25 2:12 ` Chris Roehrig
2021-08-25 2:02 ` NightStrike
2021-08-25 3:20 ` Mark Geisert
2021-08-25 17:24 ` Chris Roehrig
2021-08-25 11:18 ` Takashi Yano
2021-08-25 17:31 ` Chris Roehrig
2021-08-25 17:52 ` Ken Brown
2021-08-25 18:18 ` Chris Roehrig
2021-08-25 18:51 ` Chris Roehrig
2021-08-26 15:44 ` Ken Brown
2021-08-25 20:33 ` Mario Emmenlauer
2021-08-26 15:47 ` Ken Brown
2021-08-25 21:29 ` Takashi Yano
2021-08-26 15:56 ` Ken Brown
2021-08-26 22:18 ` Ken Brown
2021-08-27 11:24 ` Takashi Yano
2021-08-27 16:00 ` Ken Brown
2021-08-27 17:21 ` Takashi Yano
2021-08-28 2:00 ` Takashi Yano
2021-08-28 3:03 ` Takashi Yano [this message]
2021-08-28 8:43 ` Corinna Vinschen
2021-08-28 9:41 ` Takashi Yano
2021-08-28 11:58 ` Corinna Vinschen
2021-08-28 15:43 ` Takashi Yano
2021-08-28 20:55 ` Ken Brown
2021-08-29 8:41 ` Takashi Yano
2021-08-29 22:42 ` Ken Brown
2021-08-29 10:27 ` Corinna Vinschen
2021-08-29 9:07 ` Takashi Yano
2021-08-29 15:57 ` Ken Brown
2021-08-29 19:24 ` Chris Roehrig
2021-08-29 22:24 ` Ken Brown
2021-08-30 23:58 ` Chris Roehrig
2021-08-31 19:05 ` Ken Brown
2021-08-31 19:53 ` Chris Roehrig
2021-08-31 20:23 ` Chris Roehrig
2021-08-31 21:29 ` Brian Inglis
2021-09-01 21:11 ` Chris Roehrig
2021-09-02 15:25 ` Ken Brown
2021-09-02 19:03 ` Chris Roehrig
2021-09-03 17:26 ` Ken Brown
2021-09-03 19:55 ` Corinna Vinschen
2021-09-03 20:59 ` Chris Roehrig
2021-09-04 8:32 ` Achim Gratz
2021-09-04 16:45 ` Brian Inglis
2021-09-05 8:18 ` Achim Gratz
2021-09-05 15:11 ` Brian Inglis
2021-09-06 10:42 ` Achim Gratz
2021-09-04 22:37 ` mmap failure [was: cygrunsrv + sshd + rsync = 20 times too slow -- throttled?] Ken Brown
2021-09-04 22:54 ` Ken Brown
2021-09-04 22:58 ` Ken Brown
2021-09-05 0:04 ` Ken Brown
2021-09-05 13:24 ` Ken Brown
2021-09-06 15:32 ` Corinna Vinschen
2021-09-06 17:12 ` Ken Brown
2021-09-06 17:38 ` Ken Brown
2021-09-06 17:43 ` Eliot Moss
2021-09-06 17:59 ` Corinna Vinschen
2021-09-06 18:07 ` Corinna Vinschen
2021-09-06 18:40 ` Ken Brown
2021-09-06 20:52 ` Peter Dons Tychsen
2021-09-06 20:54 ` Peter Dons Tychsen
2021-09-06 21:24 ` Ken Brown
2021-09-06 21:31 ` Ken Brown
2021-09-07 3:34 ` Brian Inglis
2021-09-07 16:28 ` Ken Brown
2021-09-07 21:52 ` Lavrentiev, Anton (NIH/NLM/NCBI) [C]
2021-09-07 22:44 ` Ken Brown
2021-09-08 6:14 ` Sam Edge
2021-09-08 8:18 ` Corinna Vinschen
2021-09-07 21:41 ` Peter Dons Tychsen
2021-09-04 23:18 ` Brian Inglis
2021-08-29 19:37 ` cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Takashi Yano
2021-08-29 21:09 ` Ken Brown
2021-08-29 21:04 ` Ken Brown
2021-08-30 0:13 ` Takashi Yano
2021-08-30 0:22 ` Takashi Yano
2021-08-30 2:15 ` Ken Brown
2021-08-30 8:02 ` Takashi Yano
2021-08-28 15:17 ` Ken Brown
2021-09-16 22:00 ` Keith Christian
2021-09-16 22:48 ` Ken Brown
2021-09-16 22:58 ` Keith Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210828120312.ff2f26a8412c3c434f23e21b@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).