Cygwin subversion and UNC path

Cygwin subversion and UNC path

[Yasutaka Atarashi]

Hi.

I found a possible improvement for Cygwin Subversion.

Currently, Cygwin Subversion can not handle UNC path correctly.
07-fix-path-tests.patch in Cygwin Subversion package says "But do support a little UNC".
However, it does not work correctly.
This is just because of a typo.
In that patch, cygwin check is described as defined(CYGWIN) instead of defined(__CYGWIN__).

Replacing all occurrences of defined(CYGWIN) with defined(__CYGWIN__) enables Cygwin Subversion to handle UNC path.
For example, it could handle repositories checked out by TortoiseSVN from UNC path.
(Replacing libsvn_subr is enough to fix)

Please consider to apply this modification.

Regards,
Yasutaka ATARASHI


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: Cygwin subversion and UNC path

[David Rothenberger]

On 4/22/2018 7:04 AM, Yasutaka Atarashi wrote:
> Replacing all occurrences of defined(CYGWIN) with defined(__CYGWIN__) enables Cygwin Subversion to handle UNC path.
> For example, it could handle repositories checked out by TortoiseSVN from UNC path.
> (Replacing libsvn_subr is enough to fix)

Thanks for the tip. I will include this in Subversion 1.10. I am currently having trouble porting some of the other patches, but hope to have a new release in a week or two.

-- 
David Rothenberger  ----  daveroth@acm.org

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

subversion problem

[Rockefeller, Harry]

I just updated packages this morning and noticed there were some
subversion updates.  I was wondering if version 10 is new and requires me to do something?
Or maybe the recent release broke something?

About my Cygwin system: [If more information is required please ask.]
$ uname -a
CYGWIN_NT-6.1 HARRYR-PC 2.10.0(0.325/5/3) 2018-02-02 15:16 x86_64 Cygwin
$ cygcheck -c subversion
...
Package              Version        Status
subversion           1.10.0-1       OK
$ svnadmin info /usr/local/svnroot
Path: /usr/local/svnroot
UUID: 6c5b531c-fdee-0310-8ccc-e19e2ad93f33
Revisions: 1029
Repository Format: 5
Compatible With Version: 1.9.0
Repository Capability: mergeinfo
Filesystem Type: fsfs
Filesystem Format: 7
FSFS Sharded: yes
FSFS Shard Size: 1000
FSFS Shards Packed: 0/1
FSFS Logical Addressing: yes
Configuration File: /usr/local/svnroot/db/fsfs.conf

I also ran "svnadmin verify" on the repository above and there were no errors.
Also, as shown here, I use subversion only locally.

Simple example of the problem.

harryr@HARRYR-PC ~/test_subversion
$ svn co file:///usr/local/svnroot/ced
A    ced/branches
A    ced/tags
A    ced/trunk
svn: E000002: Can't change perms of file '/cygdrive/c/Users/harryr/test_subversion/ced/.svn/pristine/85/85d3a383ab07dabcd654cbe2d4bfea4f6a658b6c.svn-base': No such file or directory

ced/trunk is the only path that actually has files in it.

$ svn list file:///usr/local/svnroot/ced/trunk/cedmain.c
cedmain.c

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: subversion problem

[David Rothenberger]

Rockefeller, Harry wrote:
> I just updated packages this morning and noticed there were some
> subversion updates.  I was wondering if version 10 is new and requires me to do something?
> Or maybe the recent release broke something?

It looks like something is broken in 1.10.0, probably by me and not upstream. I'll investigate as soon as I can, but it may not be until next week. In the meantime, I suggest downgrading to 1.9 version.

-- 
David Rothenberger  ----  daveroth@acm.org

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: subversion problem

[Andrey Repin]

Greetings, Rockefeller, Harry!

> I just updated packages this morning and noticed there were some
> subversion updates.  I was wondering if version 10 is new and requires me to do something?
> Or maybe the recent release broke something?

Did you read the release notes before making this post?...


-- 
With best regards,
Andrey Repin
Monday, April 23, 2018 23:50:44

Sorry for my terrible english...


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

RE: subversion problem

[Rockefeller, Harry]

David wrote:
>It looks like something is broken in 1.10.0, probably by me and not upstream. I'll investigate as soon as I can, but it may >not be until next week. In the meantime, I suggest downgrading to 1.9 version.

Thank you.  Downgrading to 1.9.7 works for me.


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

RE: subversion problem

[Rockefeller, Harry]

>-----Original Message-----
>From: Andrey Repin
>Sent: Monday, April 23, 2018 3:51 PM
>To: Rockefeller, Harry;  cygwin@cygwin.com
>Subject: Re: subversion problem

>Greetings, Rockefeller, Harry!

>> I just updated packages this morning and noticed there were some
>> subversion updates.  I was wondering if version 10 is new and requires me to do something?
>> Or maybe the recent release broke something?

>Did you read the release notes before making this post?

No.  I did read them quickly afterward when I went to the Cygwin mailing list archive.
 I didn't see anything that I needed to do.



--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: subversion problem

[Yasutaka Atarashi]

Hi David,

I had some doubt that the modification suggested in my mail:
Cygwin subversion and UNC path https://cygwin.com/ml/cygwin/2018-04/msg00271.html
would cause the failure.
However, this would not be the case.

I'm afraid to say that it seems to be an oversight in 05-retry-loop.patch.

The first call of the loop target function must be made BEFORE the call of WIN32_RETRY_LOOP() while Cygwin branch of svn_io_file_rename2() calls WIN32_RETRY_LOOP() directly. 

I've made just simple tests only but applying the following patch additionally and replacing cygsvn_subr-1-0.dll seems to fix the issues.

--- origsrc/subversion-1.10.0/subversion/libsvn_subr/io.c	2018-04-24 15:58:49.920742300 +0900
+++ src/subversion-1.10.0/subversion/libsvn_subr/io.c	2018-04-24 21:16:56.215447100 +0900
@@ -4294,6 +4294,7 @@ svn_io_file_rename2(const char *from_pat
       status = apr_file_rename(from_path_apr, to_path_apr, pool);
     }
 #elif defined (__CYGWIN__)
+  status = apr_file_rename(from_path_apr, to_path_apr, pool);
   WIN32_RETRY_LOOP(status, apr_file_rename(from_path_apr, to_path_apr, pool));
 #else
   status = apr_file_rename(from_path_apr, to_path_apr, pool);

Regards,
Yasutaka ATARASHI

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: subversion problem

[David Rothenberger]

Yasutaka Atarashi wrote:
> I had some doubt that the modification suggested in my mail:
> Cygwin subversion and UNC path https://cygwin.com/ml/cygwin/2018-04/msg00271.html
> would cause the failure.
> However, this would not be the case.

Yes, I agree your change is not the source of the problem.

> 
> I'm afraid to say that it seems to be an oversight in 05-retry-loop.patch.
> 
> The first call of the loop target function must be made BEFORE the call of WIN32_RETRY_LOOP() while Cygwin branch of svn_io_file_rename2() calls WIN32_RETRY_LOOP() directly.

Thanks, I agree this is the likely source of the problem. I won't have time to try it until this weekend. Thanks for investigating.


-- 
David Rothenberger  ----  daveroth@acm.org


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple