[ANNOUNCEMENT] Updated/Test: base-files-4.3-1

[ANNOUNCEMENT] Updated/Test: base-files-4.3-1

[Achim Gratz]

Base-files has been updated to version 4.1-1.  This is a feature
release, currently available for testing (you need to manually select
that version in setup.exe).

4.3-1 (feature release)
    * Cygwin.bat: Add to base-files.  This version is independent of
      the actual install path, see:
      cygwin.com/ml/cygwin/2016-08/msg00617.html
    * etc/defaults/etc/profile: Allow the use of the unaltered
      existing system PATH by setting the system variable
      CYGWIN_USEWINPATH.
    * etc/defaults/etc/profile: avoid second invocation of
      /usr/bin/hostname.  Reported by Helmut Karlowski, see
      cygwin.com/ml/cygwin/2015-12/msg00080.html
    * etc/postinstall/base-files-mketc.sh (WINETC): Use /proc/cygdrive
      prefixed path which keeps working even if the user changes the
      /cygdrive prefix after installation.


-- 
              *** CYGWIN-ANNOUNCE UNSUBSCRIBE INFO ***

If you want to unsubscribe from the cygwin-announce mailing list, look
at the "List-Unsubscribe: " tag in the email header of this message.
Send email to the address specified there. It will be in the format:

cygwin-announce-unsubscribe-you=yourdomain.com@cygwin.com

If you need more information on unsubscribing, start reading here:

http://sourceware.org/lists.html#unsubscribe-simple

Please read *all* of the information on unsubscribing that is available
starting at this URL.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] Updated/Test: base-files-4.3-1

[Christian Franke]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

Achim Gratz wrote:
> 4.3-1 (feature release)
>      * Cygwin.bat: Add to base-files.  This version is independent of
>        the actual install path, see:
>        cygwin.com/ml/cygwin/2016-08/msg00617.html

Thanks for accepting the patch.

Unfortunately I missed a detail: The postinstall script does not 
preserve the x-permission of Cygwin.bat. This is required if run from 
explorer or with 'cygstart /Cygwin.bat'.

Possible fix attached. Alternatively remove the 'touch' command and the 
x-permission from etc/defaults/etc/profile.

Thanks,
Christian


[-- Attachment #2: base-files-4.3-1-x-perm.patch --]
[-- Type: text/x-patch, Size: 496 bytes --]

--- base-files-profile.sh.orig	2016-09-03 13:37:59.000000000 +0200
+++ base-files-profile.sh	2016-09-04 12:42:40.805222900 +0200
@@ -18,7 +18,7 @@
   if [ ! -e ${fDest} -a ! -L ${fDest} ]; then
     echo "Using the default version of ${fDest} (${fSrc})"
     /usr/bin/mkdir -p $(dirname ${fDest})
-    /usr/bin/touch ${fDest}
+    test "${fDest}" = "/Cygwin.bat" || /usr/bin/touch ${fDest}
     /usr/bin/cp ${fSrc} ${fDest}
   else
     echo "${fDest} is already in existence, not overwriting."


[-- Attachment #3: Type: text/plain, Size: 218 bytes --]

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] Updated/Test: base-files-4.3-1

[Achim Gratz]

Christian Franke writes:
> --- base-files-profile.sh.orig	2016-09-03 13:37:59.000000000 +0200
> +++ base-files-profile.sh	2016-09-04 12:42:40.805222900 +0200
> @@ -18,7 +18,7 @@
>    if [ ! -e ${fDest} -a ! -L ${fDest} ]; then
>      echo "Using the default version of ${fDest} (${fSrc})"
>      /usr/bin/mkdir -p $(dirname ${fDest})
> -    /usr/bin/touch ${fDest}
> +    test "${fDest}" = "/Cygwin.bat" || /usr/bin/touch ${fDest}
>      /usr/bin/cp ${fSrc} ${fDest}
>    else
>      echo "${fDest} is already in existence, not overwriting."

I have no idea why it's touching the file first, but I'd rather use

cp --preserve=mode

and fix the mode bits in /etc/defaults if necessary.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf microQ V2.22R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] Updated/Test: base-files-4.3-1

[Christian Franke]

Achim Gratz wrote:
> Christian Franke writes:
>> --- base-files-profile.sh.orig	2016-09-03 13:37:59.000000000 +0200
>> +++ base-files-profile.sh	2016-09-04 12:42:40.805222900 +0200
>> @@ -18,7 +18,7 @@
>>     if [ ! -e ${fDest} -a ! -L ${fDest} ]; then
>>       echo "Using the default version of ${fDest} (${fSrc})"
>>       /usr/bin/mkdir -p $(dirname ${fDest})
>> -    /usr/bin/touch ${fDest}
>> +    test "${fDest}" = "/Cygwin.bat" || /usr/bin/touch ${fDest}
>>       /usr/bin/cp ${fSrc} ${fDest}
>>     else
>>       echo "${fDest} is already in existence, not overwriting."
> I have no idea why it's touching the file first, but I'd rather use
>
> cp --preserve=mode
>
> and fix the mode bits in /etc/defaults if necessary.

I guess the touch command is from the early days to ensure that all 
files get same default permissions regardless of source file permissions.

Removing the touch command would be sufficient. A 'cp' without options 
uses the permission mask from source file when a new file is created 
(POSIX requirement). Cygport's make_etc_defaults also generates plain 
/usr/bin/cp commands.

"cp --preserve" would also copy owner and timestamps.

Regards,
Christian


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] Updated/Test: base-files-4.3-1

[Achim Gratz]

Christian Franke writes:
> Removing the touch command would be sufficient. A 'cp' without options
> uses the permission mask from source file when a new file is created
> (POSIX requirement). Cygport's make_etc_defaults also generates plain
> /usr/bin/cp commands.
>
> "cp --preserve" would also copy owner and timestamps.

No, a 'cp -p" would do.  I've explicitly told it to just copy the mode
bits.

Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

Re: [ANNOUNCEMENT] Updated/Test: base-files-4.3-1

[Christian Franke]

Achim Gratz wrote:
> Christian Franke writes:
>> Removing the touch command would be sufficient. A 'cp' without options
>> uses the permission mask from source file when a new file is created
>> (POSIX requirement). Cygport's make_etc_defaults also generates plain
>> /usr/bin/cp commands.
>>
>> "cp --preserve" would also copy owner and timestamps.
> No, a 'cp -p" would do.  I've explicitly told it to just copy the mode
> bits.

Yes - sorry for the noise.

Regards,
Christian


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple