[pkg cygwin-devel] /usr/include/sys/cpuset.h:52 error: missing return type

[pkg cygwin-devel] /usr/include/sys/cpuset.h:52 error: missing return type

[Marco Mason]

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

I just updated to 3.4.9-1 and compiled some code, and it complained about
cpuset.h.
Specifically, "C++ requires a type specifier for all declarations", and
sure enough, there's no return type on line 52.  So I changed my local copy
to the following, and it cleared things up:

#define CPU_ZERO_S(siz, set) __cpuset_zero_s (siz, set)
static __inline /*MCM*/ void /*MCM*/
__cpuset_zero_s (__size_t siz, cpu_set_t *set)
{

I looked at a couple mailing list archives and saw that the cpuset.h header
was worked on recently, but couldn't track it down any closer.  I also
tried to find a git repository so I could find the commit so I could check
for similar errors on other headers, but couldn't find the repo for
cygwin-devel anywhere.

Re: [pkg cygwin-devel] /usr/include/sys/cpuset.h:52 error: missing return type

[Mark Geisert]

Hi Marco,

Marco Mason via Cygwin wrote:
> I just updated to 3.4.9-1 and compiled some code, and it complained about
> cpuset.h.
> Specifically, "C++ requires a type specifier for all declarations", and
> sure enough, there's no return type on line 52.  So I changed my local copy
> to the following, and it cleared things up:
> 
> #define CPU_ZERO_S(siz, set) __cpuset_zero_s (siz, set)
> static __inline /*MCM*/ void /*MCM*/
> __cpuset_zero_s (__size_t siz, cpu_set_t *set)
> {

Thanks for the report; right you are.

> I looked at a couple mailing list archives and saw that the cpuset.h header
> was worked on recently, but couldn't track it down any closer.  I also
> tried to find a git repository so I could find the commit so I could check
> for similar errors on other headers, but couldn't find the repo for
> cygwin-devel anywhere.

This error was introduced with the most recent update to cpuset.h.  There is a 
public-visible mirror of the Cygwin tree at
     https://github.com/cygwin/cygwin/blob/main/winsup/cygwin
and the problematic file can be found at
     include/sys/cpuset.h
within.

Your bug report and proposed correction are all we need for the issue you ran 
into.  I'll submit a patch shortly.
Thanks again,

..mark

Re: [pkg cygwin-devel] /usr/include/sys/cpuset.h:52 error: missing return type

[Jon Turney]

> Marco Mason via Cygwin wrote:
> 
>> I looked at a couple mailing list archives and saw that the cpuset.h 
>> header
>> was worked on recently, but couldn't track it down any closer.  I also
>> tried to find a git repository so I could find the commit so I could 
>> check
>> for similar errors on other headers, but couldn't find the repo for
>> cygwin-devel anywhere.
> 
> This error was introduced with the most recent update to cpuset.h.  
> There is a public-visible mirror of the Cygwin tree at
>      https://github.com/cygwin/cygwin/blob/main/winsup/cygwin
> and the problematic file can be found at
>      include/sys/cpuset.h
> within.

You can also view the official repository at 
https://www.cygwin.com/cgit/newlib-cygwin/

This is linked to from https://cygwin.com/git.html, which is accessible 
via "Source in Git" on the sidebar at https://cygwin.com/

If you have any suggestions as to how to structure things to make this 
more easily discoverable, they are welcome.