Re: [PATCH 1/2] Read DWARF5 .debug_line.

[Jakub Jelinek <jakub@redhat.com>]

On Mon, Oct 12, 2020 at 09:06:48PM +0200, Mark Wielaard wrote:
> This handles reading DWARF5 .debug_line just like earlier DWARF versions.
> Sets file time and size to zero when not present. It skips the zero entry
> file entry (which cannot be referred to from any attribute since the value
> zero indicates that no source file), but does read the zero dir entry
> (which can be referred to from the file index). It does not yet handle
> MD5 checksums.
> 
> ChangeLog:
> 
> 	* dwz.c (get_DW_LNCT_str): New function.
> 	(skip_attr_no_dw_form_indirect): Move before read_debug_line.
> 	(read_debug_line): Handle version 5.
> ---
>  dwz.c | 611 ++++++++++++++++++++++++++++++++++++++++++++++------------
>  1 file changed, 487 insertions(+), 124 deletions(-)
> 
> diff --git a/dwz.c b/dwz.c
> index 9dbf651..9345e6c 100644
> --- a/dwz.c
> +++ b/dwz.c
> @@ -711,6 +711,28 @@ get_DW_UT_str (unsigned int ut)
>    return buf;
>  }
>  
> +/* Retrun a DW_LNCT_* name.  */

s/Retrun/Return/

> +	    case DW_LNCT_path:
> +	      if (path_ndx != -1)
> +		{
> +		  error (0, 0,
> +			 "%s: .debug_line duplicate file path elements\n",

I think no other error calls have \n at the end of the message in the whole
source (several times in the patch).

Otherwise LGTM.

	Jakub