public inbox for
 help / color / mirror / Atom feed
From: Mark Wielaard <>
To: Jakub Jelinek <>
Subject: Re: [PATCH 1/2] Read DWARF5 .debug_line.
Date: Tue, 13 Oct 2020 23:14:01 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20201013141916.GC2176@tucnak>

On Tue, Oct 13, 2020 at 04:19:16PM +0200, Jakub Jelinek wrote:
> On Mon, Oct 12, 2020 at 09:06:48PM +0200, Mark Wielaard wrote:
> > +/* Retrun a DW_LNCT_* name.  */
> s/Retrun/Return/


> > +		  error (0, 0,
> > +			 "%s: .debug_line duplicate file path elements\n",
> I think no other error calls have \n at the end of the message in the whole
> source (several times in the patch).

Oops. Yes, you are right error adds a newline itself.  Also removed
the trailing '\n' from error calls in read_loclist_low_mem_phase1,
read_loclist, write_dso, dwz and optimize_multifile.

> Otherwise LGTM.

Thanks, pushed.


      reply	other threads:[~2020-10-13 21:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 19:06 Mark Wielaard
2020-10-12 19:06 ` [PATCH 2/2] Write DWARF5 multifile .debug_line if possible Mark Wielaard
2020-10-13 14:23   ` Jakub Jelinek
2020-10-13 14:19 ` [PATCH 1/2] Read DWARF5 .debug_line Jakub Jelinek
2020-10-13 21:14   ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).