From: Jakub Jelinek <jakub@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: dwz@sourceware.org
Subject: Re: [PATCH 2/2] Write DWARF5 multifile .debug_line if possible.
Date: Tue, 13 Oct 2020 16:23:44 +0200 [thread overview]
Message-ID: <20201013142344.GD2176@tucnak> (raw)
In-Reply-To: <20201012190649.17808-2-mark@klomp.org>
On Mon, Oct 12, 2020 at 09:06:49PM +0200, Mark Wielaard wrote:
> This write version 5 .debug_line into the multifile if all .debug_line
> segments seen before are also version 5. This is more efficient than
> version 2, if we don't have to write out the time and size of the files.
> But only if there are more than ~25 files because the header is bigger
> and there is some overhead for having to handle zero entry dir and file
> entries (those do have to exist, but are not directly referenced by
> anything).
>
> ChangeLog:
>
> * dwz.c (lowest_line_version): New static unsigned int, set
> to 5 initially.
> (read_debug_line): Check version and set lowest_line_version.
> (struct line_stats): New.
> (list_line_entries): Update data as struct line_stats.
> (write_multifile_line): Collect time and size stats and write
> out version 5 .debug_line data if lowest_line_version is 5.
LGTM.
Jakub
next prev parent reply other threads:[~2020-10-13 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 19:06 [PATCH 1/2] Read DWARF5 .debug_line Mark Wielaard
2020-10-12 19:06 ` [PATCH 2/2] Write DWARF5 multifile .debug_line if possible Mark Wielaard
2020-10-13 14:23 ` Jakub Jelinek [this message]
2020-10-13 14:19 ` [PATCH 1/2] Read DWARF5 .debug_line Jakub Jelinek
2020-10-13 21:14 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013142344.GD2176@tucnak \
--to=jakub@redhat.com \
--cc=dwz@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).