Re: [PATCH] Add do-release.sh

[Tom de Vries <tdevries@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1652 bytes --]

On 29-07-19 19:20, Jakub Jelinek wrote:
> On Mon, Jul 22, 2019 at 09:41:33AM +0200, Tom de Vries wrote:
>> Hi,
>>
>> this commit adds a script that:
>> - bumps either the minor or the major version, using options
>>   --major or --minor
>> - updates VERSION
>> - commits VERSION update
>> - tags VERSION update
>>
>> OK for trunk?
>>
>> Is there anything else involved in doing a release?
> 
> I think that is all, bumping VERSION, commiting and tagging was all I did in
> the past.
> 
> One thing that might be worth doing is bump copyright years on files you've
> modified, I know dwz.c has been using mostly Red Hat copyright, if you want
> to use say FSF copyright, can you change that 2003 in there to 2003, 2019?
> Or do you want to use SUSE copyright instead?
> I guess because I have touched dwz.c last year the RH copyright should be
> -2018 instead of -2015 too, and dwarf2.def should be probably changed to
> 1992-2018 FSF copyright, using the simple range.  After the release we
> should likely import new dwarf2.def and dwarf2.h from GCC tree.

Hmm, something I overlooked:
...
$ ./dwz --version
dwz version 0.13
Copyright (C) 2001-2012 Red Hat, Inc.
Copyright (C) 2003 Free Software Foundation, Inc.
...

We've updated the copyright in the file headers, but not in the version
message.

Patch below fixes this, updating the message using the copyright from
the dwz.c file header.

I wonder though, what about the copyright in the other files:
dwarf2.def, dwarf2.h, dwarfnames.c, hashtab.c, hashtab.h, sha1.c and
sha1.h? Should we take the copyright in those files into account as
well? Or is it just dwz.c that matters?

Thanks,
- Tom




[-- Attachment #2: 0001-Update-version-copyright-message.patch --]
[-- Type: text/x-patch, Size: 953 bytes --]

Update --version copyright message

In commit 9a663b4 "Update copyright" we've updated copyright in the sources,
but not in the --version copyright message.

Update the --version copyright message.

2019-08-12  Tom de Vries  <tdevries@suse.de>

	* dwz.c (version): Update copyright message.

---
 dwz.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dwz.c b/dwz.c
index 266f56d..6f58134 100644
--- a/dwz.c
+++ b/dwz.c
@@ -12395,8 +12395,9 @@ version (void)
 {
   fprintf (stderr,
 	   "dwz version " DWZ_VERSION "\n"
-	   "Copyright (C) 2001-2012 Red Hat, Inc.\n"
+	   "Copyright (C) 2001-2018 Red Hat, Inc.\n"
 	   "Copyright (C) 2003 Free Software Foundation, Inc.\n"
+	   "Copyright (C) 2019 SUSE LLC."
 	   "This program is free software; you may redistribute it under the terms of\n"
 	   "the GNU General Public License version 3 or (at your option) any later version.\n"
 	   "This program has absolutely no warranty.\n");