* [Bug default/24275] hardlink handling leaves temporary file if not file compressed
2019-01-01 0:00 [Bug default/24275] New: hardlink handling leaves temporary file if not file compressed vries at gcc dot gnu.org
@ 2019-01-01 0:00 ` vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: vries at gcc dot gnu.org @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24275
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
posted patch: https://sourceware.org/ml/dwz/2019-q1/msg00060.html
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug default/24275] hardlink handling leaves temporary file if not file compressed
2019-01-01 0:00 [Bug default/24275] New: hardlink handling leaves temporary file if not file compressed vries at gcc dot gnu.org
2019-01-01 0:00 ` [Bug default/24275] " vries at gcc dot gnu.org
@ 2019-01-01 0:00 ` vries at gcc dot gnu.org
2020-01-01 0:00 ` jakub at redhat dot com
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: vries at gcc dot gnu.org @ 2019-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24275
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at redhat dot com
--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
AFAIU, the problem originates from the fact that the dedicated handling for
this case in the dwz function:
...
/* If a hardlink to this has been processed before
and we didn't change it, just assume the same
state. */
if (resa[n].res == 1)
{
close (fd);
res->res = -2;
return 1;
}
...
is not triggered when called with b.out argument because this code at the end
of dwz:
...
free (dso);
if (ret == 0 && !low_mem)
res->res = 0;
return ret;
...
sets resa[n].res to 0 when called with a.out argument, irregardless of whether
a.out was changed or not.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug default/24275] hardlink handling leaves temporary file if not file compressed
2019-01-01 0:00 [Bug default/24275] New: hardlink handling leaves temporary file if not file compressed vries at gcc dot gnu.org
2019-01-01 0:00 ` [Bug default/24275] " vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org
@ 2020-01-01 0:00 ` jakub at redhat dot com
2020-01-01 0:00 ` vries at gcc dot gnu.org
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jakub at redhat dot com @ 2020-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24275
--- Comment #3 from Jakub Jelinek <jakub at redhat dot com> ---
Tom, has this been fixed already or forgotten?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug default/24275] hardlink handling leaves temporary file if not file compressed
2019-01-01 0:00 [Bug default/24275] New: hardlink handling leaves temporary file if not file compressed vries at gcc dot gnu.org
` (2 preceding siblings ...)
2020-01-01 0:00 ` jakub at redhat dot com
@ 2020-01-01 0:00 ` vries at gcc dot gnu.org
2020-10-01 13:19 ` mark at klomp dot org
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: vries at gcc dot gnu.org @ 2020-01-01 0:00 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24275
--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #3)
> Tom, has this been fixed already or forgotten?
Neither, I just didn't plan this for the upcoming release, but for the one
after that.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug default/24275] hardlink handling leaves temporary file if not file compressed
2019-01-01 0:00 [Bug default/24275] New: hardlink handling leaves temporary file if not file compressed vries at gcc dot gnu.org
` (3 preceding siblings ...)
2020-01-01 0:00 ` vries at gcc dot gnu.org
@ 2020-10-01 13:19 ` mark at klomp dot org
2020-10-02 4:09 ` jirislaby at gmail dot com
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: mark at klomp dot org @ 2020-10-01 13:19 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24275
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mark at klomp dot org
See Also| |https://sourceware.org/bugz
| |illa/show_bug.cgi?id=26645
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug default/24275] hardlink handling leaves temporary file if not file compressed
2019-01-01 0:00 [Bug default/24275] New: hardlink handling leaves temporary file if not file compressed vries at gcc dot gnu.org
` (4 preceding siblings ...)
2020-10-01 13:19 ` mark at klomp dot org
@ 2020-10-02 4:09 ` jirislaby at gmail dot com
2020-11-08 22:25 ` mark at klomp dot org
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jirislaby at gmail dot com @ 2020-10-02 4:09 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24275
Jiri Slaby <jirislaby at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jirislaby at gmail dot com
--- Comment #5 from Jiri Slaby <jirislaby at gmail dot com> ---
(In reply to Tom de Vries from comment #4)
> Neither, I just didn't plan this for the upcoming release, but for the one
> after that.
So what about now? It still triggers, currently it bites perf in openSUSE, see
bug 26645 and
https://build.opensuse.org/package/view_file/openSUSE:Factory/perf/perf.spec?expand=1:
# a bug in dwz leaves temporary trace-*.debug.#dwz#.* on 64 bits in place
# remove this once fixed, see:
# https://sourceware.org/bugzilla/show_bug.cgi?id=26645
%define _find_debuginfo_dwz_opts %{nil}
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug default/24275] hardlink handling leaves temporary file if not file compressed
2019-01-01 0:00 [Bug default/24275] New: hardlink handling leaves temporary file if not file compressed vries at gcc dot gnu.org
` (5 preceding siblings ...)
2020-10-02 4:09 ` jirislaby at gmail dot com
@ 2020-11-08 22:25 ` mark at klomp dot org
2021-02-13 22:57 ` mark at klomp dot org
2021-03-04 8:07 ` vries at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: mark at klomp dot org @ 2020-11-08 22:25 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24275
--- Comment #6 from Mark Wielaard <mark at klomp dot org> ---
The new testcase still fails, but the fix doesn't apply as is because the code
logic has changed a bit.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug default/24275] hardlink handling leaves temporary file if not file compressed
2019-01-01 0:00 [Bug default/24275] New: hardlink handling leaves temporary file if not file compressed vries at gcc dot gnu.org
` (6 preceding siblings ...)
2020-11-08 22:25 ` mark at klomp dot org
@ 2021-02-13 22:57 ` mark at klomp dot org
2021-03-04 8:07 ` vries at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: mark at klomp dot org @ 2021-02-13 22:57 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24275
--- Comment #7 from Mark Wielaard <mark at klomp dot org> ---
*** Bug 26645 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug default/24275] hardlink handling leaves temporary file if not file compressed
2019-01-01 0:00 [Bug default/24275] New: hardlink handling leaves temporary file if not file compressed vries at gcc dot gnu.org
` (7 preceding siblings ...)
2021-02-13 22:57 ` mark at klomp dot org
@ 2021-03-04 8:07 ` vries at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: vries at gcc dot gnu.org @ 2021-03-04 8:07 UTC (permalink / raw)
To: dwz
https://sourceware.org/bugzilla/show_bug.cgi?id=24275
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from Tom de Vries <vries at gcc dot gnu.org> ---
Fixed at
https://sourceware.org/git/?p=dwz.git;a=commit;h=05d55402d9f611177f2425e237686c165b635e2d
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 10+ messages in thread