From: "Arnaud Chataignier" <achataignier@neotion.com>
To: "'Gary Thomas'" <gary@mlbassoc.com>,
"'Nick Garnett'" <nickg@ecoscentric.com>
Cc: "'Andrew Lunn'" <andrew@lunn.ch>,
"'Sturle Mastberg'" <sturle.mastberg@tandberg.net>,
"'eCos Discussion'" <ecos-discuss@ecos.sourceware.org>
Subject: [ECOS] RE : [ECOS] Possible fix for duplicated ARP entries in the FreeBSDstack
Date: Mon, 20 Jun 2005 09:05:00 -0000 [thread overview]
Message-ID: <001001c57577$1c629d30$140032be@ArnaudC> (raw)
In-Reply-To: <1119013047.13965.253.camel@hermes>
Thank you all for the analysis. I was encountering this bug from a long
time now, and fixing it is great news for me.
One person did post a temporary patch to this problem a long time ago,
but it didn't seem to really correct the cause of the problem, it was
just avoiding it :
http://sourceware.org/ml/ecos-discuss/2004-11/msg00150.html
May anyone post a patch corresponding to this real correction ? As far
as I understand, it is only a matter of changing the size of the sa_data
member back to 14 ?
Thank you,
Arnaud.
-----Message d'origine-----
De : ecos-discuss-owner@ecos.sourceware.org
[mailto:ecos-discuss-owner@ecos.sourceware.org] De la part de Gary
Thomas
Envoyé : vendredi 17 juin 2005 14:57
À : Nick Garnett
Cc : Andrew Lunn; Sturle Mastberg; eCos Discussion
Objet : Re: [ECOS] Possible fix for duplicated ARP entries in the
FreeBSDstack
On Fri, 2005-06-17 at 13:53 +0100, Nick Garnett wrote:
> Andrew Lunn <andrew@lunn.ch> writes:
>
> > On Fri, Jun 17, 2005 at 12:57:49PM +0200, Sturle Mastberg wrote:
> > > Gary Thomas wrote:
> > > >On Fri, 2005-06-17 at 10:52 +0200, Sturle Mastberg wrote:
> > > >
> > > >>Hello,
> > > >>
> > > >>For some time I've had problem with duplicated ARP entries that
> > > >>have
> > > >>caused all sorts of problems. I searched the archive and
discovered that
> > > >>the problem had been reported before:
> > > >>
> > > >>
> > > >>http://sourceware.org/ml/ecos-discuss/2004-11/msg00097.html
> > > >>
> > > >>
> > > >>My proposal to a fix is to make the sockaddr_inarp struct
> > > >>(include/netinet/if_ether.h) equal in size to the sockaddr
struct by
> > > >>padding it at the end. This is exactly what is done to the
sockaddr_in
> > > >>struct (include/netinet/in.h) for different reasons.
> > > >>
> > > >>
> > > >>I reached this conclusion after I discovered that two virutally
> > > >>identical calls to rtalloc1 (net/route.c) returned different
results.
> > > >>The first instance appears in arplookup (netinet/if_ether.c)
where the
> > > >>first parameter to rtalloc1 is a struct sockaddr_inarp cast to a
struct
> > > >>sockaddr. The second instance appears in ip_output
(netinet/ip_output)
> > > >>via rtalloc_ign (net/route.c) where the first parameter to
rtalloc1 is
> > > >>an actual struct sockaddr. The rtalloc1 function does a radix
tree
> > > >>search with a call to the rn_match function (net/radix.c). A
closer look
> > > >>at this code reveals that it does indeed depend on the size of
the
> > > >>supplied struct.
> > > >>
> > > >>
> > > >>The only conclusion a can draw from this is that the three
> > > >>structs:
> > > >>sockaddr, sockaddr_in and sockaddr_inarp must all be of equal
size. I
> > > >>have checked the FreeBSD source repository that this is the case
for the
> > > >>original code.
> > > >>
> > > >>
> > > >>While browsing the FreeBSD source repository I discovered that
> > > >>the
> > > >>sa_data character array member of the sockaddr struct was
increased in
> > > >>size in the eCos FreeBSD stack. Does anyone know why this
increase was
> > > >>introduced in eCos?
> >
> > I beleave Nick did this for IPv6. This bigger size allows an IPv6
> > address to be placed into a sockaddr which you cannot normally do.
>
> I thought that initially and had a look. The change I made was to
> struct sockaddr_in to make it match the increased sockaddr size so
> that some punned data structures would match. I think the change to
> struct sockaddr was done by Gary during the initial port to make IPv6
> addresses fit correctly. I'm sure it all has something to do with the
> lack of user/kernel space and the fact that we don't copy things to
> and fro as much as the BSD kernel does.
This is as I remember it as well. Note the comment in the structure
(which I did not add or change) that bodes of this inconsistency.
Of course, if someone has a better way to handle it, feel free to post a
patch :-)
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
next prev parent reply other threads:[~2005-06-20 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-17 8:52 [ECOS] Possible fix for duplicated ARP entries in the FreeBSD stack Sturle Mastberg
2005-06-17 10:01 ` Gary Thomas
2005-06-17 10:58 ` Sturle Mastberg
2005-06-17 11:30 ` Andrew Lunn
2005-06-17 12:53 ` Nick Garnett
2005-06-17 12:57 ` Gary Thomas
2005-06-20 9:05 ` Arnaud Chataignier [this message]
2005-06-20 10:12 ` [ECOS] Re: RE : [ECOS] Possible fix for duplicated ARP entries in the FreeBSDstack Sturle Mastberg
2005-06-20 10:26 ` [ECOS] " Nick Garnett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001001c57577$1c629d30$140032be@ArnaudC' \
--to=achataignier@neotion.com \
--cc=andrew@lunn.ch \
--cc=ecos-discuss@ecos.sourceware.org \
--cc=gary@mlbassoc.com \
--cc=nickg@ecoscentric.com \
--cc=sturle.mastberg@tandberg.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).