public inbox for ecos-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Nick Garnett <nickg@ecoscentric.com>
To: "Arnaud Chataignier" <achataignier@neotion.com>
Cc: "'Gary Thomas'" <gary@mlbassoc.com>,
	"'Andrew Lunn'" <andrew@lunn.ch>,
	"'Sturle Mastberg'" <sturle.mastberg@tandberg.net>,
	"'eCos Discussion'" <ecos-discuss@ecos.sourceware.org>
Subject: Re: [ECOS] RE : [ECOS] Possible fix for duplicated ARP entries in the FreeBSDstack
Date: Mon, 20 Jun 2005 10:26:00 -0000	[thread overview]
Message-ID: <m38y151fzl.fsf@xl5.calivar.com> (raw)
In-Reply-To: <001001c57577$1c629d30$140032be@ArnaudC>

"Arnaud Chataignier" <achataignier@neotion.com> writes:

> Thank you all for the analysis. I was encountering this bug from a long
> time now, and fixing it is great news for me.
> 
> One person did post a temporary patch to this problem a long time ago,
> but it didn't seem to really correct the cause of the problem, it was
> just avoiding it :
> http://sourceware.org/ml/ecos-discuss/2004-11/msg00150.html
> 
> May anyone post a patch corresponding to this real correction ? As far
> as I understand, it is only a matter of changing the size of the sa_data
> member back to 14 ?

I think the analysis indicates that the sa_data field should not be
changed back to 14, that would break IPv6 support. I suspect the
correct solution is to increase sockaddr_inarp to match sockaddr and
sockaddr_in. However, this code is Gary's baby, so he should have the
last say.

The root cause of this is some rather questionable assumptions in the
BSD stack about equivalence of sizes of various structures. These
probably don't have any effect in BSD since the copying between user
and kernel space masks problem.

-- 
Nick Garnett                                     eCos Kernel Architect
http://www.ecoscentric.com                The eCos and RedBoot experts


-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

      parent reply	other threads:[~2005-06-20 10:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-17  8:52 [ECOS] Possible fix for duplicated ARP entries in the FreeBSD stack Sturle Mastberg
2005-06-17 10:01 ` Gary Thomas
2005-06-17 10:58   ` Sturle Mastberg
2005-06-17 11:30     ` Andrew Lunn
2005-06-17 12:53       ` Nick Garnett
2005-06-17 12:57         ` Gary Thomas
2005-06-20  9:05           ` [ECOS] RE : [ECOS] Possible fix for duplicated ARP entries in the FreeBSDstack Arnaud Chataignier
2005-06-20 10:12             ` [ECOS] " Sturle Mastberg
2005-06-20 10:26             ` Nick Garnett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m38y151fzl.fsf@xl5.calivar.com \
    --to=nickg@ecoscentric.com \
    --cc=achataignier@neotion.com \
    --cc=andrew@lunn.ch \
    --cc=ecos-discuss@ecos.sourceware.org \
    --cc=gary@mlbassoc.com \
    --cc=sturle.mastberg@tandberg.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).