From: Sturle Mastberg <sturle.mastberg@tandberg.net>
To: Arnaud Chataignier <achataignier@neotion.com>
Cc: "'Gary Thomas'" <gary@mlbassoc.com>,
"'Nick Garnett'" <nickg@ecoscentric.com>,
"'Andrew Lunn'" <andrew@lunn.ch>,
"'eCos Discussion'" <ecos-discuss@ecos.sourceware.org>
Subject: [ECOS] Re: RE : [ECOS] Possible fix for duplicated ARP entries in the FreeBSDstack
Date: Mon, 20 Jun 2005 10:12:00 -0000 [thread overview]
Message-ID: <42B6969A.4060305@tandberg.net> (raw)
In-Reply-To: <001001c57577$1c629d30$140032be@ArnaudC>
Arnaud Chataignier wrote:
> Thank you all for the analysis. I was encountering this bug from a long
> time now, and fixing it is great news for me.
>
> One person did post a temporary patch to this problem a long time ago,
> but it didn't seem to really correct the cause of the problem, it was
> just avoiding it :
> http://sourceware.org/ml/ecos-discuss/2004-11/msg00150.html
>
> May anyone post a patch corresponding to this real correction ? As far
> as I understand, it is only a matter of changing the size of the sa_data
> member back to 14 ?
No, the increase in size of the sa_data member was apparently needed for
IPv6. The fix is as I stated first: the sockaddr_inarp struct must be
padded to match the size of the sockaddr struct. This can be done by
adding a sin_zero member at the end of this struct, defined in
include/netinet/if_ether.h. Like this:
struct sockaddr_inarp {
u_char sin_len;
u_char sin_family;
u_short sin_port;
struct in_addr sin_addr;
struct in_addr sin_srcaddr;
u_short sin_tos;
u_short sin_other;
char sin_zero[16];
#define SIN_PROXY 1
};
Regards,
SM
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
next prev parent reply other threads:[~2005-06-20 10:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-17 8:52 [ECOS] Possible fix for duplicated ARP entries in the FreeBSD stack Sturle Mastberg
2005-06-17 10:01 ` Gary Thomas
2005-06-17 10:58 ` Sturle Mastberg
2005-06-17 11:30 ` Andrew Lunn
2005-06-17 12:53 ` Nick Garnett
2005-06-17 12:57 ` Gary Thomas
2005-06-20 9:05 ` [ECOS] RE : [ECOS] Possible fix for duplicated ARP entries in the FreeBSDstack Arnaud Chataignier
2005-06-20 10:12 ` Sturle Mastberg [this message]
2005-06-20 10:26 ` Nick Garnett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42B6969A.4060305@tandberg.net \
--to=sturle.mastberg@tandberg.net \
--cc=achataignier@neotion.com \
--cc=andrew@lunn.ch \
--cc=ecos-discuss@ecos.sourceware.org \
--cc=gary@mlbassoc.com \
--cc=nickg@ecoscentric.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).