* [ECOS] tftp server stack problems
@ 2006-05-25 10:00 Jürgen Lambrecht
2006-05-25 10:36 ` Andrew Lunn
0 siblings, 1 reply; 4+ messages in thread
From: Jürgen Lambrecht @ 2006-05-25 10:00 UTC (permalink / raw)
To: eCos Discussion
Hello,
I use the freeBSD networking stack, but the default stack size for the
tftp server is wrong:
cdl_option CYGPKG_NET_TFTPD_THREAD_STACK_SIZE {
display "Stack size for TFTP threads."
flavor data
default_value (CYGNUM_HAL_STACK_SIZE_TYPICAL+(3*(SEGSIZE+4)))
When I use the configtool, or idem with ecosconfig with scripts,
CYGNUM_HAL_STACK_SIZE_TYPICAL is always 0!
You can easily try it by taking e.g. the target integrator_arm7 with the
net package. You will see that CYGPKG_NET_TFTPD_THREAD_STACK_SIZE is 12!!
Or do I do something wrong?
Solution is to set CYGPKG_NET_TFTPD_THREAD_STACK_SIZE manually, 4096 is OK.
Regards,
--
Jürgen Lambrecht
Diksmuidse Heerweg 338
8200 Sint-Andries
Tel: +32 (0)50 842901
GSM: +32 (0)476 313389
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ECOS] tftp server stack problems
2006-05-25 10:00 [ECOS] tftp server stack problems Jürgen Lambrecht
@ 2006-05-25 10:36 ` Andrew Lunn
2006-06-07 9:14 ` Jürgen Lambrecht
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Lunn @ 2006-05-25 10:36 UTC (permalink / raw)
To: J?rgen Lambrecht; +Cc: eCos Discussion
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On Thu, May 25, 2006 at 11:58:22AM +0200, J?rgen Lambrecht wrote:
> Hello,
>
> I use the freeBSD networking stack, but the default stack size for the
> tftp server is wrong:
>
> cdl_option CYGPKG_NET_TFTPD_THREAD_STACK_SIZE {
> display "Stack size for TFTP threads."
> flavor data
> default_value (CYGNUM_HAL_STACK_SIZE_TYPICAL+(3*(SEGSIZE+4)))
>
> When I use the configtool, or idem with ecosconfig with scripts,
> CYGNUM_HAL_STACK_SIZE_TYPICAL is always 0!
It looks like this has been broken since 2004-06-17.
CYGNUM_HAL_STACK_SIZE_TYPICAL is not a CDL variable, it is a #define
in the architecture HAL.
Please could you test this patch.
Thanks
Andrew
[-- Attachment #2: tftpd.diff --]
[-- Type: text/plain, Size: 1553 bytes --]
Index: net/common/current/ChangeLog
===================================================================
RCS file: /cvs/ecos/ecos-opt/net/net/common/current/ChangeLog,v
retrieving revision 1.76
diff -u -r1.76 ChangeLog
--- net/common/current/ChangeLog 26 Mar 2006 11:15:06 -0000 1.76
+++ net/common/current/ChangeLog 25 May 2006 10:35:13 -0000
@@ -1,3 +1,10 @@
+2006-05-25 Andrew Lunn <andrew.lunn@ascom.ch>
+
+ * cdl/net.cdl: Fix calculation of TFTPD stack
+ size. CYGNUM_HAL_STACK_SIZE_TYPICAL is not a CDL variable, it is a
+ #define, so we need to ensure that the compiler evaluates the
+ expression, not the CDL library.
+
2006-03-26 Andrew Lunn <andrew.lunn@ascom.ch>
* tests/nc_test_framework.h:
Index: net/common/current/cdl/net.cdl
===================================================================
RCS file: /cvs/ecos/ecos-opt/net/net/common/current/cdl/net.cdl,v
retrieving revision 1.15
diff -u -r1.15 net.cdl
--- net/common/current/cdl/net.cdl 2 Aug 2004 10:43:39 -0000 1.15
+++ net/common/current/cdl/net.cdl 25 May 2006 10:35:14 -0000
@@ -170,7 +170,7 @@
cdl_option CYGPKG_NET_TFTPD_THREAD_STACK_SIZE {
display "Stack size for TFTP threads."
flavor data
- default_value (CYGNUM_HAL_STACK_SIZE_TYPICAL+(3*(SEGSIZE+4)))
+ default_value { "(CYGNUM_HAL_STACK_SIZE_TYPICAL+(3*(SEGSIZE+4)))" }
description "
This option controls the size of the stack used for the
TFTP server. The default should be sufficient for most cases
[-- Attachment #3: Type: text/plain, Size: 148 bytes --]
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ECOS] tftp server stack problems
2006-05-25 10:36 ` Andrew Lunn
@ 2006-06-07 9:14 ` Jürgen Lambrecht
2006-06-17 20:12 ` Andrew Lunn
0 siblings, 1 reply; 4+ messages in thread
From: Jürgen Lambrecht @ 2006-06-07 9:14 UTC (permalink / raw)
To: Andrew Lunn; +Cc: eCos Discussion
Hello Andrew,
The patch is OK.
In my application, CYGPKG_NET_TFTPD_THREAD_STACK_SIZE is set to 3948.
Thanks,
Juergen
Jürgen Lambrecht
Development Engineer
Televic Transport Systems
http://www.televic.com
Televic NV / SA (main office)
Leo Bekaertlaan 1
B-8870 Izegem
Tel: +32 (0)51 303045
Fax: +32 (0)51 310670
Andrew Lunn wrote:
> On Thu, May 25, 2006 at 11:58:22AM +0200, J?rgen Lambrecht wrote:
>
>>Hello,
>>
>>I use the freeBSD networking stack, but the default stack size for the
>>tftp server is wrong:
>>
>> cdl_option CYGPKG_NET_TFTPD_THREAD_STACK_SIZE {
>> display "Stack size for TFTP threads."
>> flavor data
>> default_value (CYGNUM_HAL_STACK_SIZE_TYPICAL+(3*(SEGSIZE+4)))
>>
>>When I use the configtool, or idem with ecosconfig with scripts,
>>CYGNUM_HAL_STACK_SIZE_TYPICAL is always 0!
>
>
> It looks like this has been broken since 2004-06-17.
> CYGNUM_HAL_STACK_SIZE_TYPICAL is not a CDL variable, it is a #define
> in the architecture HAL.
>
> Please could you test this patch.
>
> Thanks
> Andrew
>
>
> ------------------------------------------------------------------------
>
> Index: net/common/current/ChangeLog
> ===================================================================
> RCS file: /cvs/ecos/ecos-opt/net/net/common/current/ChangeLog,v
> retrieving revision 1.76
> diff -u -r1.76 ChangeLog
> --- net/common/current/ChangeLog 26 Mar 2006 11:15:06 -0000 1.76
> +++ net/common/current/ChangeLog 25 May 2006 10:35:13 -0000
> @@ -1,3 +1,10 @@
> +2006-05-25 Andrew Lunn <andrew.lunn@ascom.ch>
> +
> + * cdl/net.cdl: Fix calculation of TFTPD stack
> + size. CYGNUM_HAL_STACK_SIZE_TYPICAL is not a CDL variable, it is a
> + #define, so we need to ensure that the compiler evaluates the
> + expression, not the CDL library.
> +
> 2006-03-26 Andrew Lunn <andrew.lunn@ascom.ch>
>
> * tests/nc_test_framework.h:
> Index: net/common/current/cdl/net.cdl
> ===================================================================
> RCS file: /cvs/ecos/ecos-opt/net/net/common/current/cdl/net.cdl,v
> retrieving revision 1.15
> diff -u -r1.15 net.cdl
> --- net/common/current/cdl/net.cdl 2 Aug 2004 10:43:39 -0000 1.15
> +++ net/common/current/cdl/net.cdl 25 May 2006 10:35:14 -0000
> @@ -170,7 +170,7 @@
> cdl_option CYGPKG_NET_TFTPD_THREAD_STACK_SIZE {
> display "Stack size for TFTP threads."
> flavor data
> - default_value (CYGNUM_HAL_STACK_SIZE_TYPICAL+(3*(SEGSIZE+4)))
> + default_value { "(CYGNUM_HAL_STACK_SIZE_TYPICAL+(3*(SEGSIZE+4)))" }
> description "
> This option controls the size of the stack used for the
> TFTP server. The default should be sufficient for most cases
>
>
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ECOS] tftp server stack problems
2006-06-07 9:14 ` Jürgen Lambrecht
@ 2006-06-17 20:12 ` Andrew Lunn
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2006-06-17 20:12 UTC (permalink / raw)
To: J?rgen Lambrecht; +Cc: eCos Discussion
On Wed, Jun 07, 2006 at 11:13:53AM +0200, J?rgen Lambrecht wrote:
> Hello Andrew,
>
> The patch is OK.
> In my application, CYGPKG_NET_TFTPD_THREAD_STACK_SIZE is set to 3948.
> Thanks,
> Juergen
Thanks for testing the patch. I have committed it.
Andrew
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-06-17 20:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-05-25 10:00 [ECOS] tftp server stack problems Jürgen Lambrecht
2006-05-25 10:36 ` Andrew Lunn
2006-06-07 9:14 ` Jürgen Lambrecht
2006-06-17 20:12 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).