[Bug 1001275] Cortex-M (armV7) architecture endian instructions / Applied on lwIP

[bugzilla-daemon@bugs.ecos.sourceware.org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001275

--- Comment #16 from Ilija Kocho <ilijak@siva.com.mk> 2011-08-23 14:27:21 BST ---
(In reply to comment #15)

> I will very appreciate your final patches for lwipopts.h, and config
> files.

Here's what I got today.

Cortex-M CDL: Disabling CYGIMP_HAL_ARCH_ENDIAN also suppresses generation of
cortexm_endian.h so we have somplete global wipe-out.

--- ecos/packages/hal/cortexm/arch/current/cdl/hal_cortexm.cdl    2011-04-06
18:54:16.000000000 +0200
+++ ecos_kin/packages/hal/cortexm/arch/current/cdl/hal_cortexm.cdl   
2011-08-23 14:54:14.000000000 +0200
@@ -138,6 +138,19 @@
              Higher priorities are reserved for the DEBUG and SVC traps."
     }

+    cdl_option CYGIMP_HAL_ARCH_ENDIAN {
+        display "Architecture optimized endian functions"
+        flavor bool
+        default_value 1
+        description "..."
+        
+        define_proc {
+            puts $::cdl_system_header \
+           "#define CYGBLD_HAL_ENDIAN_H <cyg/hal/cortexm_endian.h>"
+        }        
+    }
+    
     cdl_option CYGBLD_LINKER_SCRIPT {
         display "Linker script"
         flavor data

lwIP CDL (lwipopt.h changed accordingly):

--- ecos/packages/net/lwip_tcpip/current/cdl/lwip_net.cdl    2011-03-17
12:40:35.000000000 +0100
+++ ecos_kin/packages/net/lwip_tcpip/current/cdl/lwip_net.cdl    2011-08-23
13:06:35.000000000 +0200
@@ -127,6 +127,17 @@
         compile         ecos/sio.c
     }

+    cdl_option CYGIMP_LWIP_ENDIAN_BY_HAL {
+        display "HAL optimized endian functions"
+        flavor bool
+        active_if CYGIMP_HAL_ARCH_ENDIAN
+        default_value CYGIMP_HAL_ARCH_ENDIAN
+        
+        description "..."
+    }
+    
     cdl_component CYGPKG_LWIP_APIS {
         display         "APIs"
         flavor          none

I tested following cases:
  1. CYGIMP_HAL_ARCH_ENDIAN absent (what we have in other architectures)
  2. CYGIMP_HAL_ARCH_ENDIAN disabled (global disable)
  3. CYGIMP_HAL_ARCH_ENDIAN enabled and CYGIMP_LWIP_ENDIAN_BY_HAL disabled
  4  Both CYGIMP_HAL_ARCH_ENDIAN and CYGIMP_LWIP_ENDIAN_BY_HAL enabled

If you are happy, I would submit.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.