From: bugzilla-daemon@bugs.ecos.sourceware.org
To: ecos-patches@ecos.sourceware.org
Subject: [Bug 1001275] Cortex-M (armV7) architecture endian instructions / Applied on lwIP
Date: Mon, 15 Aug 2011 20:17:00 -0000 [thread overview]
Message-ID: <20110815201739.DFC602F78001@mail.ecoscentric.com> (raw)
In-Reply-To: <bug-1001275-104@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001275
--- Comment #2 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-08-15 21:17:36 BST ---
Hi Ijlija,
Thank you for your attention to low-memory footprint eCos targets and your
ideas around, i.e. how to utilize every bit on such CPUs :-)
My $.02.
Instead hal_arch_instr.h I would create <arch>_regs.h header file to define
a few instructions in assembler. In your case it is cortexm_regs.h.
NOTE: There are the precendents of such definitions in other architecture
trees.
I mean (snippets not tested!)
#ifndef CYGONCE_HAL_CORTEXM_REGS_H
#define CYGONCE_HAL_CORTEXM_REGS_H
//==================================================== ...
//
// cortexm_regs.h
//
// Cortex-M CPU definitions
//
// ...
#include <pkgconf/hal.h>
#include <cyg/hal/var_regs.h>
// Macro to embed rev instructions in C code
#define CYGARC_REV(_origin_, _swapped_) \
asm volatile( "rev %0, %1\n" \
: "=r" (_swapped_) \
: "r" (_origin_) \
);
#define CYGARC_REV16(_origin_, _swapped_) \
asm volatile( "rev16 %0, %1\n" \
: "=r" (_swapped_) \
: "r" (_origin_) \
);
// ---------------------------------------------------- ...
// End of cortexm_regs.h
#endif // ifdef CYGONCE_HAL_CORTEXM_REGS_H
And then I would add only needed inline functions and declarations in some
header file (again, not tested)
#include <cyg/hal/cortexm_regs.h>
#define LWIP_PLATFORM_HTONL( _hostlong_ ) hal_htol( _hostlong_ )
#define LWIP_PLATFORM_HTONS( _hostshort_ ) hal_htos( _hostshort_ )
static inline cyg_uint32 hal_htonl(cyg_uint32 hostslong)
{
cyg_uint32 netlong;
CYGARC_REV(hostlong, netlong);
return netlong;
}
static inline cyg_uint16 hal_htons(cyg_uint16 hostshort)
{
cyg_uint16 netshort;
CYGARC_REV16(hostshort, netshort);
return netshort;
}
But, I would resist to put them in hal_arch.h ... And it is mine only. By
other hand lwipopts.h includes that header only. I thought it's pitty that we
have hal_io.h, but not hal_net.h. Thus, we need more expert views on code's
arrangement.
Sergei
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
next prev parent reply other threads:[~2011-08-15 20:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-03 17:46 [Bug 1001275] New: Cortex-M (armV7) architecture endian instructions / lwIP bugzilla-daemon
2011-07-03 17:52 ` [Bug 1001275] " bugzilla-daemon
2011-07-03 17:56 ` [Bug 1001275] Cortex-M (armV7) architecture endian instructions / Applied on lwIP bugzilla-daemon
2011-08-15 20:17 ` bugzilla-daemon [this message]
2011-08-17 20:26 ` bugzilla-daemon
2011-08-18 21:14 ` bugzilla-daemon
2011-08-19 8:41 ` bugzilla-daemon
2011-08-19 15:09 ` bugzilla-daemon
2011-08-19 15:18 ` bugzilla-daemon
2011-08-21 13:46 ` bugzilla-daemon
2011-08-22 12:10 ` bugzilla-daemon
2011-08-22 13:01 ` bugzilla-daemon
2011-08-22 13:23 ` bugzilla-daemon
2011-08-22 13:36 ` bugzilla-daemon
2011-08-22 14:24 ` bugzilla-daemon
2011-08-22 16:45 ` bugzilla-daemon
2011-08-22 18:26 ` bugzilla-daemon
2011-08-23 13:27 ` bugzilla-daemon
2011-08-23 13:32 ` bugzilla-daemon
2011-08-23 14:18 ` bugzilla-daemon
2011-08-23 16:14 ` bugzilla-daemon
2011-08-23 16:17 ` bugzilla-daemon
2011-08-23 16:19 ` bugzilla-daemon
2011-08-23 16:21 ` bugzilla-daemon
2011-08-23 19:27 ` bugzilla-daemon
2011-08-23 20:15 ` bugzilla-daemon
2011-08-23 20:47 ` bugzilla-daemon
2011-08-24 6:51 ` bugzilla-daemon
2011-08-24 7:08 ` bugzilla-daemon
2011-08-24 13:34 ` bugzilla-daemon
2011-08-24 13:47 ` bugzilla-daemon
2011-08-24 16:43 ` bugzilla-daemon
2011-08-24 17:01 ` bugzilla-daemon
2011-08-24 17:56 ` bugzilla-daemon
2011-08-25 8:02 ` bugzilla-daemon
2011-08-25 8:20 ` bugzilla-daemon
2011-08-25 14:04 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110815201739.DFC602F78001@mail.ecoscentric.com \
--to=bugzilla-daemon@bugs.ecos.sourceware.org \
--cc=ecos-patches@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).