[Bug 1001070] New: BSP for Olimex LPC-L2294-8M

[Bug 1001070] New: BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

           Summary: BSP for Olimex LPC-L2294-8M
           Product: eCos
           Version: CVS
          Platform: Other (please specify)
        OS/Version: ARM
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: Patches and contributions
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: jf.argentino@osean.fr
                CC: ecos-patches@ecos.sourceware.org
             Class: Advice Request


Created an attachment (id=1010)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1010)
patch for OLIMEX LPC-L2294-8M

Attached a patch proposal to add the OLIMEX LPC-L2294-8M support to the HAL.
Today, HAL only support the OLIMEX LPC-L2294-1M.
(I've made the Copyright assignement request to the FSF)

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sergei.gavrikov@gmail.com

--- Comment #1 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2010-11-09 09:53:26 GMT ---
Hi Jean-Francois,

I plan to work on your patch as I have similar hardware. I have only one
comment on the patch. My concern is about using new CDL option:

CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_RAMSIZE

This CDL option (=name) is used 1) to fix the memory layout files, 2) to set
new bus timings both for RAM and NVRAM components, and 3) to select proper
FLASH parts for the hardware variant. As I said I would prefer to see in HAL
just one eCos CDL component which wraps one or more CDL options, something like
this (draft, not tested)

cdl_componet CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_VARIANT {
    display        "OLPCL2294 variant used"
    flavor         data
    default_value  { "OLPCL2294_1M" }
    legal_values   { "OLPCL2294_1M" "OLPCL2294_8M" }
    define -file system.h CYGHWR_BOARD
    description    "
        Blah, blah, blah."

    cdl_option CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_RAMSIZE {
        display       "External RAM size"
        flavor        data
        calculated    {
           is_substr(CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_VARIANT, "1M") ?
                 0x100000 : 0x800000
                      }
        description   "
            Blah, blah, blah."
    } 

    # More CDL options?
}

So, your code would use CYGHWR_BOARD_OLPCL2294_xM checks anywhere and CDL
option CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_RAMSIZE can be used in MLT only.

If you want you would add more CDL options in this component to implement your
TODOs (like overwriting  those config values for LPC BANKx registers in HAL
startup code, but, IMO, it is excessively).

Also, it will be nice to manage HAL_PLATFORM_EXTRA definition, to set its value
in either "1M" or "8M", that would show a proper hint in RedBoot (however, it
is beyond the scope your patch).

If you are familiar with CDL, can you, please, fix the patch (at least to wrap
RAMSIZE option in CDL component)? Otherwise, I would help to make some changes.


Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #2 from JF Argentino <jf.argentino@osean.fr> 2010-11-09 11:33:56 GMT ---
Created an attachment (id=1011)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1011)
patch for OLIMEX LPC-L2294-8M

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #3 from JF Argentino <jf.argentino@osean.fr> 2010-11-09 11:43:42 GMT ---
I've followed your suggestion, and it looks like nothing broken. I think adding
another option(s) for the FLASH part is overkilling, what is your opinion?
This is the 1st time I'm playing with eCos and CDL, I wrote this with the
copy-and-paste method, so any other remarks from experienced eCos user are
welcome.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #4 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2010-11-09 12:31:22 GMT ---
(In reply to comment #3)
> I've followed your suggestion, and it looks like nothing broken. I think adding
> another option(s) for the FLASH part is overkilling, what is your opinion?
> This is the 1st time I'm playing with eCos and CDL, I wrote this with the
> copy-and-paste method, so any other remarks from experienced eCos user are
> welcome.

As you could notice I added in that CDL component example a line:

    define -file system.h CYGHWR_BOARD.

NOTE: for real world it would be better to name it as CYGHWR_OLIMEX_BOARD
instead.

That will define in system.h header either CYGHWR_BOARD_OLPCL2294_1M constant
or CYGHWR_BOARD_OLPCL2294_8M according your choice. So, your code in
hal_platform_setup.h (and in FLASH device driver as well) can look like:

#if defined(CYGHWR_BOARD_OLPCL2294_1M)
    // code for 1M variant
#elif defined(CYGHWR_BOARD_OLPCL2294_8M)
    // code for 8M variant
#else
# error Not supported board.
#end

what is more clear than your checks:

#if CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_RAMSIZE == 0x00100000
...

Agreed? So, try to use those constants to differ the parts of code.

Check it: if you build eCos with defaults, then your <pkgconf/system.h> will
have:

#define CYGHWR_BOARD OLPCL2294_1M
#define CYGHWR_BOARD_OLPCL2294_1M

if you import below and rebuild eCos

cdl_component CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_VARIANT {
    user_value OLPCL2294_8M
};

then your <pkgconf/system.h> header will have yours

#define CYGHWR_BOARD OLPCL2294_8M
#define CYGHWR_BOARD_OLPCL2294_8M

So, you can use checks like in example the above in any source which includes
system.h.

Ah, once again, use there: 'define -file system.h CYGHWR_OLIMEX_BOARD' as
'CYGHWR_BOARD' is too generic name.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #5 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2010-11-22 09:02:41 GMT ---
Hi,

Do you plan to work on the patch? If you do, let me know, please. As far as I
can remember you sent your CA to FSF. Is this correct?

Thank you,
Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #6 from JF Argentino <jf.argentino@osean.fr> 2010-11-22 09:43:07 GMT ---
Created an attachment (id=1025)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1025)
patch for OLIMEX LPC-L2294-8M

Last version following Sergei suggestions but NOT TESTED

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #7 from JF Argentino <jf.argentino@osean.fr> 2010-11-22 09:46:42 GMT ---
Hi,

> Do you plan to work on the patch? If you do, let me know, please.
I'm really busy now, I  won't be able to work on the patch until many months.
I'm attaching the last version, following your suggestions BUT IT WASN'T BEEN
TESTED.

> As far as I can remember you sent your CA to FSF. Is this correct?
We've made the demand to the FSF and we're still waiting the CA to come.

JF

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #8 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2010-11-22 11:12:19 GMT ---
The patch looks fine for me (need to expand a few TABs only). I will test the
patch on 1M board and let you know (in opposite, I will ask you re-test final
patch on 8M target).

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
         AssignedTo|unassigned@bugs.ecos.source |sergei.gavrikov@gmail.com
                   |ware.org                    |
     Ever Confirmed|0                           |1

--- Comment #9 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2010-11-22 11:32:55 GMT ---
Mark as NEEDINFO, re-assigned.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #10 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2010-11-25 13:34:21 GMT ---
Created an attachment (id=1029)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1029)
olpcl2294_20101125.patch

Support for Olimex LPC-L2294-8M

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #11 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2010-11-25 13:38:19 GMT ---
Cleaned-up; added support for FLASH Legacy API driver.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #12 from BobN <bneiman@directcon.net> 2010-12-15 04:41:32 GMT ---
Created an attachment (id=1057)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1057)
patch for generic flash with olpcl2294 8 m variant

Problem with compiling generic flash support with olpcl2294_20101125.patch (gcc
3.2.1) .  Compiler complained about conditional within a macro.
This compiled and built with generic flash on top of olpcl2294 8 meg variant.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #13 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2010-12-15 06:43:47 GMT ---
Thanks for report. I will investigate.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1010|0                           |1
        is obsolete|                            |
   Attachment #1011|0                           |1
        is obsolete|                            |
   Attachment #1025|0                           |1
        is obsolete|                            |
   Attachment #1029|0                           |1
        is obsolete|                            |
   Attachment #1057|0                           |1
        is obsolete|                            |

--- Comment #14 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2010-12-16 12:28:43 GMT ---
Created an attachment (id=1060)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1060)
olpcl2294_20101216-cvs.patch

I could reproduce the issue using arm-elf-gcc 3.2.1 toolchain. Thanks for
report. Unfortunately, your "workaround" deprives flash support for other
targets from Olimex (non-olpcl2294). On my look there should be if/then/else
macro as only LPC-L2294-1M have 28F160 parts. New patch is attached (generated
against CVS).

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #15 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2010-12-16 12:34:07 GMT ---
Created an attachment (id=1061)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1061)
olpcl2294_20101216-3.0.patch

Bob, as I could notice you work with eCos-3.0 sources. This patch is generated
against eCos-3.0 sources. It would be great if you can test the patch as I have
not LPC-L2294-8M target.

Thanks,
Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #16 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-03-14 19:45:59 GMT ---
2010-11-09 11:53:26 +0200 Jean-Francois wrote:
> (I've made the Copyright assignement request to the FSF)

Hi,

Jean-Francois, have you got FSF assignment? If you've got it, let me
know, please.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #17 from Jonathan Larmour <jifl@ecoscentric.com> 2011-11-08 01:15:28 GMT ---
Sergei, Jean-Francois,

The copyright assignment for Osean has come through from the FSF today, so it's
all clear to check-in on the legal front.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1061|                            |assignment+
               Flag|                            |

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1060|                            |assignment+
               Flag|                            |

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #18 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-11-08 10:41:26 GMT ---
(In reply to comment #17)
> Sergei, Jean-Francois,
> 
> The copyright assignment for Osean has come through from the FSF
> today, so it's all clear to check-in on the legal front.
> 
> Jifl

Jifl, thank you for this updating. I'll re-test build process and then
apply it.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001070] BSP for Olimex LPC-L2294-8M

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070

--- Comment #19 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-11-08 17:08:14 GMT ---
Both builds (1M/8M) were tested. Now in CVS. I'm sorry that it took a 
time.

Jean-Francois,

Thank you for your contribution to eCos. 

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.