[Bug 1001388] Convenience macros for manipulating GPIO pins

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ecos-patches@ecos.sourcewar
                   |                            |e.org
          Component|HAL                         |Patches and contributions
         AssignedTo|ilijak@siva.com.mk          |unassigned@bugs.ecos.source
                   |                            |ware.org

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1432|                            |assignment?
               Flag|                            |

--- Comment #1 from Ilija Kocho <ilijak@siva.com.mk> 2011-11-16 22:21:11 GMT ---
(From update of attachment 1432)
Hello Tomas

Thank you for your contribution. I find your macros convenient indeed and
useful addition to Kinetis support.

But before we can commit the code to the eCos repository we shall need your
copyright assignment. You can find information regarding copyright assignment,
the reasons and procedure, at http://ecos.sourceware.org/assign.html .

Copyright assignment process is a time consuming process, but in parallel we
can proceed with code review and prepare the code for immediate inclusion when
copyright assignment is ready. Please inform me when you send copyright
assignment so I would start the review.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

--- Comment #2 from Tomas Frydrych <tf+bugs.ecos@r-finger.com> 2011-11-17 18:33:15 GMT ---
OK, I have started the copyright assignment process.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

--- Comment #3 from Ilija Kocho <ilijak@siva.com.mk> 2011-11-26 10:57:18 GMT ---
Tomas

There's not much gain by abbreviation /*_PT?_P/ vs /*_PORT?_P/.
IMO, in general and when possible, it would be convenient if names resemble the
ones used in Kinetis RM: such as CLEAR (vs UNSET).

FYI, you can find some convenient general macros for bit manipulation and
masking in arch/current/include/hal/io /BIT_(), MASK_(), VALUE_()/

Having these macros, the set would be (more) complete with addition of macros
for configuring of port bits /pddr/.

For future (to do) we may consider complementary inline functions with pointer
to a port as first argument.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

--- Comment #4 from Tomas Frydrych <tf+bugs.ecos@r-finger.com> 2011-11-29 13:51:46 GMT ---
(In reply to comment #3)
Thanks Ilija,

> There's not much gain by abbreviation /*_PT?_P/ vs /*_PORT?_P/

I used the PT? because much of the kinetis rm refers to the registers as PTA,
etc., but PORTA will be clear enough I think.

> Having these macros, the set would be (more) complete with addition of macros
> for configuring of port bits /pddr/.

Ok, I shall add that.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

Tomas Frydrych <tf+bugs.ecos@r-finger.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1432|assignment?                 |
               Flag|                            |
   Attachment #1432|0                           |1
        is obsolete|                            |

--- Comment #5 from Tomas Frydrych <tf+bugs.ecos@r-finger.com> 2011-11-29 16:37:45 GMT ---
Created an attachment (id=1440)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1440)
patch, take 2

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

--- Comment #6 from Ilija Kocho <ilijak@siva.com.mk> 2011-12-01 15:50:34 GMT ---
(In reply to comment #5)
> Created an attachment (id=1440)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1440) [details]
> patch, take 2

Thank you for update. I think now it fits.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1001397

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1440|                            |assignment+
               Flag|                            |

--- Comment #7 from Jonathan Larmour <jifl@ecoscentric.com> 2011-12-10 23:54:42 GMT ---
(From update of attachment 1440)
The copyright assignment is complete.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

--- Comment #8 from Ilija Kocho <ilijak@siva.com.mk> 2011-12-20 16:33:56 GMT ---
Hi Tomas

I have tested the macros, and they seem to work as they should.

However, I have one little remark:CYGHWR_HAL_KINETIS_GPIO_SET_CLEAR() sounds
little-bit ambiguous. I wander if we could use something like
CYGHWR_HAL_KINETIS_GPIO_PUT() (like puts() or putchar()) or
CYGHWR_HAL_KINETIS_GPIO_OUT() or could you propose something else? (You don't
have to submit new patch, i can apply changes on my working copy).

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

--- Comment #9 from Tomas Frydrych <tf+bugs.ecos@r-finger.com> 2011-12-20 16:42:36 GMT ---
(In reply to comment #8)
> However, I have one little remark:CYGHWR_HAL_KINETIS_GPIO_SET_CLEAR() sounds
> little-bit ambiguous. I wander if we could use something like

CYGHWR_HAL_KINETIS_GPIO_PUT() sounds good to me.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1440|0                           |1
        is obsolete|                            |

--- Comment #10 from Ilija Kocho <ilijak@siva.com.mk> 2011-12-21 08:10:25 GMT ---
Created an attachment (id=1474)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1474)
Kinetis GPIO macros 111220

(In reply to comment #9)
> (In reply to comment #8)
> > However, I have one little remark:CYGHWR_HAL_KINETIS_GPIO_SET_CLEAR() sounds
> > little-bit ambiguous. I wander if we could use something like
> 
> CYGHWR_HAL_KINETIS_GPIO_PUT() sounds good to me.

Thank you Tomas, changes applied.

Here I submit the updated patch for final review. I plan to commit it in 2 days
if there are no additional remarks.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

--- Comment #11 from Ilija Kocho <ilijak@siva.com.mk> 2011-12-25 13:55:05 GMT ---
Now checked in.
Thank you for the contribution Tomas.
Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |CURRENTRELEASE

--- Comment #12 from Ilija Kocho <ilijak@siva.com.mk> 2012-01-01 21:12:30 GMT ---
Checked in.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001388] Convenience macros for manipulating GPIO pins

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001388

Tomas Frydrych <tf+bugs.ecos@r-finger.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|1001397                     |

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.