From: Mark Wielaard <mark@klomp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.
Date: Mon, 17 Jul 2017 16:41:00 -0000 [thread overview]
Message-ID: <1500309707.14595.379.camel@klomp.org> (raw)
In-Reply-To: <20170717162948.GA8679@altlinux.org>
On Mon, 2017-07-17 at 19:29 +0300, Dmitry V. Levin wrote:
> On Mon, Jul 17, 2017 at 05:44:54PM +0200, Mark Wielaard wrote:
> > glibc 2.26 changed the sys/ptrace.h header so that it cannot be included
> > after asm/ptrace.h. We still need to include the kernel asm/ptrace.h for
> > the ptrace_area definition. Including it after sys/ptrace.h works against
> > both old and new glibc.
>
> If it's a glibc regression, shouldn't it be fixed on glibc side before
> 2.26 is out?
I asked and it was done deliberately. See glibc 2.26 NEWS under
Deprecated and removed features, and other changes affecting
compatibility.
For the functionality we needed it was always necessary to include the
kernel asm/ptrace.h also (and it still is with 2.26) on s390. The only
regression (for us) is that the order of the includes needs to be
sys/ptrace.h first, then asm/ptrace.h. I double checked that the
functionality needed still works (the run-backtrace-native.sh testcase
works on both old s390 and s390x and new glibc s390x versions).
Cheers,
Mark
next prev parent reply other threads:[~2017-07-17 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 15:45 Mark Wielaard
2017-07-17 16:29 ` Dmitry V. Levin
2017-07-17 16:41 ` Mark Wielaard [this message]
2017-07-17 22:24 ` Dmitry V. Levin
2017-07-17 22:52 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500309707.14595.379.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=ldv@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).