From: Mark Wielaard <mark@klomp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.
Date: Mon, 17 Jul 2017 22:52:00 -0000 [thread overview]
Message-ID: <20170717225251.GC2236@stream> (raw)
In-Reply-To: <20170717222446.GA12913@altlinux.org>
On Tue, Jul 18, 2017 at 01:24:46AM +0300, Dmitry V. Levin wrote:
> I reviewed and approved both of these commits assuming that they brought
> no regressions. If sys/ptrace.h from glibc 2.25 could be included before
> or after linux/ptrace.h, this shouldn't have changed in glibc 2.26.
>
> In other words, I think you've spotted a regression that I missed during
> b08a6a0dea63742313ed3d9577c1e2d83436b196 review and that has to be fixed
> in glibc before 2.26 is released.
Aha. So if you look at that patch you see that the same include pattern
that got us in trouble was removed from sysdeps/s390/fpu/fesetenv.c and
the new order is used in the newly added testcase
sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c.
On fedora s390x rawhide (which has a glibc 2.16 pre-release)
including asm/ptrace.h before sys/ptrace.h will cause errors:
https://kojipkgs.fedoraproject.org//work/tasks/4924/20574924/build.log
Cheers,
Mark
prev parent reply other threads:[~2017-07-17 22:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 15:45 Mark Wielaard
2017-07-17 16:29 ` Dmitry V. Levin
2017-07-17 16:41 ` Mark Wielaard
2017-07-17 22:24 ` Dmitry V. Levin
2017-07-17 22:52 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717225251.GC2236@stream \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=ldv@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).