From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.
Date: Mon, 17 Jul 2017 22:24:00 -0000 [thread overview]
Message-ID: <20170717222446.GA12913@altlinux.org> (raw)
In-Reply-To: <1500309707.14595.379.camel@klomp.org>
[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]
On Mon, Jul 17, 2017 at 06:41:47PM +0200, Mark Wielaard wrote:
> On Mon, 2017-07-17 at 19:29 +0300, Dmitry V. Levin wrote:
> > On Mon, Jul 17, 2017 at 05:44:54PM +0200, Mark Wielaard wrote:
> > > glibc 2.26 changed the sys/ptrace.h header so that it cannot be included
> > > after asm/ptrace.h. We still need to include the kernel asm/ptrace.h for
> > > the ptrace_area definition. Including it after sys/ptrace.h works against
> > > both old and new glibc.
> >
> > If it's a glibc regression, shouldn't it be fixed on glibc side before
> > 2.26 is out?
>
> I asked and it was done deliberately. See glibc 2.26 NEWS under
> Deprecated and removed features, and other changes affecting
> compatibility.
There are exactly two commits in glibc since 2.25 that changed
sysdeps/unix/sysv/linux/s390/sys/ptrace.h:
3f67d1a7021ed3184830511636a0867faec730fe and
b08a6a0dea63742313ed3d9577c1e2d83436b196.
I reviewed and approved both of these commits assuming that they brought
no regressions. If sys/ptrace.h from glibc 2.25 could be included before
or after linux/ptrace.h, this shouldn't have changed in glibc 2.26.
In other words, I think you've spotted a regression that I missed during
b08a6a0dea63742313ed3d9577c1e2d83436b196 review and that has to be fixed
in glibc before 2.26 is released.
--
ldv
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-07-17 22:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 15:45 Mark Wielaard
2017-07-17 16:29 ` Dmitry V. Levin
2017-07-17 16:41 ` Mark Wielaard
2017-07-17 22:24 ` Dmitry V. Levin [this message]
2017-07-17 22:52 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717222446.GA12913@altlinux.org \
--to=ldv@altlinux.org \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).