* [PATCH] debuginfod, elfclassify: remove unnecessary header inclusion
@ 2021-08-20 18:21 Saleem Abdulrasool
2021-08-27 15:19 ` Mark Wielaard
0 siblings, 1 reply; 2+ messages in thread
From: Saleem Abdulrasool @ 2021-08-20 18:21 UTC (permalink / raw)
To: elfutils-devel
`error.h`'s inclusion was centralised into the `system.h` header. As
the implementation currently includes `system.h` already, the inclusion
of `error.h` is unnecessary. This prepares for a future portability
change to allow elfutil to build with alternate libc implementations.
Signed-off-by: Saleem Abdulrasool <abdulras@google.com>
---
debuginfod/debuginfod.cxx | 1 -
src/elfclassify.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
index fca07f61..b560fdcb 100644
--- a/debuginfod/debuginfod.cxx
+++ b/debuginfod/debuginfod.cxx
@@ -46,7 +46,6 @@ extern "C" {
#include <unistd.h>
#include <stdlib.h>
-#include <error.h>
#include <libintl.h>
#include <locale.h>
#include <pthread.h>
diff --git a/src/elfclassify.c b/src/elfclassify.c
index fe7eeeed..2f70b29a 100644
--- a/src/elfclassify.c
+++ b/src/elfclassify.c
@@ -19,7 +19,6 @@
#include <system.h>
#include <argp.h>
-#include <error.h>
#include <fcntl.h>
#include <gelf.h>
#include <stdbool.h>
--
2.33.0.rc2.250.ged5fa647cd-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] debuginfod, elfclassify: remove unnecessary header inclusion
2021-08-20 18:21 [PATCH] debuginfod, elfclassify: remove unnecessary header inclusion Saleem Abdulrasool
@ 2021-08-27 15:19 ` Mark Wielaard
0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2021-08-27 15:19 UTC (permalink / raw)
To: Saleem Abdulrasool, elfutils-devel
Hi Saleem,
On Fri, 2021-08-20 at 18:21 +0000, Saleem Abdulrasool via Elfutils-devel wrote:
> `error.h`'s inclusion was centralised into the `system.h` header. As
> the implementation currently includes `system.h` already, the inclusion
> of `error.h` is unnecessary. This prepares for a future portability
> change to allow elfutil to build with alternate libc implementations.
>
> Signed-off-by: Saleem Abdulrasool <abdulras@google.com>
Thanks. Added ChangeLog entries and pushed.
Cheers,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-27 15:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20 18:21 [PATCH] debuginfod, elfclassify: remove unnecessary header inclusion Saleem Abdulrasool
2021-08-27 15:19 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).