public inbox for
 help / color / mirror / Atom feed
From: "dje at sourceware dot org" <>
Subject: [Bug libdw/30077] Duplicate definition of typedef struct debuginfod_client in libdwfl
Date: Sat, 04 Feb 2023 22:04:07 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

--- Comment #3 from David Edelsohn <dje at sourceware dot org> ---
The proposed patch in Comment #1 will work. It seems unfortunate for libdwfl.h
to define a struct that is part of debuginfod instead of using the debuginfod

The struct is needed by libdwfl.h to prototype

extern debuginfod_client *dwfl_get_debuginfod_client (Dwfl *dwfl);

but that function is defined in debuginfod-client.c protected by


It already is protected where it is referenced by an existing macro.  The
problem is the header logic doesn't match the logic in the file that uses that

So, again, it would seem better to include the struct from debuginfod-client.h
directly instead of adding more macros to protect the headers and types that
already are protected.  Something like:

--- libdwfl.h.orig      2023-02-03 15:03:57.669810336 -0500
+++ libdwfl.h   2023-02-04 16:57:05.734206129 -0500
@@ -49,9 +49,6 @@
    PC location described by an FDE belonging to Dwfl_Thread.  */
 typedef struct Dwfl_Frame Dwfl_Frame;

-/* Handle for debuginfod-client connection.  */
-typedef struct debuginfod_client debuginfod_client;
 /* Callbacks.  */
 typedef struct
@@ -808,12 +805,16 @@
 int dwfl_frame_reg (Dwfl_Frame *state, unsigned regno, Dwarf_Word *val)
   __nonnull_attribute__ (1);

+#include "../debuginfod/debuginfod.h"
 /* Return the internal debuginfod-client connection handle for the DWFL
    When the client connection has not yet been initialized, it will be done on
    first call to this function. If elfutils is compiled without support for
    NULL will be returned.
 extern debuginfod_client *dwfl_get_debuginfod_client (Dwfl *dwfl);

 #ifdef __cplusplus

That defines the struct in only one place (debuginfod.h) and includes the
header and prototype with the same macro protecting its use in

You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-02-04 22:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 20:12 [Bug libdw/30077] New: " dje at sourceware dot org
2023-02-04 17:32 ` [Bug libdw/30077] " mark at klomp dot org
2023-02-04 18:25 ` sam at gentoo dot org
2023-02-04 22:04 ` dje at sourceware dot org [this message]
2023-02-05 10:35 ` mark at klomp dot org
2023-02-05 10:46 ` mark at klomp dot org
2023-02-05 21:41 ` dje at sourceware dot org
2023-02-06  9:47 ` mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).