From: "dje at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: elfutils-devel@sourceware.org
Subject: [Bug libdw/30077] New: Duplicate definition of typedef struct debuginfod_client in libdwfl
Date: Fri, 03 Feb 2023 20:12:28 +0000 [thread overview]
Message-ID: <bug-30077-10460@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=30077
Bug ID: 30077
Summary: Duplicate definition of typedef struct
debuginfod_client in libdwfl
Product: elfutils
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: libdw
Assignee: unassigned at sourceware dot org
Reporter: dje at sourceware dot org
CC: elfutils-devel at sourceware dot org
Target Milestone: ---
typedef struct debuginfod_client is defined in both libdwfl/libdwfl.h and in
debuginfod.h included by libdwfl/libdwflP.h. Although innocuous, this is
invalid C and causes compilation failures with strict compliance.
One possible set of patches is:
--- libdwfl.h.orig 2023-02-03 15:03:57.669810336 -0500
+++ libdwfl.h 2023-02-03 15:00:53.959921348 -0500
@@ -49,8 +49,10 @@
PC location described by an FDE belonging to Dwfl_Thread. */
typedef struct Dwfl_Frame Dwfl_Frame;
+#ifndef ENABLE_LIBDEBUGINFOD
/* Handle for debuginfod-client connection. */
typedef struct debuginfod_client debuginfod_client;
+#endif
/* Callbacks. */
typedef struct
--- libdwflP.h.orig 2023-02-03 15:04:29.749793736 -0500
+++ libdwflP.h 2023-02-03 14:53:56.320181520 -0500
@@ -29,6 +29,10 @@
#ifndef _LIBDWFLP_H
#define _LIBDWFLP_H 1
+#ifdef ENABLE_LIBDEBUGINFOD
+#include "../debuginfod/debuginfod.h"
+#endif
+
#include <libdwfl.h>
#include <libebl.h>
#include <assert.h>
@@ -41,10 +45,6 @@
#include "../libdw/libdwP.h" /* We need its INTDECLs. */
#include "../libdwelf/libdwelfP.h"
-#ifdef ENABLE_LIBDEBUGINFOD
-#include "../debuginfod/debuginfod.h"
-#endif
-
typedef struct Dwfl_Process Dwfl_Process;
#define DWFL_ERRORS \
--
You are receiving this mail because:
You are on the CC list for the bug.
next reply other threads:[~2023-02-03 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 20:12 dje at sourceware dot org [this message]
2023-02-04 17:32 ` [Bug libdw/30077] " mark at klomp dot org
2023-02-04 18:25 ` sam at gentoo dot org
2023-02-04 22:04 ` dje at sourceware dot org
2023-02-05 10:35 ` mark at klomp dot org
2023-02-05 10:46 ` mark at klomp dot org
2023-02-05 21:41 ` dje at sourceware dot org
2023-02-06 9:47 ` mark at klomp dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-30077-10460@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).