[Bug libdw/30077] Duplicate definition of typedef struct debuginfod_client in libdwfl

["mark at klomp dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30077

--- Comment #5 from Mark Wielaard <mark at klomp dot org> ---
(In reply to David Edelsohn from comment #3)
> The struct is needed by libdwfl.h to prototype
> 
> extern debuginfod_client *dwfl_get_debuginfod_client (Dwfl *dwfl);
> 
> but that function is defined in debuginfod-client.c protected by
> 
> #ifdef ENABLE_LIBDEBUGINFOD
> 
> It already is protected where it is referenced by an existing macro.  The
> problem is the header logic doesn't match the logic in the file that uses
> that prototype.
> 
> So, again, it would seem better to include the struct from
> debuginfod-client.h directly instead of adding more macros to protect the
> headers and types that already are protected.  Something like:

The public headers are independent and can be used with or without the other
being available. And the function must be defined with or without libdebuginfod
support available or installed.

You cannot use the same guards in the public headers and the implementation
sources because they are independent.

It might be helpful to know in which configuration you are having this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.