[Bug libdw/30077] Duplicate definition of typedef struct debuginfod_client in libdwfl

["mark at klomp dot org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30077

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Mark Wielaard <mark at klomp dot org> ---
(In reply to David Edelsohn from comment #6)
> The error is reported if one configures and builds with Clang.

Aha. I am not sure things will build with clang. It seems to have a couple more
quirks like not supporting some uses of flexible arrays.

Note that this really is a pendantic warning and shouldn't be enabled by
default imho. You can simply silence it with -Wno-typedef-redefinition

> Also, yes, this is a C11 feature, but libdwfl/Makefile.in explicitly invokes
> the compiler with -std=gnu99 (AM_CFLAGS).

Maybe it is time to switch to gnu11 these days. But since this is in public
headers and we don't control the compiler/standard users use lets simply make
sure there is only one typedef:

commit 45576ab5f24cd39669a418fa8e005b4d04f8e9ca (HEAD -> master)
Author: Mark Wielaard <mark@klomp.org>
Date:   Mon Feb 6 10:21:58 2023 +0100

    debuginfod: Make sure there is only one typedef for debuginfod_client

    Both debuginfod.h and libdwfl.h have a simple typedef for struct
    debuginfod_client. Some compilers pedantically warn when including
    both headers that such typedefs are only officially supported in
    C11. So guard them with _ELFUTILS_DEBUGINFOD_CLIENT_TYPEDEF to
    make them happy.

    https://sourceware.org/bugzilla/show_bug.cgi?id=30077

    Signed-off-by: Mark Wielaard <mark@klomp.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.