From: Harald Anlauf <anlauf@gmx.de>
To: Andre Vehreschild <vehre@gmx.de>,
GCC-Patches-ML <gcc-patches@gcc.gnu.org>,
GCC-Fortran-ML <fortran@gcc.gnu.org>
Subject: Re: [PR103970, Fortran, Coarray] Multi-image co_broadcast of derived type with allocatable components fails^
Date: Tue, 25 Jan 2022 22:30:22 +0100 [thread overview]
Message-ID: <3a178fe2-7e38-f4f5-9efd-b861f9740abd@gmx.de> (raw)
In-Reply-To: <20220125173213.1265f8e3@vepi2>
Hi Andre',
Am 25.01.22 um 17:32 schrieb Andre Vehreschild via Fortran:
> Hi all,
>
> attached patch fixes wrong code generation when broadcasting a derived type
> containing allocatable and non-allocatable scalars. Furthermore does it prevent
> broadcasting of coarray-tokens, which are always local this_image. Thus having
> them on a different image makes no sense.
>
> Bootstrapped and regtested ok on x86_64-linux/F35.
>
> Ok, for trunk and backport to 12 and 11-branch after decent time?
>
> I perceived that 12 is closed for this kind of bugfix, therefore asking ok for
> 13.
I do not think that 12 is closed for bugfixing, especially not for
fortran. And if my cursory reading of the patch is not misleading,
the impact of the patch is really limited to coarrays.
You may want to wait for another 1-2 days for additional comments.
If not, it is OK from my side.
Thanks for the patch!
Harald
> Regards,
> Andre
> --
> Andre Vehreschild * Email: vehre ad gmx dot de
WARNING: multiple messages have this Message-ID
From: Harald Anlauf <anlauf@gmx.de>
To: fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PR103970, Fortran, Coarray] Multi-image co_broadcast of derived type with allocatable components fails^
Date: Tue, 25 Jan 2022 22:30:22 +0100 [thread overview]
Message-ID: <3a178fe2-7e38-f4f5-9efd-b861f9740abd@gmx.de> (raw)
Message-ID: <20220125213022.kZMWTwPAsmZJ3hHC7giDS8Wa3EAOxsrdc6VrXyUjmiU@z> (raw)
In-Reply-To: <20220125173213.1265f8e3@vepi2>
Hi Andre',
Am 25.01.22 um 17:32 schrieb Andre Vehreschild via Fortran:
> Hi all,
>
> attached patch fixes wrong code generation when broadcasting a derived type
> containing allocatable and non-allocatable scalars. Furthermore does it prevent
> broadcasting of coarray-tokens, which are always local this_image. Thus having
> them on a different image makes no sense.
>
> Bootstrapped and regtested ok on x86_64-linux/F35.
>
> Ok, for trunk and backport to 12 and 11-branch after decent time?
>
> I perceived that 12 is closed for this kind of bugfix, therefore asking ok for
> 13.
I do not think that 12 is closed for bugfixing, especially not for
fortran. And if my cursory reading of the patch is not misleading,
the impact of the patch is really limited to coarrays.
You may want to wait for another 1-2 days for additional comments.
If not, it is OK from my side.
Thanks for the patch!
Harald
> Regards,
> Andre
> --
> Andre Vehreschild * Email: vehre ad gmx dot de
next prev parent reply other threads:[~2022-01-25 21:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 16:32 Andre Vehreschild
2022-01-25 21:30 ` Harald Anlauf [this message]
2022-01-25 21:30 ` Harald Anlauf
2022-01-28 9:07 ` [Submitted, PR103970, " Andre Vehreschild
2022-01-28 9:27 ` Tobias Burnus
2022-01-28 9:36 ` Andre Vehreschild
2022-01-28 11:39 ` Andre Vehreschild
2022-02-14 15:20 ` [Backport, committed, " Andre Vehreschild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a178fe2-7e38-f4f5-9efd-b861f9740abd@gmx.de \
--to=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=vehre@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).