[Bug general/4315] New: Elf constructor causes double free.

[Bug general/4315] New: Elf constructor causes double free.

[npremji at redhat dot com]

The frysk-imports/lib/elf/Elf.java constructor:

Elf (long pointer)
{
this.pointer = pointer;
this.fd = -1;
}

causes a double free as it tries to call elf_end on the pointer, when whatever
called it might have already cleaned up as well.

Example:
DwflModule.getElf().

-- 
           Summary: Elf constructor causes double free.
           Product: frysk
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: frysk-bugzilla at sourceware dot org
        ReportedBy: npremji at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=4315

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/4315] Elf constructor causes double free.

[pmuldoon at redhat dot com]

------- Additional Comments From pmuldoon at redhat dot com  2007-04-04 00:11 -------
I really do not like that constructor at all. Passing in a random pointer, of
unknown state, to a native objects whos state is also unknown. There is no
contract on the management of that pointer either. The ineivtables results is
things like mentioned: double frees.

The first question that crosses my mind is what drives the need for this
constructor in the first place?

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=4315

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/4315] Elf constructor causes double free.

[pmuldoon at redhat dot com]

------- Additional Comments From pmuldoon at redhat dot com  2007-04-04 04:31 -------
Created an attachment (id=1667)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=1667&action=view)
Elf constructor patch

If we need to keep this constructor, maybe something like in the attached patch
where we gate access around native cleanup calls around whether a native object
was created in the first place?

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=4315

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.