public inbox for frysk-bugzilla@sourceware.org help / color / mirror / Atom feed
* [Bug general/4315] New: Elf constructor causes double free. @ 2007-04-03 22:27 npremji at redhat dot com 2007-04-03 23:11 ` [Bug general/4315] " pmuldoon at redhat dot com 2007-04-04 3:31 ` pmuldoon at redhat dot com 0 siblings, 2 replies; 3+ messages in thread From: npremji at redhat dot com @ 2007-04-03 22:27 UTC (permalink / raw) To: frysk-bugzilla The frysk-imports/lib/elf/Elf.java constructor: Elf (long pointer) { this.pointer = pointer; this.fd = -1; } causes a double free as it tries to call elf_end on the pointer, when whatever called it might have already cleaned up as well. Example: DwflModule.getElf(). -- Summary: Elf constructor causes double free. Product: frysk Version: unspecified Status: NEW Severity: normal Priority: P2 Component: general AssignedTo: frysk-bugzilla at sourceware dot org ReportedBy: npremji at redhat dot com http://sourceware.org/bugzilla/show_bug.cgi?id=4315 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug general/4315] Elf constructor causes double free. 2007-04-03 22:27 [Bug general/4315] New: Elf constructor causes double free npremji at redhat dot com @ 2007-04-03 23:11 ` pmuldoon at redhat dot com 2007-04-04 3:31 ` pmuldoon at redhat dot com 1 sibling, 0 replies; 3+ messages in thread From: pmuldoon at redhat dot com @ 2007-04-03 23:11 UTC (permalink / raw) To: frysk-bugzilla ------- Additional Comments From pmuldoon at redhat dot com 2007-04-04 00:11 ------- I really do not like that constructor at all. Passing in a random pointer, of unknown state, to a native objects whos state is also unknown. There is no contract on the management of that pointer either. The ineivtables results is things like mentioned: double frees. The first question that crosses my mind is what drives the need for this constructor in the first place? -- http://sourceware.org/bugzilla/show_bug.cgi?id=4315 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug general/4315] Elf constructor causes double free. 2007-04-03 22:27 [Bug general/4315] New: Elf constructor causes double free npremji at redhat dot com 2007-04-03 23:11 ` [Bug general/4315] " pmuldoon at redhat dot com @ 2007-04-04 3:31 ` pmuldoon at redhat dot com 1 sibling, 0 replies; 3+ messages in thread From: pmuldoon at redhat dot com @ 2007-04-04 3:31 UTC (permalink / raw) To: frysk-bugzilla ------- Additional Comments From pmuldoon at redhat dot com 2007-04-04 04:31 ------- Created an attachment (id=1667) --> (http://sourceware.org/bugzilla/attachment.cgi?id=1667&action=view) Elf constructor patch If we need to keep this constructor, maybe something like in the attached patch where we gate access around native cleanup calls around whether a native object was created in the first place? -- http://sourceware.org/bugzilla/show_bug.cgi?id=4315 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-04-04 3:31 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2007-04-03 22:27 [Bug general/4315] New: Elf constructor causes double free npremji at redhat dot com 2007-04-03 23:11 ` [Bug general/4315] " pmuldoon at redhat dot com 2007-04-04 3:31 ` pmuldoon at redhat dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).