From: Phil Muldoon <pmuldoon@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: frysk@sourceware.org
Subject: Re: Make CoredumpAction use Task.getRegisterBanks()
Date: Mon, 30 Jul 2007 17:44:00 -0000 [thread overview]
Message-ID: <46AE238B.5020204@redhat.com> (raw)
In-Reply-To: <1185814384.3674.36.camel@dijkstra.wildebeest.org>
Mark Wielaard wrote:
> Hi,
>
> Phil and me were discussing cleaning up some of the
> Memory/RegisterBuffers between ptrace and core proc Tasks on irc and
> noticed that CoredumpAction was accessing the RegisterBanks directly
> through the Isa. To make splitting the issue of getting the
> RegisterBanks (Task specific) and doing the Register name mapping to
> bank number and offset (Isa specific) easier we wanted to make all code
> go through Task.getRegisterBanks(). This patch does that for
> CoredumpAction:
>
Looks good. The only function here is to attain the raw memory behind
the byte buffers for floating point registers, as that is dumped whole
into the FP Register Note.
CoredumpAction has been gutted locally and being refactored into a
Corefile{arch}factory. I'll take your patch and reconstitute it there
Many Thanks
Phil
next prev parent reply other threads:[~2007-07-30 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 16:53 Mark Wielaard
2007-07-30 17:44 ` Phil Muldoon [this message]
2007-07-31 12:03 ` Mark Wielaard
2007-08-01 0:27 ` Phil Muldoon
2007-08-02 8:28 ` Mark Wielaard
2007-08-03 14:18 ` Phil Muldoon
2007-08-06 10:03 ` Mark Wielaard
2007-08-22 21:33 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AE238B.5020204@redhat.com \
--to=pmuldoon@redhat.com \
--cc=frysk@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).