Re: Make CoredumpAction use Task.getRegisterBanks()

[Phil Muldoon <pmuldoon@redhat.com>]

Mark Wielaard wrote:
>> I think, going forward access to the raw memory  for each register bank, 
>> and also a getRegisterByName() function (which is the functionality we 
>> have now) is needed, and probably will be down the line.
>>     
>
> If we can match up the raw memory for each register bank between
> ptrace/proc and core files from Task that would be ideal. Then the Isa
> can just do the getRegisterByName() mapping. I'll watch your rewrite of
> the core file stuff and see if this makes things easier and clearer (I
> guess it will).
>
>   
Now that all the register stuff is in, lets open this up again. In a 
corefile there are 3 sets of registers written for x86:

General Purpose (GP) Registers
Floating Point Registers (FP)
eXtended Floating Point (XFP) Registers

The first, GP Registers are written as part of a Elf prStatus note. One 
per thread. Because these registers are part of "another" struct, and do 
not have a note all to themselves, they have to be read one by one, 
sorted, then written into the structure along with other prStatus data 
(tid, and so on).

Both FP and XFP both have their own note types and can be written 
wholesale as a bytebuffer to the corefile. No interpretation needed.

Whether raw register memory access belongs in the ISA, the Task is not 
really important from a corefile view, though I would like to see it 
consistent.

Regards

Phil