public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/101118] coroutines: unexpected ODR warning for coroutine frame type in LTO builds
Date: Fri, 18 Jun 2021 10:46:37 +0000	[thread overview]
Message-ID: <bug-101118-4-Es3GMhJQSg@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101118-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101118

--- Comment #2 from Iain Sandoe <iains at gcc dot gnu.org> ---
hmm. 

__D.9984.3.4 means that this is a frame variable that is a 'promoted' temporary
(promoted because its lifetime had to be extended across a suspend point by
copying it into the frame).

So, I am supposing that this issue is because such a temporary would almost
certainly not have the same DECL_UID (from which the __D.xxxx is created) in
different TUs.

Which seems to imply that we need to find a way to disambiguate the frame
variable names for LTO.  This is, I would expect, another case of something
with local visibility becoming globally visible for LTO (but that's
supposition, not analysed).

the coros testsuite runs torture tests thus:
....
PASS: g++.dg/coroutines/torture/alloc-00-gro-on-alloc-fail.C   -O2 -flto
-flto-partition=none  (test for excess errors)
PASS: g++.dg/coroutines/torture/alloc-00-gro-on-alloc-fail.C   -O2 -flto
-flto-partition=none  execution test
PASS: g++.dg/coroutines/torture/alloc-00-gro-on-alloc-fail.C   -O2 -flto  (test
for excess errors)
PASS: g++.dg/coroutines/torture/alloc-00-gro-on-alloc-fail.C   -O2 -flto 
execution test

so there is some coverage of LTO - but not multiple TUs :(.

  parent reply	other threads:[~2021-06-18 10:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18  7:43 [Bug c++/101118] New: " nilsgladitz at gmail dot com
2021-06-18 10:26 ` [Bug c++/101118] " rguenth at gcc dot gnu.org
2021-06-18 10:46 ` iains at gcc dot gnu.org [this message]
2021-06-18 15:18 ` nilsgladitz at gmail dot com
2021-06-18 15:39 ` iains at gcc dot gnu.org
2023-03-03 16:06 ` john at drouhard dot dev
2023-03-03 16:26 ` hubicka at gcc dot gnu.org
2023-03-03 16:33 ` iains at gcc dot gnu.org
2023-03-03 17:06 ` hubicka at ucw dot cz
2023-03-03 17:10 ` iains at gcc dot gnu.org
2023-03-03 19:21 ` iains at gcc dot gnu.org
2023-03-03 19:29 ` iains at gcc dot gnu.org
2023-03-03 20:59 ` iains at gcc dot gnu.org
2023-03-07 12:53 ` hubicka at ucw dot cz
2023-03-07 15:04 ` iains at gcc dot gnu.org
2023-03-07 16:18 ` hubicka at ucw dot cz
2023-03-07 16:27 ` iains at gcc dot gnu.org
2023-04-01  5:28 ` cvs-commit at gcc dot gnu.org
2023-04-30  8:27 ` cvs-commit at gcc dot gnu.org
2023-05-16 19:07 ` cvs-commit at gcc dot gnu.org
2023-05-16 19:11 ` iains at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101118-4-Es3GMhJQSg@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).