public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/101118] coroutines: unexpected ODR warning for coroutine frame type in LTO builds
Date: Fri, 03 Mar 2023 16:33:05 +0000 [thread overview]
Message-ID: <bug-101118-4-WFxgkdmvvK@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101118-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101118
--- Comment #7 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Jan Hubicka from comment #6)
from me there has been no progress on anything co-routines related, for a while
- I of not have any resources to work on it.
> I am not really expert on coroutines. But this seems to be a type (not a
> declaration we globalize during LTO) generated internally by the front-end.
> The name __D.9984.3.4 looks like it has a global counter in it.
> ODR types are supposed to be literaly the same across units.
>
> One way to silence this would be to not make these types ODR types since
> they are not the usual C++ types anyway.
> I wonder if this is a part of the cross-unit API that is supposed to be
> same? I.e. is the coroutine in one compilation unit visible from the other?
>
> If so, perhaps the only problem is hte global counter 9984 and if the counts
> were generated internally for each such type, the ODR handling wlll be happy.
the synthesised functions (actor, destroy) are intended to be TU-local.
the ramp function is what remains of the user's original function after the
coroutine body is outlined - so that has the original signature of the user's
function.
We do use counters to generate local symbol names for frame-promoted
temporaries, so I suppose that there is a possibility that the name(s) that are
intended to be TU-local become visible across TUs in LTO; but those should be
the names of coroutine frame entries (i.e. fields in a structure, not
themselves global symbols).
next prev parent reply other threads:[~2023-03-03 16:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 7:43 [Bug c++/101118] New: " nilsgladitz at gmail dot com
2021-06-18 10:26 ` [Bug c++/101118] " rguenth at gcc dot gnu.org
2021-06-18 10:46 ` iains at gcc dot gnu.org
2021-06-18 15:18 ` nilsgladitz at gmail dot com
2021-06-18 15:39 ` iains at gcc dot gnu.org
2023-03-03 16:06 ` john at drouhard dot dev
2023-03-03 16:26 ` hubicka at gcc dot gnu.org
2023-03-03 16:33 ` iains at gcc dot gnu.org [this message]
2023-03-03 17:06 ` hubicka at ucw dot cz
2023-03-03 17:10 ` iains at gcc dot gnu.org
2023-03-03 19:21 ` iains at gcc dot gnu.org
2023-03-03 19:29 ` iains at gcc dot gnu.org
2023-03-03 20:59 ` iains at gcc dot gnu.org
2023-03-07 12:53 ` hubicka at ucw dot cz
2023-03-07 15:04 ` iains at gcc dot gnu.org
2023-03-07 16:18 ` hubicka at ucw dot cz
2023-03-07 16:27 ` iains at gcc dot gnu.org
2023-04-01 5:28 ` cvs-commit at gcc dot gnu.org
2023-04-30 8:27 ` cvs-commit at gcc dot gnu.org
2023-05-16 19:07 ` cvs-commit at gcc dot gnu.org
2023-05-16 19:11 ` iains at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-101118-4-WFxgkdmvvK@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).