public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/101118] coroutines: unexpected ODR warning for coroutine frame type in LTO builds Date: Tue, 07 Mar 2023 15:04:43 +0000 [thread overview] Message-ID: <bug-101118-4-cIopqS95CQ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-101118-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101118 --- Comment #14 from Iain Sandoe <iains at gcc dot gnu.org> --- (In reply to Jan Hubicka from comment #13) > > So .. for promotion of target expression temporaries to frame vars, one of: > > - a) we need to find a different way to name them > I think we can just count number of fields within a given frame type? yeah I made a hack that did this (and resolves this PR) but I'd think we can find something neater, I'd like to c++-ify the sources some more, and create a class to manage the frame... ( maybe for GCC14 now ). ----- diff --git a/gcc/cp/coroutines.cc b/gcc/cp/coroutines.cc index 7f8cbc3d95e..bb65d41ce18 100644 --- a/gcc/cp/coroutines.cc +++ b/gcc/cp/coroutines.cc @@ -271,6 +271,8 @@ static GTY(()) tree coro_traits_templ; static GTY(()) tree coro_handle_templ; static GTY(()) tree void_coro_handle_type; +static unsigned tmpno = 0; + /* ================= Parse, Semantics and Type checking ================= */ /* This initial set of routines are helper for the parsing and template @@ -2882,7 +2884,7 @@ flatten_await_stmt (var_nest_node *n, hash_set<tree> *promoted, tree init = t; temps_used->add (init); tree var_type = TREE_TYPE (init); - char *buf = xasprintf ("D.%d", DECL_UID (TREE_OPERAND (init, 0))); + char *buf = xasprintf ("T%03u", tmpno++); tree var = build_lang_decl (VAR_DECL, get_identifier (buf), var_type); DECL_ARTIFICIAL (var) = true; free (buf); @@ -4367,6 +4369,7 @@ morph_fn_to_coro (tree orig, tree *resumer, tree *destroyer) { gcc_checking_assert (orig && TREE_CODE (orig) == FUNCTION_DECL); + tmpno = 0; *resumer = error_mark_node; *destroyer = error_mark_node; if (!coro_function_valid_p (orig))
next prev parent reply other threads:[~2023-03-07 15:04 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-18 7:43 [Bug c++/101118] New: " nilsgladitz at gmail dot com 2021-06-18 10:26 ` [Bug c++/101118] " rguenth at gcc dot gnu.org 2021-06-18 10:46 ` iains at gcc dot gnu.org 2021-06-18 15:18 ` nilsgladitz at gmail dot com 2021-06-18 15:39 ` iains at gcc dot gnu.org 2023-03-03 16:06 ` john at drouhard dot dev 2023-03-03 16:26 ` hubicka at gcc dot gnu.org 2023-03-03 16:33 ` iains at gcc dot gnu.org 2023-03-03 17:06 ` hubicka at ucw dot cz 2023-03-03 17:10 ` iains at gcc dot gnu.org 2023-03-03 19:21 ` iains at gcc dot gnu.org 2023-03-03 19:29 ` iains at gcc dot gnu.org 2023-03-03 20:59 ` iains at gcc dot gnu.org 2023-03-07 12:53 ` hubicka at ucw dot cz 2023-03-07 15:04 ` iains at gcc dot gnu.org [this message] 2023-03-07 16:18 ` hubicka at ucw dot cz 2023-03-07 16:27 ` iains at gcc dot gnu.org 2023-04-01 5:28 ` cvs-commit at gcc dot gnu.org 2023-04-30 8:27 ` cvs-commit at gcc dot gnu.org 2023-05-16 19:07 ` cvs-commit at gcc dot gnu.org 2023-05-16 19:11 ` iains at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-101118-4-cIopqS95CQ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).