[Bug target/101235] New: Fails to bootstrap with binutils 2.32

[Bug target/101235] New: Fails to bootstrap with binutils 2.32

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101235

            Bug ID: 101235
           Summary: Fails to bootstrap with binutils 2.32
           Product: gcc
           Version: 11.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
  Target Milestone: ---

Configuring with

../configure --prefix=/usr --infodir=/usr/share/info --mandir=/usr/share/man
--libdir=/usr/lib64 --libexecdir=/usr/lib64
--enable-languages=c,c++,objc,fortran,obj-c++,ada,go --enable-checking=release
--disable-werror --with-gxx-include-dir=/usr/include/c++/11 --enable-ssp
--disable-libssp --disable-libvtv --enable-cet=auto --disable-libcc1
--disable-plugin --with-bugurl=https://bugs.opensuse.org/
'--with-pkgversion=SUSE Linux' --with-slibdir=/lib64 --with-system-zlib
--enable-libstdcxx-allocator=new --disable-libstdcxx-pch
--enable-version-specific-runtime-libs --with-gcc-major-version-only
--enable-linker-build-id --enable-linux-futex --enable-gnu-indirect-function
--program-suffix=-11 --without-system-libunwind --with-cpu=power8
--with-tune=power9 --enable-secureplt --with-long-double-128
--enable-targets=powerpcle-linux --disable-multilib
--build=powerpc64le-suse-linux --host=powerpc64le-suse-linux

causes the build to fail with

[ 1330s] Assembler messages:
[ 1330s] Error: invalid switch -mpower10
[ 1330s] Error: unrecognized option -mpower10
[ 1330s] make[3]: *** [../../../libgcc/shared-object.mk:14: float128-p10.o]
Erro
r 1
[ 1330s] make[3]: *** Waiting for unfinished jobs....
[ 1330s] make[3]: Leaving directory
'/home/abuild/rpmbuild/BUILD/gcc-11.1.1+git400/obj-powerpc64le-suse-linux/powerpc64le-suse-linux/libgcc'
[ 1330s] make[2]: *** [Makefile:19304: all-stage1-target-libgcc] Error 2
[ 1330s] make[2]: Leaving directory
'/home/abuild/rpmbuild/BUILD/gcc-11.1.1+git400/obj-powerpc64le-suse-linux'
[ 1330s] make[1]: *** [Makefile:25648: stage1-bubble] Error 2
[ 1330s] make[1]: Leaving directory
'/home/abuild/rpmbuild/BUILD/gcc-11.1.1+git400/obj-powerpc64le-suse-linux'
[ 1330s] make: *** [Makefile:26587: profiledbootstrap] Error 2
[ 1330s] error: Bad exit status from /var/tmp/rpm-tmp.3OT8Gy (%build)

I don't remember seeing the fail with 11.1.0 so the issue must have crept in
recently.

[Bug target/101235] [11/12 Regression] Fails to bootstrap with binutils 2.32

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101235

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Fails to bootstrap with     |[11/12 Regression] Fails to
                   |binutils 2.32               |bootstrap with binutils
                   |                            |2.32
             Target|                            |powerpc64le-linux
      Known to fail|                            |11.1.1
           Priority|P3                          |P1
   Target Milestone|---                         |11.2
      Known to work|                            |11.1.0
                 CC|                            |carll at gcc dot gnu.org
           Keywords|                            |build

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Probably regressed with g:e7147f01afc3d90d8e96cf4f2899c0f986177674

[Bug target/101235] [11/12 Regression] Fails to bootstrap with binutils 2.32

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101235

Kewen Lin <linkw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
                 CC|                            |linkw at gcc dot gnu.org,
                   |                            |segher at gcc dot gnu.org
   Last reconfirmed|                            |2021-06-28

--- Comment #2 from Kewen Lin <linkw at gcc dot gnu.org> ---
Fixed with r12-1738 on trunk, need one backport.

[Bug target/101235] [11/12 Regression] Fails to bootstrap with binutils 2.32

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101235

--- Comment #3 from Kewen Lin <linkw at gcc dot gnu.org> ---
Will backport the fix after 2021 July 7th (two weeks since it's into trunk) if
this isn't urgent meanwhile got the backport approval.

[Bug target/101235] [11/12 Regression] Fails to bootstrap with binutils 2.32

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101235

--- Comment #4 from Segher Boessenkool <segher at gcc dot gnu.org> ---
(In reply to Kewen Lin from comment #3)
> Will backport the fix after 2021 July 7th (two weeks since it's into trunk)
> if this isn't urgent meanwhile got the backport approval.

The reason to not backport immediately is because you end up with a
royal mess if your patch causes regressions.  A week is normally
plenty: there will be lots of test results that can give you
confidence things work.

If a patch caused build failures, we want that fixed as soon as
possible, because we will not have test results at all otherwise :-)

[Bug target/101235] [11/12 Regression] Fails to bootstrap with binutils 2.32

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101235

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:

https://gcc.gnu.org/g:f6306457ee386a9cae9b08e35ce160af0566b9f9

commit r11-8661-gf6306457ee386a9cae9b08e35ce160af0566b9f9
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Tue Jun 22 23:09:30 2021 -0500

    rs6000: Fix typos in float128 ISA3.1 support

    The recent float128 ISA3.1 support (r12-1340) has some typos,
    it makes the libgcc build fail if it's with one binutils
    (assembler) which doesn't support Power10 insns.  The error
    looks like:

    Error: invalid switch -mpower10
    Error: unrecognized option -mpower10
    ... [...libgcc/shared-object.mk:14: float128-p10.o] Error 1

    What this patch does are:
      - fix test target typo libgcc_cv_powerpc_3_1_float128_hw
        (written wrongly as libgcc_cv_powerpc_float128_hw, so it's
         going to build ISA3.1 stuffs just when detecting ISA3.0).
      - fix test used for libgcc_cv_powerpc_3_1_float128_hw check.
      - fix test option used for libgcc_cv_powerpc_3_1_float128_hw
        check.
      - remove the ISA3.1 related contents from t-float128-hw.
      - add new macro FLOAT128_HW_INSNS_ISA3_1 to differentiate
        ISA3.1 content from ISA3.0 part in ifunc support.

    Bootstrapped/regtested on:
      - powerpc64le-linux-gnu P10
      - powerpc64le-linux-gnu P9 (w/i and w/o p10 supported as)
      - powerpc64-linux-gnu P8 (w/i and w/o p10 supported as)

    libgcc/ChangeLog:

            PR target/101235
            * configure: Regenerate.
            * configure.ac (test for libgcc_cv_powerpc_3_1_float128_hw): Fix
            typos among the name, CFLAGS and the test.
            * config/rs6000/t-float128-hw (fp128_3_1_hw_funcs,
fp128_3_1_hw_src,
            fp128_3_1_hw_static_obj, fp128_3_1_hw_shared_obj,
fp128_3_1_hw_obj):
            Remove.
            * config/rs6000/t-float128-p10-hw (FLOAT128_HW_INSNS): Append
            macro FLOAT128_HW_INSNS_ISA3_1.
            (FP128_3_1_CFLAGS_HW): Fix option typo.
            * config/rs6000/float128-ifunc.c (SW_OR_HW_ISA3_1): Guard this with
            FLOAT128_HW_INSNS_ISA3_1.
            (__floattikf_resolve): Likewise.
            (__floatuntikf_resolve): Likewise.
            (__fixkfti_resolve): Likewise.
            (__fixunskfti_resolve): Likewise.
            (__floattikf): Likewise.
            (__floatuntikf): Likewise.
            (__fixkfti): Likewise.
            (__fixunskfti): Likewise.

    (cherry picked from commit 47749c43acb460ac8f410ee599616d1860ee5a35)

[Bug target/101235] [11/12 Regression] Fails to bootstrap with binutils 2.32

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101235

Kewen Lin <linkw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from Kewen Lin <linkw at gcc dot gnu.org> ---
(In reply to Segher Boessenkool from comment #4)
> (In reply to Kewen Lin from comment #3)
> > Will backport the fix after 2021 July 7th (two weeks since it's into trunk)
> > if this isn't urgent meanwhile got the backport approval.
> 
> The reason to not backport immediately is because you end up with a
> royal mess if your patch causes regressions.  A week is normally
> plenty: there will be lots of test results that can give you
> confidence things work.
> 
> If a patch caused build failures, we want that fixed as soon as
> possible, because we will not have test results at all otherwise :-)

Thanks for the note. I thought this is one partial build issue (the build can
still work with newer binutils) so tried to be conservative. Built successfully
with latest releases/gcc-11, also bootstrapped and regress-tested on
releases/gcc-11 (with newer binutils for regression testing of coz.).

Should be fixed on gcc-11.