public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/103368] New: [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668
@ 2021-11-22 19:40 gscfq@t-online.de
2021-11-23 7:34 ` [Bug fortran/103368] " rguenth at gcc dot gnu.org
` (10 more replies)
0 siblings, 11 replies; 12+ messages in thread
From: gscfq@t-online.de @ 2021-11-22 19:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
Bug ID: 103368
Summary: [11/12 Regression] ICE in gimplify_expr, at
gimplify.c:15668
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
Assignee: unassigned at gcc dot gnu.org
Reporter: gscfq@t-online.de
Target Milestone: ---
Changed between 20211017 and 20211024 :
$ cat z1.f90
program p
type t
end type
type t2
class(*), allocatable :: a
end type
type(t) :: x
call sub (t2(x))
end
$ gfortran-12-20211017 -c z1.f90
z1.f90:8:16:
8 | call sub (t2(x))
| 1
Error: Cannot convert TYPE(t) to CLASS(*) at (1)
$ gfortran-12-20211121 -c z1.f90
z1.f90:8:19:
8 | call sub (t2(x))
| ^
internal compiler error: in gimplify_expr, at gimplify.c:15668
0xad2dc5 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
../../gcc/gimplify.c:15668
0xad862b gimplify_modify_expr
../../gcc/gimplify.c:5983
0xad019a gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
../../gcc/gimplify.c:14666
0xad2df8 gimplify_stmt(tree_node**, gimple**)
../../gcc/gimplify.c:7024
0xad0a6b gimplify_statement_list
../../gcc/gimplify.c:2012
0xad0a6b gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
../../gcc/gimplify.c:15111
0xad2df8 gimplify_stmt(tree_node**, gimple**)
../../gcc/gimplify.c:7024
0xad3351 gimplify_bind_expr
../../gcc/gimplify.c:1426
0xad060a gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
../../gcc/gimplify.c:14867
0xad2df8 gimplify_stmt(tree_node**, gimple**)
../../gcc/gimplify.c:7024
0xad0a6b gimplify_statement_list
../../gcc/gimplify.c:2012
0xad0a6b gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
../../gcc/gimplify.c:15111
0xad2df8 gimplify_stmt(tree_node**, gimple**)
../../gcc/gimplify.c:7024
0xad3351 gimplify_bind_expr
../../gcc/gimplify.c:1426
0xad060a gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
../../gcc/gimplify.c:14867
0xad2df8 gimplify_stmt(tree_node**, gimple**)
../../gcc/gimplify.c:7024
0xad3351 gimplify_bind_expr
../../gcc/gimplify.c:1426
0xad060a gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
../../gcc/gimplify.c:14867
0xad2df8 gimplify_stmt(tree_node**, gimple**)
../../gcc/gimplify.c:7024
0xad3e6b gimplify_body(tree_node*, bool)
../../gcc/gimplify.c:15912
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/103368] [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668
2021-11-22 19:40 [Bug fortran/103368] New: [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 gscfq@t-online.de
@ 2021-11-23 7:34 ` rguenth at gcc dot gnu.org
2021-11-23 7:59 ` [Bug fortran/103368] [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 since r12-4464-g017665f63047ce47 marxin at gcc dot gnu.org
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-11-23 7:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.0
Priority|P3 |P4
Keywords| |ice-on-invalid-code
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/103368] [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 since r12-4464-g017665f63047ce47
2021-11-22 19:40 [Bug fortran/103368] New: [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 gscfq@t-online.de
2021-11-23 7:34 ` [Bug fortran/103368] " rguenth at gcc dot gnu.org
@ 2021-11-23 7:59 ` marxin at gcc dot gnu.org
2021-11-23 8:03 ` pinskia at gcc dot gnu.org
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-23 7:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2021-11-23
Status|UNCONFIRMED |NEW
Summary|[11/12 Regression] ICE in |[11/12 Regression] ICE in
|gimplify_expr, at |gimplify_expr, at
|gimplify.c:15668 |gimplify.c:15668 since
| |r12-4464-g017665f63047ce47
Ever confirmed|0 |1
CC| |burnus at gcc dot gnu.org,
| |marxin at gcc dot gnu.org
--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-4464-g017665f63047ce47.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/103368] [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 since r12-4464-g017665f63047ce47
2021-11-22 19:40 [Bug fortran/103368] New: [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 gscfq@t-online.de
2021-11-23 7:34 ` [Bug fortran/103368] " rguenth at gcc dot gnu.org
2021-11-23 7:59 ` [Bug fortran/103368] [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 since r12-4464-g017665f63047ce47 marxin at gcc dot gnu.org
@ 2021-11-23 8:03 ` pinskia at gcc dot gnu.org
2022-04-21 7:50 ` rguenth at gcc dot gnu.org
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-11-23 8:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|12.0 |11.3
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/103368] [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 since r12-4464-g017665f63047ce47
2021-11-22 19:40 [Bug fortran/103368] New: [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 gscfq@t-online.de
` (2 preceding siblings ...)
2021-11-23 8:03 ` pinskia at gcc dot gnu.org
@ 2022-04-21 7:50 ` rguenth at gcc dot gnu.org
2023-05-29 10:06 ` [Bug fortran/103368] [11/12/13/14 " jakub at gcc dot gnu.org
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-04-21 7:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|11.3 |11.4
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 11.3 is being released, retargeting bugs to GCC 11.4.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/103368] [11/12/13/14 Regression] ICE in gimplify_expr, at gimplify.c:15668 since r12-4464-g017665f63047ce47
2021-11-22 19:40 [Bug fortran/103368] New: [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 gscfq@t-online.de
` (3 preceding siblings ...)
2022-04-21 7:50 ` rguenth at gcc dot gnu.org
@ 2023-05-29 10:06 ` jakub at gcc dot gnu.org
2024-04-02 19:40 ` [Bug fortran/103368] [11/12/13 " anlauf at gcc dot gnu.org
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: jakub at gcc dot gnu.org @ 2023-05-29 10:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|11.4 |11.5
--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 11.4 is being released, retargeting bugs to GCC 11.5.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/103368] [11/12/13 Regression] ICE in gimplify_expr, at gimplify.c:15668 since r12-4464-g017665f63047ce47
2021-11-22 19:40 [Bug fortran/103368] New: [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 gscfq@t-online.de
` (4 preceding siblings ...)
2023-05-29 10:06 ` [Bug fortran/103368] [11/12/13/14 " jakub at gcc dot gnu.org
@ 2024-04-02 19:40 ` anlauf at gcc dot gnu.org
2024-04-03 0:49 ` jvdelisle at gcc dot gnu.org
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: anlauf at gcc dot gnu.org @ 2024-04-02 19:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to work| |14.0
Summary|[11/12/13/14 Regression] |[11/12/13 Regression] ICE
|ICE in gimplify_expr, at |in gimplify_expr, at
|gimplify.c:15668 since |gimplify.c:15668 since
|r12-4464-g017665f63047ce47 |r12-4464-g017665f63047ce47
--- Comment #4 from anlauf at gcc dot gnu.org ---
Seems to ICE no longer at r14-9759, but 13-branch and older still fail.
Adjusting summary.
But is it really invalid code? Intel and NAG accept it.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/103368] [11/12/13 Regression] ICE in gimplify_expr, at gimplify.c:15668 since r12-4464-g017665f63047ce47
2021-11-22 19:40 [Bug fortran/103368] New: [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 gscfq@t-online.de
` (5 preceding siblings ...)
2024-04-02 19:40 ` [Bug fortran/103368] [11/12/13 " anlauf at gcc dot gnu.org
@ 2024-04-03 0:49 ` jvdelisle at gcc dot gnu.org
2024-05-23 17:09 ` pault at gcc dot gnu.org
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: jvdelisle at gcc dot gnu.org @ 2024-04-03 0:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jvdelisle at gcc dot gnu.org
--- Comment #5 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
(In reply to anlauf from comment #4)
> Seems to ICE no longer at r14-9759, but 13-branch and older still fail.
> Adjusting summary.
>
> But is it really invalid code? Intel and NAG accept it.
I am not getting an ICE here. Until sub is defined or further definitions on
components to t or t2, I do not see a basis to reject anything or give a
diagnostic.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/103368] [11/12/13 Regression] ICE in gimplify_expr, at gimplify.c:15668 since r12-4464-g017665f63047ce47
2021-11-22 19:40 [Bug fortran/103368] New: [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 gscfq@t-online.de
` (6 preceding siblings ...)
2024-04-03 0:49 ` jvdelisle at gcc dot gnu.org
@ 2024-05-23 17:09 ` pault at gcc dot gnu.org
2024-05-23 18:18 ` anlauf at gcc dot gnu.org
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pault at gcc dot gnu.org @ 2024-05-23 17:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
Paul Thomas <pault at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pault at gcc dot gnu.org
Assignee|unassigned at gcc dot gnu.org |pault at gcc dot gnu.org
--- Comment #6 from Paul Thomas <pault at gcc dot gnu.org> ---
Created attachment 58277
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58277&action=edit
Fix for this PR
This was substantially fixed on 14-branch by the patch for PR49213. However,
there have been many subsequent changes to gfc_trans_structure_assign and its
subsidiary functions as the attachment demonstrates.
I haven't attempted to do any weeding of the changes to separate those
responsible for fixing this PR. However, 13-branch regtests successfuly with
the patch applied.
Should I commit this with a testcase or just close the PR?
Paul
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/103368] [11/12/13 Regression] ICE in gimplify_expr, at gimplify.c:15668 since r12-4464-g017665f63047ce47
2021-11-22 19:40 [Bug fortran/103368] New: [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 gscfq@t-online.de
` (7 preceding siblings ...)
2024-05-23 17:09 ` pault at gcc dot gnu.org
@ 2024-05-23 18:18 ` anlauf at gcc dot gnu.org
2024-05-23 21:38 ` paul.richard.thomas at gmail dot com
2024-05-24 19:49 ` anlauf at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: anlauf at gcc dot gnu.org @ 2024-05-23 18:18 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anlauf at gcc dot gnu.org
--- Comment #7 from anlauf at gcc dot gnu.org ---
(In reply to Paul Thomas from comment #6)
> Created attachment 58277 [details]
> Fix for this PR
>
> This was substantially fixed on 14-branch by the patch for PR49213. However,
> there have been many subsequent changes to gfc_trans_structure_assign and
> its subsidiary functions as the attachment demonstrates.
>
> I haven't attempted to do any weeding of the changes to separate those
> responsible for fixing this PR. However, 13-branch regtests successfuly with
> the patch applied.
>
> Should I commit this with a testcase or just close the PR?
>
> Paul
Paul,
can you summarize where you gathered the pieces of this patch from?
From a quick glance, r14-870 and r14-2160 (both yours) seem to be involved.
Does it also fix any of the issues addressed by the respective PRs?
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/103368] [11/12/13 Regression] ICE in gimplify_expr, at gimplify.c:15668 since r12-4464-g017665f63047ce47
2021-11-22 19:40 [Bug fortran/103368] New: [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 gscfq@t-online.de
` (8 preceding siblings ...)
2024-05-23 18:18 ` anlauf at gcc dot gnu.org
@ 2024-05-23 21:38 ` paul.richard.thomas at gmail dot com
2024-05-24 19:49 ` anlauf at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: paul.richard.thomas at gmail dot com @ 2024-05-23 21:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
--- Comment #8 from paul.richard.thomas at gmail dot com <paul.richard.thomas at gmail dot com> ---
Hi Harald,
I simply copied all the associated functions in trans-expr.cc from mainline
and plonked them in 13-branch. That's why I said that I hadn't done any
weeding. There is also a commit from Jakub in there as well. I'll check to
see if the associated PRs are fixed.
I got into regression fixing before the 14.1 release and this was one of
the low hanging fruit. To be honest, I am not especially bothered about
fixing it or not. Up until the ICE of the PR it was giving an error on
valid code. I would prefer though that the ICE went away!
Cheers
Paul
On Thu, 23 May 2024 at 19:18, anlauf at gcc dot gnu.org <
gcc-bugzilla@gcc.gnu.org> wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
>
> anlauf at gcc dot gnu.org changed:
>
> What |Removed |Added
>
> ----------------------------------------------------------------------------
> CC| |anlauf at gcc dot gnu.org
>
> --- Comment #7 from anlauf at gcc dot gnu.org ---
> (In reply to Paul Thomas from comment #6)
> > Created attachment 58277 [details]
> > Fix for this PR
> >
> > This was substantially fixed on 14-branch by the patch for PR49213.
> However,
> > there have been many subsequent changes to gfc_trans_structure_assign and
> > its subsidiary functions as the attachment demonstrates.
> >
> > I haven't attempted to do any weeding of the changes to separate those
> > responsible for fixing this PR. However, 13-branch regtests successfuly
> with
> > the patch applied.
> >
> > Should I commit this with a testcase or just close the PR?
> >
> > Paul
>
> Paul,
>
> can you summarize where you gathered the pieces of this patch from?
>
> From a quick glance, r14-870 and r14-2160 (both yours) seem to be involved.
>
> Does it also fix any of the issues addressed by the respective PRs?
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
> You are the assignee for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug fortran/103368] [11/12/13 Regression] ICE in gimplify_expr, at gimplify.c:15668 since r12-4464-g017665f63047ce47
2021-11-22 19:40 [Bug fortran/103368] New: [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 gscfq@t-online.de
` (9 preceding siblings ...)
2024-05-23 21:38 ` paul.richard.thomas at gmail dot com
@ 2024-05-24 19:49 ` anlauf at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: anlauf at gcc dot gnu.org @ 2024-05-24 19:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103368
--- Comment #9 from anlauf at gcc dot gnu.org ---
(In reply to paul.richard.thomas@gmail.com from comment #8)
> I simply copied all the associated functions in trans-expr.cc from mainline
> and plonked them in 13-branch. That's why I said that I hadn't done any
> weeding. There is also a commit from Jakub in there as well. I'll check to
> see if the associated PRs are fixed.
>
> I got into regression fixing before the 14.1 release and this was one of
> the low hanging fruit. To be honest, I am not especially bothered about
> fixing it or not. Up until the ICE of the PR it was giving an error on
> valid code. I would prefer though that the ICE went away!
Well, if the ICE is resolved and there is no regression, go ahead.
The commits I mentioned on 14-branch address some more, so it may be
a waste of time to see if any issue was fixed along the way.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2024-05-24 19:49 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22 19:40 [Bug fortran/103368] New: [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 gscfq@t-online.de
2021-11-23 7:34 ` [Bug fortran/103368] " rguenth at gcc dot gnu.org
2021-11-23 7:59 ` [Bug fortran/103368] [11/12 Regression] ICE in gimplify_expr, at gimplify.c:15668 since r12-4464-g017665f63047ce47 marxin at gcc dot gnu.org
2021-11-23 8:03 ` pinskia at gcc dot gnu.org
2022-04-21 7:50 ` rguenth at gcc dot gnu.org
2023-05-29 10:06 ` [Bug fortran/103368] [11/12/13/14 " jakub at gcc dot gnu.org
2024-04-02 19:40 ` [Bug fortran/103368] [11/12/13 " anlauf at gcc dot gnu.org
2024-04-03 0:49 ` jvdelisle at gcc dot gnu.org
2024-05-23 17:09 ` pault at gcc dot gnu.org
2024-05-23 18:18 ` anlauf at gcc dot gnu.org
2024-05-23 21:38 ` paul.richard.thomas at gmail dot com
2024-05-24 19:49 ` anlauf at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).