public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/103771] [12 Regression] Missed vectorization under -mavx512f -mavx512vl after r12-5489 Date: Thu, 13 Jan 2022 09:50:32 +0000 [thread overview] Message-ID: <bug-103771-4-3vIY43xFro@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-103771-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103771 --- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> --- Forcing the pattern to not trigger produces the expected t.c:8:6: missed: not vectorized: relevant stmt not supported: iftmp.0_21 = x.1_14 > 255 ? iftmp.0_19 : iftmp.0_20; since condition vectorization itself doesn't know how to handle this, we end up at if (vectype1 && !useless_type_conversion_p (vectype, vectype1)) return false; with vectype V32QI and vectype1 V8SI. Splitting out the compare from the COND_EXPR in the pattern but leaving out the attempt to "widen" it reveals the same fact that vectorizable_condition doesn't support packing of multiple vector defs for the mask operand. I think that is what we need to add. We also don't have a good representation for "packing" of masks. diff --git a/gcc/tree-vect-patterns.c b/gcc/tree-vect-patterns.c index 3ea905538e1..729a1d32612 100644 --- a/gcc/tree-vect-patterns.c +++ b/gcc/tree-vect-patterns.c @@ -4679,8 +4679,10 @@ vect_recog_mask_conversion_pattern (vec_info *vinfo, rhs1_type); } - if (maybe_ne (TYPE_VECTOR_SUBPARTS (vectype1), - TYPE_VECTOR_SUBPARTS (vectype2))) + /* AVX512 style masks cannot be packed/unpacked. */ + if (TYPE_PRECISION (TREE_TYPE (vectype2)) != 1 + && maybe_ne (TYPE_VECTOR_SUBPARTS (vectype1), + TYPE_VECTOR_SUBPARTS (vectype2))) tmp = build_mask_conversion (vinfo, rhs1, vectype1, stmt_vinfo); else tmp = rhs1;
next prev parent reply other threads:[~2022-01-13 9:50 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-20 8:59 [Bug target/103771] New: " wwwhhhyyy333 at gmail dot com 2021-12-20 11:45 ` [Bug target/103771] [12 Regression] " pinskia at gcc dot gnu.org 2022-01-04 15:31 ` tnfchris at gcc dot gnu.org 2022-01-05 9:00 ` crazylht at gmail dot com 2022-01-13 8:43 ` crazylht at gmail dot com 2022-01-13 9:02 ` crazylht at gmail dot com 2022-01-13 9:04 ` crazylht at gmail dot com 2022-01-13 9:28 ` rguenth at gcc dot gnu.org 2022-01-13 9:50 ` rguenth at gcc dot gnu.org [this message] 2022-01-13 10:04 ` crazylht at gmail dot com 2022-01-13 10:11 ` rsandifo at gcc dot gnu.org 2022-01-13 10:22 ` crazylht at gmail dot com 2022-01-13 10:43 ` crazylht at gmail dot com 2022-01-13 10:44 ` rguenther at suse dot de 2022-01-13 10:49 ` rguenther at suse dot de 2022-01-13 10:50 ` crazylht at gmail dot com 2022-01-13 12:40 ` crazylht at gmail dot com 2022-01-13 13:42 ` rguenther at suse dot de 2022-01-13 14:42 ` crazylht at gmail dot com 2022-01-14 9:40 ` rsandifo at gcc dot gnu.org 2022-01-14 10:18 ` rguenth at gcc dot gnu.org 2022-01-17 8:22 ` crazylht at gmail dot com 2022-01-18 8:31 ` crazylht at gmail dot com 2022-01-18 8:36 ` crazylht at gmail dot com 2022-01-18 10:44 ` rguenther at suse dot de 2022-01-18 10:49 ` pinskia at gcc dot gnu.org 2022-01-19 6:03 ` crazylht at gmail dot com 2022-01-19 6:10 ` pinskia at gcc dot gnu.org 2022-01-19 6:25 ` crazylht at gmail dot com 2022-01-19 7:44 ` rguenth at gcc dot gnu.org 2022-01-19 8:33 ` crazylht at gmail dot com 2022-01-19 8:48 ` rguenther at suse dot de 2022-01-20 8:52 ` cvs-commit at gcc dot gnu.org 2022-01-27 6:03 ` crazylht at gmail dot com 2022-02-01 5:21 ` pinskia at gcc dot gnu.org 2022-02-01 16:13 ` law at gcc dot gnu.org 2022-02-01 16:18 ` pinskia at gcc dot gnu.org 2022-02-13 9:58 ` cvs-commit at gcc dot gnu.org 2022-02-14 7:36 ` rguenth at gcc dot gnu.org 2022-02-14 7:45 ` crazylht at gmail dot com 2022-02-14 7:53 ` rguenth at gcc dot gnu.org 2022-02-17 11:01 ` cvs-commit at gcc dot gnu.org 2023-04-26 6:55 ` [Bug target/103771] [12/13/14 " rguenth at gcc dot gnu.org 2023-05-06 23:21 ` pinskia at gcc dot gnu.org 2023-05-08 7:38 ` cvs-commit at gcc dot gnu.org 2023-05-08 7:39 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-103771-4-3vIY43xFro@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).