public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/103771] [12 Regression] Missed vectorization under -mavx512f -mavx512vl after r12-5489
Date: Thu, 13 Jan 2022 10:44:12 +0000 [thread overview]
Message-ID: <bug-103771-4-eFEHtONhJg@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103771-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103771
--- Comment #12 from rguenther at suse dot de <rguenther at suse dot de> ---
On Thu, 13 Jan 2022, crazylht at gmail dot com wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103771
>
> --- Comment #10 from Hongtao.liu <crazylht at gmail dot com> ---
> with
> @@ -12120,7 +12120,8 @@ supportable_narrowing_operation (enum tree_code code,
> c1 = VEC_PACK_TRUNC_EXPR;
> if (VECTOR_BOOLEAN_TYPE_P (narrow_vectype)
> && VECTOR_BOOLEAN_TYPE_P (vectype)
> - && TYPE_MODE (narrow_vectype) == TYPE_MODE (vectype)
> + && (TYPE_MODE (narrow_vectype) == TYPE_MODE (vectype)
> + || known_lt (TYPE_VECTOR_SUBPARTS (vectype), BITS_PER_UNIT))
> && SCALAR_INT_MODE_P (TYPE_MODE (vectype)))
I think we instead simply want
if (VECTOR_BOOLEAN_TYPE_P (narrow_vectype)
&& TYPE_PRECISION (TREE_TYPE (narrow_vectype)) == 1
&& VECTOR_BOOLEAN_TYPE_P (vectype)
&& TYPE_PRECISION (TREE_TYPE (vectype)) == 1)
note the docs of vec_pack_sbool_trunc say
This instruction pattern is used when all the vector input and output
operands have the same scalar mode @var{m} and thus using
@code{vec_pack_trunc_@var{m}} would be ambiguous.
It also says "_Narrow_ and merge the elements of two vectors.", I think
"narrow" is misleading here, _trunc in the optab name as well. So
with the above it suggests we could have used vect_pack_trunc_hi here?
To avoid breaking things for the VnBImode using targets we probably
want to retain the SCALAR_INT_MODE_P (prev_mode) check. And we
probably want to adjust the documentation a bit.
This all is with my pasted pattern patch or is this with the weird
inserted conversion still?
next prev parent reply other threads:[~2022-01-13 10:44 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 8:59 [Bug target/103771] New: " wwwhhhyyy333 at gmail dot com
2021-12-20 11:45 ` [Bug target/103771] [12 Regression] " pinskia at gcc dot gnu.org
2022-01-04 15:31 ` tnfchris at gcc dot gnu.org
2022-01-05 9:00 ` crazylht at gmail dot com
2022-01-13 8:43 ` crazylht at gmail dot com
2022-01-13 9:02 ` crazylht at gmail dot com
2022-01-13 9:04 ` crazylht at gmail dot com
2022-01-13 9:28 ` rguenth at gcc dot gnu.org
2022-01-13 9:50 ` rguenth at gcc dot gnu.org
2022-01-13 10:04 ` crazylht at gmail dot com
2022-01-13 10:11 ` rsandifo at gcc dot gnu.org
2022-01-13 10:22 ` crazylht at gmail dot com
2022-01-13 10:43 ` crazylht at gmail dot com
2022-01-13 10:44 ` rguenther at suse dot de [this message]
2022-01-13 10:49 ` rguenther at suse dot de
2022-01-13 10:50 ` crazylht at gmail dot com
2022-01-13 12:40 ` crazylht at gmail dot com
2022-01-13 13:42 ` rguenther at suse dot de
2022-01-13 14:42 ` crazylht at gmail dot com
2022-01-14 9:40 ` rsandifo at gcc dot gnu.org
2022-01-14 10:18 ` rguenth at gcc dot gnu.org
2022-01-17 8:22 ` crazylht at gmail dot com
2022-01-18 8:31 ` crazylht at gmail dot com
2022-01-18 8:36 ` crazylht at gmail dot com
2022-01-18 10:44 ` rguenther at suse dot de
2022-01-18 10:49 ` pinskia at gcc dot gnu.org
2022-01-19 6:03 ` crazylht at gmail dot com
2022-01-19 6:10 ` pinskia at gcc dot gnu.org
2022-01-19 6:25 ` crazylht at gmail dot com
2022-01-19 7:44 ` rguenth at gcc dot gnu.org
2022-01-19 8:33 ` crazylht at gmail dot com
2022-01-19 8:48 ` rguenther at suse dot de
2022-01-20 8:52 ` cvs-commit at gcc dot gnu.org
2022-01-27 6:03 ` crazylht at gmail dot com
2022-02-01 5:21 ` pinskia at gcc dot gnu.org
2022-02-01 16:13 ` law at gcc dot gnu.org
2022-02-01 16:18 ` pinskia at gcc dot gnu.org
2022-02-13 9:58 ` cvs-commit at gcc dot gnu.org
2022-02-14 7:36 ` rguenth at gcc dot gnu.org
2022-02-14 7:45 ` crazylht at gmail dot com
2022-02-14 7:53 ` rguenth at gcc dot gnu.org
2022-02-17 11:01 ` cvs-commit at gcc dot gnu.org
2023-04-26 6:55 ` [Bug target/103771] [12/13/14 " rguenth at gcc dot gnu.org
2023-05-06 23:21 ` pinskia at gcc dot gnu.org
2023-05-08 7:38 ` cvs-commit at gcc dot gnu.org
2023-05-08 7:39 ` pinskia at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-103771-4-eFEHtONhJg@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).