* [Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438
2022-09-06 17:13 [Bug fortran/106857] New: [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 gscfq@t-online.de
@ 2022-09-06 19:35 ` anlauf at gcc dot gnu.org
2022-09-07 8:26 ` rguenth at gcc dot gnu.org
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: anlauf at gcc dot gnu.org @ 2022-09-06 19:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
CC| |anlauf at gcc dot gnu.org
Last reconfirmed| |2022-09-06
Ever confirmed|0 |1
--- Comment #1 from anlauf at gcc dot gnu.org ---
Obvious fix for NULL pointer dereference:
diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
index bc178d54891..d5c4fe8443d 100644
--- a/gcc/fortran/simplify.cc
+++ b/gcc/fortran/simplify.cc
@@ -6431,7 +6432,7 @@ gfc_simplify_pack (gfc_expr *array, gfc_expr *mask,
gfc_expr *vector)
/* Copy only those elements of ARRAY to RESULT whose
MASK equals .TRUE.. */
mask_ctor = gfc_constructor_first (mask->value.constructor);
- while (mask_ctor)
+ while (mask_ctor && array_ctor)
{
if (mask_ctor->expr->value.logical)
{
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438
2022-09-06 17:13 [Bug fortran/106857] New: [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 gscfq@t-online.de
2022-09-06 19:35 ` [Bug fortran/106857] " anlauf at gcc dot gnu.org
@ 2022-09-07 8:26 ` rguenth at gcc dot gnu.org
2022-09-07 12:04 ` [Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79 marxin at gcc dot gnu.org
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-09-07 8:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P4
Target Milestone|--- |10.5
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79
2022-09-06 17:13 [Bug fortran/106857] New: [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 gscfq@t-online.de
2022-09-06 19:35 ` [Bug fortran/106857] " anlauf at gcc dot gnu.org
2022-09-07 8:26 ` rguenth at gcc dot gnu.org
@ 2022-09-07 12:04 ` marxin at gcc dot gnu.org
2022-09-15 20:37 ` anlauf at gcc dot gnu.org
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-09-07 12:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marxin at gcc dot gnu.org
Summary|[10/11/12/13 Regression] |[10/11/12/13 Regression]
|ICE in gfc_simplify_pack, |ICE in gfc_simplify_pack,
|at fortran/simplify.cc:6438 |at fortran/simplify.cc:6438
| |since
| |r12-4278-g74ccca380cde5e79
--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-4278-g74ccca380cde5e79.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79
2022-09-06 17:13 [Bug fortran/106857] New: [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 gscfq@t-online.de
` (2 preceding siblings ...)
2022-09-07 12:04 ` [Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79 marxin at gcc dot gnu.org
@ 2022-09-15 20:37 ` anlauf at gcc dot gnu.org
2022-09-15 20:44 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: anlauf at gcc dot gnu.org @ 2022-09-15 20:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |anlauf at gcc dot gnu.org
--- Comment #3 from anlauf at gcc dot gnu.org ---
(In reply to anlauf from comment #1)
> Obvious fix for NULL pointer dereference:
>
> diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
> index bc178d54891..d5c4fe8443d 100644
> --- a/gcc/fortran/simplify.cc
> +++ b/gcc/fortran/simplify.cc
> @@ -6431,7 +6432,7 @@ gfc_simplify_pack (gfc_expr *array, gfc_expr *mask,
> gfc_expr *vector)
> /* Copy only those elements of ARRAY to RESULT whose
> MASK equals .TRUE.. */
> mask_ctor = gfc_constructor_first (mask->value.constructor);
> - while (mask_ctor)
> + while (mask_ctor && array_ctor)
> {
> if (mask_ctor->expr->value.logical)
> {
This regtests fine. Taking.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79
2022-09-06 17:13 [Bug fortran/106857] New: [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 gscfq@t-online.de
` (3 preceding siblings ...)
2022-09-15 20:37 ` anlauf at gcc dot gnu.org
@ 2022-09-15 20:44 ` cvs-commit at gcc dot gnu.org
2022-09-16 19:11 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-09-15 20:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:2b75d5f533b9d6b39f4055949aff64ed0d22dd24
commit r13-2691-g2b75d5f533b9d6b39f4055949aff64ed0d22dd24
Author: Harald Anlauf <anlauf@gmx.de>
Date: Thu Sep 15 22:39:24 2022 +0200
Fortran: catch NULL pointer dereferences while simplifying PACK [PR106857]
gcc/fortran/ChangeLog:
PR fortran/106857
* simplify.cc (gfc_simplify_pack): Check for NULL pointer
dereferences
while walking through constructors (error recovery).
gcc/testsuite/ChangeLog:
PR fortran/106857
* gfortran.dg/pr106857.f90: New test.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79
2022-09-06 17:13 [Bug fortran/106857] New: [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 gscfq@t-online.de
` (4 preceding siblings ...)
2022-09-15 20:44 ` cvs-commit at gcc dot gnu.org
@ 2022-09-16 19:11 ` cvs-commit at gcc dot gnu.org
2022-09-22 18:27 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-09-16 19:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:f5023ce74f882b7f7c8cf41e70cc7380ba0eba06
commit r12-8769-gf5023ce74f882b7f7c8cf41e70cc7380ba0eba06
Author: Harald Anlauf <anlauf@gmx.de>
Date: Thu Sep 15 22:39:24 2022 +0200
Fortran: catch NULL pointer dereferences while simplifying PACK [PR106857]
gcc/fortran/ChangeLog:
PR fortran/106857
* simplify.cc (gfc_simplify_pack): Check for NULL pointer
dereferences
while walking through constructors (error recovery).
gcc/testsuite/ChangeLog:
PR fortran/106857
* gfortran.dg/pr106857.f90: New test.
(cherry picked from commit 2b75d5f533b9d6b39f4055949aff64ed0d22dd24)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79
2022-09-06 17:13 [Bug fortran/106857] New: [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 gscfq@t-online.de
` (5 preceding siblings ...)
2022-09-16 19:11 ` cvs-commit at gcc dot gnu.org
@ 2022-09-22 18:27 ` cvs-commit at gcc dot gnu.org
2022-09-22 18:37 ` cvs-commit at gcc dot gnu.org
2022-09-22 18:38 ` anlauf at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-09-22 18:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:f954e0531beb8cbb128cc4ab70d65a92c5ac9a7d
commit r11-10268-gf954e0531beb8cbb128cc4ab70d65a92c5ac9a7d
Author: Harald Anlauf <anlauf@gmx.de>
Date: Thu Sep 15 22:39:24 2022 +0200
Fortran: catch NULL pointer dereferences while simplifying PACK [PR106857]
gcc/fortran/ChangeLog:
PR fortran/106857
* simplify.c (gfc_simplify_pack): Check for NULL pointer
dereferences
while walking through constructors (error recovery).
gcc/testsuite/ChangeLog:
PR fortran/106857
* gfortran.dg/pr106857.f90: New test.
(cherry picked from commit 2b75d5f533b9d6b39f4055949aff64ed0d22dd24)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79
2022-09-06 17:13 [Bug fortran/106857] New: [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 gscfq@t-online.de
` (6 preceding siblings ...)
2022-09-22 18:27 ` cvs-commit at gcc dot gnu.org
@ 2022-09-22 18:37 ` cvs-commit at gcc dot gnu.org
2022-09-22 18:38 ` anlauf at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-09-22 18:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:cf172d0cdf355042223a3b1ebc04b472386a954e
commit r10-10998-gcf172d0cdf355042223a3b1ebc04b472386a954e
Author: Harald Anlauf <anlauf@gmx.de>
Date: Thu Sep 15 22:39:24 2022 +0200
Fortran: catch NULL pointer dereferences while simplifying PACK [PR106857]
gcc/fortran/ChangeLog:
PR fortran/106857
* simplify.c (gfc_simplify_pack): Check for NULL pointer
dereferences
while walking through constructors (error recovery).
gcc/testsuite/ChangeLog:
PR fortran/106857
* gfortran.dg/pr106857.f90: New test.
(cherry picked from commit 2b75d5f533b9d6b39f4055949aff64ed0d22dd24)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79
2022-09-06 17:13 [Bug fortran/106857] New: [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 gscfq@t-online.de
` (7 preceding siblings ...)
2022-09-22 18:37 ` cvs-commit at gcc dot gnu.org
@ 2022-09-22 18:38 ` anlauf at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: anlauf at gcc dot gnu.org @ 2022-09-22 18:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from anlauf at gcc dot gnu.org ---
Fixed on all open branches. Closing.
Thanks for the report!
^ permalink raw reply [flat|nested] 10+ messages in thread