[Bug fortran/106857] New: [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438

[Bug fortran/106857] New: [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857

            Bug ID: 106857
           Summary: [10/11/12/13 Regression] ICE in gfc_simplify_pack, at
                    fortran/simplify.cc:6438
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started between 20211003 and 20211010 :


$ cat z1.f90
program p
   type t
      integer :: n
   end type
   type(t), parameter :: a(2,2) = t(1)
   type(t), parameter :: b(4) = reshape(a, [2])
   type(t), parameter :: c(2) = pack(b, [.false.,.true.,.false.,.true.])
end


$ gfortran-12-20211003 -c z1.f90
z1.f90:6:29:

    6 |    type(t), parameter :: b(4) = reshape(a, [2])
      |                             1
Error: Different shape for array assignment at (1) on dimension 1 (4 and 2)


$ gfortran-13-20220904 -c z1.f90
f951: internal compiler error: Segmentation fault
0xd8a29f crash_signal
        ../../gcc/toplev.cc:314
0x84695d gfc_simplify_pack(gfc_expr*, gfc_expr*, gfc_expr*)
        ../../gcc/fortran/simplify.cc:6438
0x7c2f2a do_simplify
        ../../gcc/fortran/intrinsic.cc:4677
0x7cde0a gfc_intrinsic_func_interface(gfc_expr*, int)
        ../../gcc/fortran/intrinsic.cc:5056
0x8230c8 resolve_unknown_f
        ../../gcc/fortran/resolve.cc:2990
0x8230c8 resolve_function
        ../../gcc/fortran/resolve.cc:3347
0x8230c8 gfc_resolve_expr(gfc_expr*)
        ../../gcc/fortran/resolve.cc:7194
0x7b2de4 gfc_reduce_init_expr(gfc_expr*)
        ../../gcc/fortran/expr.cc:3163
0x7b5d70 gfc_match_init_expr(gfc_expr**)
        ../../gcc/fortran/expr.cc:3211
0x79ff6b variable_decl
        ../../gcc/fortran/decl.cc:3028
0x79ff6b gfc_match_data_decl()
        ../../gcc/fortran/decl.cc:6331
0x80b513 match_word
        ../../gcc/fortran/parse.cc:67
0x80b513 decode_statement
        ../../gcc/fortran/parse.cc:378
0x80cf5a next_free
        ../../gcc/fortran/parse.cc:1398
0x80cf5a next_statement
        ../../gcc/fortran/parse.cc:1630
0x80e4fb parse_spec
        ../../gcc/fortran/parse.cc:4169
0x8116bc parse_progunit
        ../../gcc/fortran/parse.cc:6211
0x812d81 gfc_parse_file()
        ../../gcc/fortran/parse.cc:6756
0x860b1f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.cc:229

[Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |anlauf at gcc dot gnu.org
   Last reconfirmed|                            |2022-09-06
     Ever confirmed|0                           |1

--- Comment #1 from anlauf at gcc dot gnu.org ---
Obvious fix for NULL pointer dereference:

diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
index bc178d54891..d5c4fe8443d 100644
--- a/gcc/fortran/simplify.cc
+++ b/gcc/fortran/simplify.cc
@@ -6431,7 +6432,7 @@ gfc_simplify_pack (gfc_expr *array, gfc_expr *mask,
gfc_expr *vector)
       /* Copy only those elements of ARRAY to RESULT whose
         MASK equals .TRUE..  */
       mask_ctor = gfc_constructor_first (mask->value.constructor);
-      while (mask_ctor)
+      while (mask_ctor && array_ctor)
        {
          if (mask_ctor->expr->value.logical)
            {

[Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |10.5

[Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org
            Summary|[10/11/12/13 Regression]    |[10/11/12/13 Regression]
                   |ICE in gfc_simplify_pack,   |ICE in gfc_simplify_pack,
                   |at fortran/simplify.cc:6438 |at fortran/simplify.cc:6438
                   |                            |since
                   |                            |r12-4278-g74ccca380cde5e79

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-4278-g74ccca380cde5e79.

[Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

--- Comment #3 from anlauf at gcc dot gnu.org ---
(In reply to anlauf from comment #1)
> Obvious fix for NULL pointer dereference:
> 
> diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
> index bc178d54891..d5c4fe8443d 100644
> --- a/gcc/fortran/simplify.cc
> +++ b/gcc/fortran/simplify.cc
> @@ -6431,7 +6432,7 @@ gfc_simplify_pack (gfc_expr *array, gfc_expr *mask,
> gfc_expr *vector)
>        /* Copy only those elements of ARRAY to RESULT whose
>  	 MASK equals .TRUE..  */
>        mask_ctor = gfc_constructor_first (mask->value.constructor);
> -      while (mask_ctor)
> +      while (mask_ctor && array_ctor)
>  	{
>  	  if (mask_ctor->expr->value.logical)
>  	    {

This regtests fine.  Taking.

[Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:2b75d5f533b9d6b39f4055949aff64ed0d22dd24

commit r13-2691-g2b75d5f533b9d6b39f4055949aff64ed0d22dd24
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Sep 15 22:39:24 2022 +0200

    Fortran: catch NULL pointer dereferences while simplifying PACK [PR106857]

    gcc/fortran/ChangeLog:

            PR fortran/106857
            * simplify.cc (gfc_simplify_pack): Check for NULL pointer
dereferences
            while walking through constructors (error recovery).

    gcc/testsuite/ChangeLog:

            PR fortran/106857
            * gfortran.dg/pr106857.f90: New test.

[Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:f5023ce74f882b7f7c8cf41e70cc7380ba0eba06

commit r12-8769-gf5023ce74f882b7f7c8cf41e70cc7380ba0eba06
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Sep 15 22:39:24 2022 +0200

    Fortran: catch NULL pointer dereferences while simplifying PACK [PR106857]

    gcc/fortran/ChangeLog:

            PR fortran/106857
            * simplify.cc (gfc_simplify_pack): Check for NULL pointer
dereferences
            while walking through constructors (error recovery).

    gcc/testsuite/ChangeLog:

            PR fortran/106857
            * gfortran.dg/pr106857.f90: New test.

    (cherry picked from commit 2b75d5f533b9d6b39f4055949aff64ed0d22dd24)

[Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:f954e0531beb8cbb128cc4ab70d65a92c5ac9a7d

commit r11-10268-gf954e0531beb8cbb128cc4ab70d65a92c5ac9a7d
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Sep 15 22:39:24 2022 +0200

    Fortran: catch NULL pointer dereferences while simplifying PACK [PR106857]

    gcc/fortran/ChangeLog:

            PR fortran/106857
            * simplify.c (gfc_simplify_pack): Check for NULL pointer
dereferences
            while walking through constructors (error recovery).

    gcc/testsuite/ChangeLog:

            PR fortran/106857
            * gfortran.dg/pr106857.f90: New test.

    (cherry picked from commit 2b75d5f533b9d6b39f4055949aff64ed0d22dd24)

[Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:cf172d0cdf355042223a3b1ebc04b472386a954e

commit r10-10998-gcf172d0cdf355042223a3b1ebc04b472386a954e
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Sep 15 22:39:24 2022 +0200

    Fortran: catch NULL pointer dereferences while simplifying PACK [PR106857]

    gcc/fortran/ChangeLog:

            PR fortran/106857
            * simplify.c (gfc_simplify_pack): Check for NULL pointer
dereferences
            while walking through constructors (error recovery).

    gcc/testsuite/ChangeLog:

            PR fortran/106857
            * gfortran.dg/pr106857.f90: New test.

    (cherry picked from commit 2b75d5f533b9d6b39f4055949aff64ed0d22dd24)

[Bug fortran/106857] [10/11/12/13 Regression] ICE in gfc_simplify_pack, at fortran/simplify.cc:6438 since r12-4278-g74ccca380cde5e79

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106857

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from anlauf at gcc dot gnu.org ---
Fixed on all open branches.  Closing.

Thanks for the report!