public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/109776] New: [14 Regression] pr81192 fails on some targets after recent propagator changes
@ 2023-05-08 16:41 law at gcc dot gnu.org
  2023-05-08 16:57 ` [Bug testsuite/109776] " pinskia at gcc dot gnu.org
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: law at gcc dot gnu.org @ 2023-05-08 16:41 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109776

            Bug ID: 109776
           Summary: [14 Regression] pr81192 fails on some targets after
                    recent propagator changes
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: law at gcc dot gnu.org
  Target Milestone: ---

pr81192 is failing on some targets (xstormy16-elf for example) after this
change:

commit 21e2ef2dc25de318de29ec32d5390350c6717c6a
Author: Andrew Pinski <apinski@marvell.com>
Date:   Tue May 2 00:10:46 2023 -0700

    Move substitute_and_fold over to use simple_dce_from_worklist

    While looking into a different issue, I noticed that it
    would take until the second forwprop pass to do some
    forward proping and it was because the ssa name was
    used more than once but the second statement was
    "dead" and we don't remove that until much later.

    So this uses simple_dce_from_worklist instead of manually
    removing of the known unused statements instead.
    Propagate engine does not do a cleanupcfg afterwards either but manually
    cleans up possible EH edges so simple_dce_from_worklist
    needs to communicate that back to the propagate engine.

    Some testcases needed to be updated/changed even because of better
optimization.
    gcc.dg/pr81192.c even had to be changed to be using the gimple FE so it
would
    be less fragile in the future too.
    gcc.dg/tree-ssa/pr98737-1.c was failing because __atomic_fetch_ was being
matched
    but in those cases, the result was not being used so both __atomic_fetch_
and
    __atomic_x_and_fetch_ are valid choices and would not make a code
generation difference.
    evrp7.c, evrp8.c, vrp35.c, vrp36.c: just needed a slightly change as the
removal message
    is different slightly.
    kernels-alias-8.c: ccp1 is able to remove an unused load which causes
ealias to have
    one less load to analysis so update the expected scan #.

    OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.

    gcc/ChangeLog:

            PR tree-optimization/109691
            * tree-ssa-dce.cc (simple_dce_from_worklist): Add need_eh_cleanup
            argument.
            If the removed statement can throw, have need_eh_cleanup
            include the bb of that statement.
            * tree-ssa-dce.h (simple_dce_from_worklist): Update declaration.
            * tree-ssa-propagate.cc (struct prop_stats_d): Remove
            num_dce.
            (substitute_and_fold_dom_walker::substitute_and_fold_dom_walker):
            Initialize dceworklist instead of stmts_to_remove.
            (substitute_and_fold_dom_walker::~substitute_and_fold_dom_walker):
            Destore dceworklist instead of stmts_to_remove.
            (substitute_and_fold_dom_walker::before_dom_children):
            Set dceworklist instead of adding to stmts_to_remove.
            (substitute_and_fold_engine::substitute_and_fold):
            Call simple_dce_from_worklist instead of poping
            from the list.
            Don't update the stat on removal statements.

[ ... ]

The compiler is complaining with this message:

/home/jlaw/test/gcc/gcc/testsuite/gcc.dg/pr81192.c: In function 'fn2':^M
/home/jlaw/test/gcc/gcc/testsuite/gcc.dg/pr81192.c:50:1: error: type mismatch
in binary expression^M
long int^M
^M
long int^M
^M
int^M
^M
iftmp2_8_14 = j_6(D) + 1;^M
/home/jlaw/test/gcc/gcc/testsuite/gcc.dg/pr81192.c:50:1: error: mismatching
comparison operand types^M
long int^M
int^M
if (c0_1_13 != 0)^M
compiler exited with status 1


I suspect the testsuite needs further twiddling to work on 16bit int targets.

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-05-08 18:31 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-08 16:41 [Bug testsuite/109776] New: [14 Regression] pr81192 fails on some targets after recent propagator changes law at gcc dot gnu.org
2023-05-08 16:57 ` [Bug testsuite/109776] " pinskia at gcc dot gnu.org
2023-05-08 16:58 ` pinskia at gcc dot gnu.org
2023-05-08 17:39 ` rguenth at gcc dot gnu.org
2023-05-08 17:43 ` pinskia at gcc dot gnu.org
2023-05-08 18:04 ` cvs-commit at gcc dot gnu.org
2023-05-08 18:06 ` pinskia at gcc dot gnu.org
2023-05-08 18:31 ` law at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).