public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/113907] [11/12/13/14 regression] ICU miscompiled since on x86 since r14-5109-ga291237b628f41 Date: Wed, 13 Mar 2024 15:21:37 +0000 [thread overview] Message-ID: <bug-113907-4-NmiYxCUKpQ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-113907-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113907 --- Comment #57 from Jan Hubicka <hubicka at ucw dot cz> --- > So, we can punt on differences there (that is desirable for backporting and > maybe GCC 14 too), or we could at that point populate an int vector, which maps Yep, that is what I do. I had bug in that so I am re-running (forgot to check that callers and callee argument count matches and this cuases ICE during LLVM LTO link). It seems these extra checks makes no difference in practice. During bootstrap there are no pairs of functions during bootstrap where we new checks punt on value range difference or jump function difference that would be merged otherwise. Most common case where we could merge but we don't are those triggered by TBAA. > the callee > vector indexes to indexes in the callee vector in the other candidate function. > If unsuccessful, we just free the vector, if successful, we first walk all the > callees and union stuff in there using that vector. This is the plan for metadata merging. A small complication here is that ICF works by comparing bodies to a leader of equivalence class but this leader is not necessarilly the surviving function body. So if we compared A to L (leader) and B to L and then decided replace A by B, we need to be able to combine the permutations so we know how to map call sites in A to ones in B. The same is true about SSA names and basic blocks. I have patch for that for next stage1.
next prev parent reply other threads:[~2024-03-13 15:21 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-13 12:49 [Bug middle-end/113907] New: [14 " sjames at gcc dot gnu.org 2024-02-13 12:55 ` [Bug middle-end/113907] " sjames at gcc dot gnu.org 2024-02-13 13:00 ` sjames at gcc dot gnu.org 2024-02-13 13:00 ` rguenth at gcc dot gnu.org 2024-02-13 13:14 ` jakub at gcc dot gnu.org 2024-02-13 14:17 ` sjames at gcc dot gnu.org 2024-02-13 14:18 ` sjames at gcc dot gnu.org 2024-02-13 14:19 ` sjames at gcc dot gnu.org 2024-02-13 14:22 ` sjames at gcc dot gnu.org 2024-02-13 14:23 ` sjames at gcc dot gnu.org 2024-02-13 14:24 ` sjames at gcc dot gnu.org 2024-02-13 14:49 ` jakub at gcc dot gnu.org 2024-02-13 14:55 ` pinskia at gcc dot gnu.org 2024-02-13 14:56 ` sjames at gcc dot gnu.org 2024-02-13 14:58 ` sjames at gcc dot gnu.org 2024-02-13 15:11 ` jakub at gcc dot gnu.org 2024-02-13 15:17 ` pinskia at gcc dot gnu.org 2024-02-13 15:19 ` sjames at gcc dot gnu.org 2024-02-13 15:36 ` jakub at gcc dot gnu.org 2024-02-13 15:40 ` pinskia at gcc dot gnu.org 2024-02-13 15:46 ` jakub at gcc dot gnu.org 2024-02-13 15:58 ` jakub at gcc dot gnu.org 2024-02-13 16:00 ` pinskia at gcc dot gnu.org 2024-02-13 16:01 ` pinskia at gcc dot gnu.org 2024-02-13 16:07 ` jakub at gcc dot gnu.org 2024-02-13 16:30 ` jakub at gcc dot gnu.org 2024-02-14 9:16 ` jakub at gcc dot gnu.org 2024-02-14 9:24 ` rguenth at gcc dot gnu.org 2024-02-14 9:25 ` rguenth at gcc dot gnu.org 2024-02-14 9:52 ` jakub at gcc dot gnu.org 2024-02-14 10:35 ` rguenther at suse dot de 2024-02-14 15:52 ` hubicka at gcc dot gnu.org 2024-02-14 15:56 ` jakub at gcc dot gnu.org 2024-02-15 10:25 ` sjames at gcc dot gnu.org 2024-02-15 14:25 ` hubicka at gcc dot gnu.org 2024-02-15 14:36 ` jakub at gcc dot gnu.org 2024-02-15 14:36 ` jakub at gcc dot gnu.org 2024-02-15 14:43 ` rguenther at suse dot de 2024-02-15 14:45 ` rguenther at suse dot de 2024-02-15 14:55 ` hubicka at ucw dot cz 2024-02-15 14:57 ` hubicka at ucw dot cz 2024-02-15 15:02 ` jakub at gcc dot gnu.org 2024-02-16 14:40 ` hubicka at gcc dot gnu.org 2024-02-16 15:10 ` jakub at gcc dot gnu.org 2024-02-16 15:52 ` [Bug middle-end/113907] [12/13/14 " hubicka at gcc dot gnu.org 2024-02-16 15:55 ` jakub at gcc dot gnu.org 2024-02-16 16:08 ` hubicka at ucw dot cz 2024-02-16 16:27 ` jakub at gcc dot gnu.org 2024-02-16 16:45 ` hubicka at ucw dot cz 2024-02-16 17:01 ` amacleod at redhat dot com 2024-02-16 20:42 ` amacleod at redhat dot com 2024-02-22 9:22 ` sjames at gcc dot gnu.org 2024-03-08 15:34 ` jakub at gcc dot gnu.org 2024-03-09 17:10 ` law at gcc dot gnu.org 2024-03-09 21:04 ` [Bug ipa/113907] " pinskia at gcc dot gnu.org 2024-03-09 21:06 ` [Bug ipa/113907] [11/12/13/14 " pinskia at gcc dot gnu.org 2024-03-09 21:11 ` pinskia at gcc dot gnu.org 2024-03-11 11:21 ` jakub at gcc dot gnu.org 2024-03-13 14:07 ` hubicka at gcc dot gnu.org 2024-03-13 14:14 ` jakub at gcc dot gnu.org 2024-03-13 15:21 ` hubicka at ucw dot cz [this message] 2024-03-14 16:20 ` hubicka at gcc dot gnu.org 2024-03-14 16:39 ` hubicka at gcc dot gnu.org 2024-03-14 16:49 ` cvs-commit at gcc dot gnu.org 2024-03-14 16:53 ` jakub at gcc dot gnu.org 2024-03-15 23:29 ` cvs-commit at gcc dot gnu.org 2024-03-19 17:09 ` jakub at gcc dot gnu.org 2024-03-19 18:41 ` hubicka at ucw dot cz 2024-03-20 9:05 ` jamborm at gcc dot gnu.org 2024-03-20 18:13 ` jamborm at gcc dot gnu.org 2024-03-20 18:33 ` jakub at gcc dot gnu.org 2024-03-21 15:29 ` jakub at gcc dot gnu.org 2024-03-28 12:25 ` [Bug ipa/113907] [11/12/13/14 regression] ICU miscompiled " cvs-commit at gcc dot gnu.org 2024-04-02 8:44 ` hubicka at ucw dot cz 2024-04-04 21:17 ` jamborm at gcc dot gnu.org 2024-04-08 9:33 ` sjames at gcc dot gnu.org 2024-04-08 9:38 ` rguenth at gcc dot gnu.org 2024-04-08 16:56 ` cvs-commit at gcc dot gnu.org 2024-04-08 17:04 ` jamborm at gcc dot gnu.org 2024-04-09 9:47 ` Jan Hubicka 2024-04-09 9:47 ` hubicka at ucw dot cz 2024-05-07 7:45 ` [Bug ipa/113907] [11/12/13/14/15 " rguenth at gcc dot gnu.org 2024-05-14 15:06 ` cvs-commit at gcc dot gnu.org 2024-05-28 13:45 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-113907-4-NmiYxCUKpQ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).