[Bug fortran/52279] New: Fortran translation issues issues

[Bug fortran/52279] New: Fortran translation issues issues

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

             Bug #: 52279
           Summary: Fortran translation issues issues
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: burnus@gcc.gnu.org
            Blocks: 52274


A) gfc_check_conformance - but possibly others - have:

  if (gfc_check_conformance (op1, op2,
                             "elemental binary operation") != SUCCESS)

and then in gfc_check_conformance:
          gfc_error ("Different shape for %s at %L on dimension %d "
                     "(%d and %d)", _(buffer), &op1->where, d + 1,

There are two issues: The passed string is not marked as to be translated. One
should use "G_()" [non-std-C string], N_(), or _(). And translating

"Different shape for "                 " at %L on dimension %d"
               "elemental binary operation"

properly is difficult without the context.


B) gfc_check_intrinsic_standard

    case GFC_STD_F95:
      symstd_msg = "new in Fortran 95";
...
        gfc_warning ("Intrinsic '%s' (is %s) is used at %L",
                     isym->name, _(symstd_msg), &where);

Again, the symstd_msg text does not end up in the .pot file. Additionally,
translating  "(is %s)" is rather difficult. At least the 'is ' should moved
into symstd_msg; possibly the whole string. [For the latter: Be careful that
"%s" etc. still get expanded correctly.]


C) There are probably some more such items.

D) In some cases, giving translation hints would help translators.

[Bug fortran/52279] Fortran translation issues issues

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-06-29
     Ever confirmed|0                           |1

[Bug fortran/52279] Fortran translation issues

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Mark Eggleston
<markeggleston@gcc.gnu.org>:

https://gcc.gnu.org/g:0a7183f6d173cbd69025a3deb30d16f91e6392b2

commit r11-1764-g0a7183f6d173cbd69025a3deb30d16f91e6392b2
Author: Mark Eggleston <markeggleston@gcc.gnu.org>
Date:   Tue Jun 2 08:38:01 2020 +0100

    Fortran  : Fortran translation issues PR52279

    Mark strings for translation by enclosing in G_() and _().

    2020-06-24  Mark Eggleston  <markeggleston@gcc.gnu.org>

    gcc/fortran/

            PR fortran/52279
            * arith.c (reduce_binary_aa): Mark for translation the string
            parameter to gfc_check_conformance with G_().
            * check.c (gfc_invalid_boz): Mark hint for translation using
            _().  (gfc_check_achar): Mark for translation the message
            parameter to gfc_invalid_boz using G_().  (gfc_check_char):
            Mark for translation the message parameter to gfc_invalid_boz
            using G_().  (gfc_check_complex): Mark for translation the
            message parameter to gfc_invalid_boz using G_().
            (gfc_check_float): Mark for translation the message
            parameter to gfc_invalid_boz using G_().  (check_rest): Mark
            for translation the string parameter to gfc_check_conformance
            with _().  (gfc_check_minloc_maxloc): Mark for translation
            the string parameter to gfc_check_conformance with _().
            (gfc_check_findloc): Mark for translation the string parameter
            to gfc_check_conformance with _().  (check_reduction): Mark
            for translation the string parameter to gfc_check_conformance
            with _().  (gfc_check_pack): Mark for translation the string
            parameter to gfc_check_conformance with _().
            * decl.c (match_old_style_init): Mark for translation the
            message parameter to gfc_invalid_boz using G_().
            * expr.c (gfc_check_assign): Mark for translation the string
            parameter to gfc_check_conformance with _().
            * intrinsic.c (check_specific): Mark for translation the string
            parameter to gfc_check_conformance with _().
            (gfc_check_intrinsic_standard): Mark symstd_msg strings for
            translation using G_(). No need to mark symstd_msg for
            translation in call to gfc_warning or when setting symstd.
            * io.c (check_open_constraints):  Mark strings for translation
            using G_() in all calls to warn_or_error.  (match_io_element):
            Mark for translation the message parameter to gfc_invalid_boz
            using G_().
            * primary.c (match_boz_constant): Mark for translation the
            message parameter to gfc_invalid_boz using G_().
            * resolve.c (resolve_elemental_actual):  Mark for translation
            the string parameter to gfc_check_conformance with _().
            (resolve_operator):  Mark for translation the string parameter
            to gfc_check_conformance with _().  Mark translation strings
            assigned to msg using G_() for use in a call to cfg_warning.

[Bug fortran/52279] Fortran translation issues

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu.org

--- Comment #2 from kargl at gcc dot gnu.org ---
(In reply to CVS Commits from comment #1)
> The master branch has been updated by Mark Eggleston
> <markeggleston@gcc.gnu.org>:
> 
> https://gcc.gnu.org/g:0a7183f6d173cbd69025a3deb30d16f91e6392b2
> 
> commit r11-1764-g0a7183f6d173cbd69025a3deb30d16f91e6392b2
> Author: Mark Eggleston <markeggleston@gcc.gnu.org>
> Date:   Tue Jun 2 08:38:01 2020 +0100
> 
>     Fortran  : Fortran translation issues PR52279
>     
>     Mark strings for translation by enclosing in G_() and _().
>     
>     2020-06-24  Mark Eggleston  <markeggleston@gcc.gnu.org>
>     
>     gcc/fortran/
>     
>             PR fortran/52279
>             * arith.c (reduce_binary_aa): Mark for translation the string
>             parameter to gfc_check_conformance with G_().
>             * check.c (gfc_invalid_boz): Mark hint for translation using
>             _().  (gfc_check_achar): Mark for translation the message
>             parameter to gfc_invalid_boz using G_().  (gfc_check_char):
>             Mark for translation the message parameter to gfc_invalid_boz
>             using G_().  (gfc_check_complex): Mark for translation the
>             message parameter to gfc_invalid_boz using G_().
>             (gfc_check_float): Mark for translation the message
>             parameter to gfc_invalid_boz using G_().  (check_rest): Mark
>             for translation the string parameter to gfc_check_conformance
>             with _().  (gfc_check_minloc_maxloc): Mark for translation
>             the string parameter to gfc_check_conformance with _().
>             (gfc_check_findloc): Mark for translation the string parameter
>             to gfc_check_conformance with _().  (check_reduction): Mark
>             for translation the string parameter to gfc_check_conformance
>             with _().  (gfc_check_pack): Mark for translation the string
>             parameter to gfc_check_conformance with _().
>             * decl.c (match_old_style_init): Mark for translation the
>             message parameter to gfc_invalid_boz using G_().
>             * expr.c (gfc_check_assign): Mark for translation the string
>             parameter to gfc_check_conformance with _().
>             * intrinsic.c (check_specific): Mark for translation the string
>             parameter to gfc_check_conformance with _().
>             (gfc_check_intrinsic_standard): Mark symstd_msg strings for
>             translation using G_(). No need to mark symstd_msg for
>             translation in call to gfc_warning or when setting symstd.
>             * io.c (check_open_constraints):  Mark strings for translation
>             using G_() in all calls to warn_or_error.  (match_io_element):
>             Mark for translation the message parameter to gfc_invalid_boz
>             using G_().
>             * primary.c (match_boz_constant): Mark for translation the
>             message parameter to gfc_invalid_boz using G_().
>             * resolve.c (resolve_elemental_actual):  Mark for translation
>             the string parameter to gfc_check_conformance with _().
>             (resolve_operator):  Mark for translation the string parameter
>             to gfc_check_conformance with _().  Mark translation strings
>             assigned to msg using G_() for use in a call to cfg_warning.

I believe that this is wrong
@@ -67,7 +67,7 @@ gfc_invalid_boz (const char *msg, locus *loc)
       return false;
     }

-  const char hint[] = " [see %<-fno-allow-invalid-boz%>]";
+  const char hint[] = _(" [see %<-fno-allow-invalid-boz%>]");

fortan/lang.opt RejectNegative for allow-invalid-boz.  There
is no option -fno-allow-invalid-boz.

% gfcx -fno-allow-invalid-boz -c a.f90
gfortran: error: unrecognized command-line option '-fno-allow-invalid-boz'; did
you mean '-fallow-invalid-boz'?

[Bug fortran/52279] Fortran translation issues

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Mark Eggleston
<markeggleston@gcc.gnu.org>:

https://gcc.gnu.org/g:d0e7c73c515c305863620a821ee85bc557bfbef5

commit r11-1784-gd0e7c73c515c305863620a821ee85bc557bfbef5
Author: Mark Eggleston <markeggleston@gcc.gnu.org>
Date:   Thu Jul 2 08:54:10 2020 +0100

    Fortran  : portability fix for PR52279

    Use of _() to enclose string literals assigned to arrays is not
    portable.  Use pointer instead.

    2020-07-02  Mark Eggleston  <markeggleston@gcc.gnu.org>

    gcc/fortran/

            PR fortran/52279
            * check.c (gfc_invalid_boz):  Change array declaration for
            hint into a pointer.

[Bug fortran/52279] Fortran translation issues

[markeggleston at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

markeggleston at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |markeggleston at gcc dot gnu.org

--- Comment #4 from markeggleston at gcc dot gnu.org ---
Regarding comment 2.

Using -fallow-invalid-boz results in an ICE. I'll create a new PR.

[Bug fortran/52279] Fortran translation issues

[markeggleston at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

--- Comment #5 from markeggleston at gcc dot gnu.org ---
(In reply to markeggleston from comment #4)
> Regarding comment 2.
> 
> Using -fallow-invalid-boz results in an ICE. I'll create a new PR.

Not true, tried it on the wrong file and jumped to the wrong conclusion.

[Bug fortran/52279] Fortran translation issues

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

--- Comment #6 from kargl at gcc dot gnu.org ---
(In reply to markeggleston from comment #5)
> (In reply to markeggleston from comment #4)
> > Regarding comment 2.
> > 
> > Using -fallow-invalid-boz results in an ICE. I'll create a new PR.
> 
> Not true, tried it on the wrong file and jumped to the wrong conclusion.

This is wrong.

index 26ea01f..8ecf4ff 100644 (file)
--- a/gcc/fortran/check.c
+++ b/gcc/fortran/check.c
@@ -67,7 +67,7 @@ gfc_invalid_boz (const char *msg, locus *loc)
       return false;
     }

-  const char hint[] = " [see %<-fno-allow-invalid-boz%>]";
+  const char *hint = " [see %<-fno-allow-invalid-boz%>]";
   size_t len = strlen (msg) + strlen (hint) + 1;
   char *msg2 = (char *) alloca (len);
   strcpy (msg2, msg);

There is no -fno-allow-invalid-boz option.  The option is
-fallow-invalid-boz.  fortan/lang.opt defines the options
with the RejectNegative annotation.

[Bug fortran/52279] Fortran translation issues

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to kargl from comment #6)
> There is no -fno-allow-invalid-boz option.  The option is
> -fallow-invalid-boz.  fortan/lang.opt defines the options
> with the RejectNegative annotation.

Why is it RejectNegative?  Is there some other option that acts as it negative
option?  If it is just a standalone boolean option, it should have a negative,
so that if e.g. one uses -fallow-invalid-boz in $FFLAGS for most of files in
some project, but there is a specific one that shouldn't allow it, one can just
append -fno-allow-invalid-boz for it to cancel the earlier option.

[Bug fortran/52279] Fortran translation issues

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

--- Comment #8 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Thu, Jul 02, 2020 at 03:53:22PM +0000, jakub at gcc dot gnu.org wrote:
> 
> --- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
> (In reply to kargl from comment #6)
> > There is no -fno-allow-invalid-boz option.  The option is
> > -fallow-invalid-boz.  fortan/lang.opt defines the options
> > with the RejectNegative annotation.
> 
> Why is it RejectNegative?

Because there is nothing to negate.

  real :: x = z'1234'
  end

is an invalid use of a BOZ.  gfortran 10.1 will issue an error
for this construct (and a number of previously documented and 
undocumented extensions).  Unfortunately, older vesions of
gfortran accepted the above without error or warning.  When I
fixed gfortran's handling of BOZ to conform to the Fortran
2008/2018 standard (i.e., emit an error for the above code),
I introduced -fallow-invalid-boz to down-grade the error to
a warning, so that older codes will compile.  

gfortran -c a.f90                                            <-- error
gfortran -c -fallow-invalid-boz a.f90                        <-- warning
gfortran -c -fallow-invalid-boz -fno-allow-invalid-boz a.f90 <-- stupidity

> Is there some other option that acts as it negative option?

IMO, there is nothing to negative.  If you don't want the
option, then don't use it.

> If it is just a standalone boolean option, it should have a negative,
> so that if e.g. one uses -fallow-invalid-boz in $FFLAGS for most of
> files in some project, but there is a specific one that shouldn't
> allow it, one can just append -fno-allow-invalid-boz for it to cancel
> the earlier option.

This makes no sense to me.  gfortran will accept valid uses of a BOZ
without any option.  If you add -fallow-invalid-boz to $FFLAGS,
then you're simply accepting invalid Fortran (with a warning) in
addition to valid Fortran.  If a programmer is adding a new file 
to a project and $FFLAGS includes -fallow-invalid-boz, then programmer
will get a warning about invalid code instead of an error.  The
programmer is informed about the issue, and can make the necessary 
change, e.g., 

   real :: x = real(z'1234', 4)
   end

in the new file.

The point of the option is to allow backwards compatibility,
but to be verbose about the invalid Fortran; hopefully, to 
encourage the programmer to fix their code.

[Bug fortran/52279] Fortran translation issues

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

--- Comment #9 from Andreas Schwab <schwab@linux-m68k.org> ---
That means you cannot override a default.

[Bug fortran/52279] Fortran translation issues

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

--- Comment #10 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Thu, Jul 02, 2020 at 05:10:51PM +0000, schwab@linux-m68k.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279
> 
> --- Comment #9 from Andreas Schwab <schwab@linux-m68k.org> ---
> That means you cannot override a default.
> 

Huh?

By default you get an error.  The option down-grades the
error to a warning.  If you don't want the warning, then
don't use the option.  You'll get the error.

[Bug fortran/52279] Fortran translation issues

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

--- Comment #11 from Andreas Schwab <schwab@linux-m68k.org> ---
If it was enabled by default, you cannot negate it.

[Bug fortran/52279] Fortran translation issues

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

--- Comment #12 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Thu, Jul 02, 2020 at 05:24:36PM +0000, schwab@linux-m68k.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279
> 
> --- Comment #11 from Andreas Schwab <schwab@linux-m68k.org> ---
> If it was enabled by default, you cannot negate it.
> 

I have no idea what you're writing about, or if you're
addressing me or jakub.

All I can do is explain what gfortran does, and the intended
designed behavior of the -fallow-invalid-boz option.  The
negation of the option is to not specify it among your options.

[Bug fortran/52279] Fortran translation issues

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52279

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |egallager at gcc dot gnu.org

--- Comment #13 from Eric Gallager <egallager at gcc dot gnu.org> ---
Closing as a dup of bug 52274 due to discussion in that bug

*** This bug has been marked as a duplicate of bug 52274 ***