[Bug fortran/78054] gfortran.dg/pr70673.f90 FAILs at -O0

[Bug fortran/78054] gfortran.dg/pr70673.f90 FAILs at -O0

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78054

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #2 from anlauf at gcc dot gnu.org ---
On x86_64-pc-linux-gnu I see it too when running the executable under valgrind.

Commenting line 12

!    a = a           ! This used to ICE.

the problem disappears.

[Bug fortran/78054] gfortran.dg/pr70673.f90 FAILs at -O0

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78054

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hp at gcc dot gnu.org

--- Comment #3 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Now also failing execution at -O0 on cris-elf and apparently
s390x-ibm-linux-gnu since r12-8227-g89ca0fffa48b79.

[Bug fortran/78054] gfortran.dg/pr70673.f90 FAILs at -O0

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78054

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu.org

--- Comment #4 from kargl at gcc dot gnu.org ---
(In reply to Hans-Peter Nilsson from comment #3)
> Now also failing execution at -O0 on cris-elf and apparently
> s390x-ibm-linux-gnu since r12-8227-g89ca0fffa48b79.

The code is clearly invalid Fortran.

module m
contains
  subroutine s(inp)
    character(*), intent(in) :: inp
    character(:), allocatable :: a

    a = a           ! This used to ICE.
!
! The above is an invalid reference of an unallocated allocatable on
! the RHS.
!
    a = inp
    a = a           ! This used to ICE too
    if ((len (a) .ne. 5) .or. (a .ne. "hello")) STOP 1
    a = a(2:3)      ! Make sure that temporary creation is not broken.
    if ((len (a) .ne. 2) .or. (a .ne. "el")) STOP 2
    deallocate (a)
    a = a           ! This would ICE too.
!
! The above is an invalid reference of an unallocated allocatable on
! the RHS.
!
  end subroutine s
end module m

  use m
  call s("hello")
end

You either need to remove the above two lines to get a valid program
or remove the testcase as it's testing processor dependent behavior.

[Bug fortran/78054] gfortran.dg/pr70673.f90 FAILs at -O0

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78054

--- Comment #5 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to kargl from comment #4)
> You either need to remove the above two lines to get a valid program
> or remove the testcase as it's testing processor dependent behavior.

How about changing it to compile-only?  That would avoid interfering with its
value as a regression-test for PR20670, where it ICE'd.

[Bug fortran/78054] gfortran.dg/pr70673.f90 FAILs at -O0

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78054

--- Comment #6 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Wed, Apr 27, 2022 at 12:03:54AM +0000, hp at gcc dot gnu.org wrote:
> 
> --- Comment #5 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
> (In reply to kargl from comment #4)
> > You either need to remove the above two lines to get a valid program
> > or remove the testcase as it's testing processor dependent behavior.
> 
> How about changing it to compile-only?  That would avoid interfering with its
> value as a regression-test for PR20670, where it ICE'd.
> 

I'm fine with that.

[Bug fortran/78054] gfortran.dg/pr70673.f90 FAILs at -O0

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78054

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tkoenig at gcc dot gnu.org

--- Comment #7 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
(In reply to Steve Kargl from comment #6)
> On Wed, Apr 27, 2022 at 12:03:54AM +0000, hp at gcc dot gnu.org wrote:
> > 
> > --- Comment #5 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
> > (In reply to kargl from comment #4)
> > > You either need to remove the above two lines to get a valid program
> > > or remove the testcase as it's testing processor dependent behavior.
> > 
> > How about changing it to compile-only?  That would avoid interfering with its
> > value as a regression-test for PR20670, where it ICE'd.
> > 
> 
> I'm fine with that.

OK, I will then make that change.

[Bug fortran/78054] gfortran.dg/pr70673.f90 FAILs at -O0

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78054

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |tkoenig at gcc dot gnu.org

--- Comment #8 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Fixed on trunk by 

https://gcc.gnu.org/pipermail/gcc-cvs/2022-April/362724.html .

[Bug fortran/78054] gfortran.dg/pr70673.f90 FAILs at -O0

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78054

--- Comment #9 from anlauf at gcc dot gnu.org ---
(In reply to Thomas Koenig from comment #8)
> Fixed on trunk by 
> 
> https://gcc.gnu.org/pipermail/gcc-cvs/2022-April/362724.html .

Thomas,

you'd better re-read Steve's analysis.

Your patch left the first

    a = a           ! This used to ICE.

which is invalid at runtime.  Try yourself running under valgrind.

Either remove this line too, or protect it with an if (allocated (a))

[Bug fortran/78054] gfortran.dg/pr70673.f90 FAILs at -O0

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78054

--- Comment #10 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
(In reply to anlauf from comment #9)
> (In reply to Thomas Koenig from comment #8)
> > Fixed on trunk by 
> > 
> > https://gcc.gnu.org/pipermail/gcc-cvs/2022-April/362724.html .
> 
> Thomas,
> 
> you'd better re-read Steve's analysis.
> 
> Your patch left the first
> 
>     a = a           ! This used to ICE.
> 
> which is invalid at runtime.  Try yourself running under valgrind.
> 
> Either remove this line too, or protect it with an if (allocated (a))

Thanks for pointing this out.

Removed with https://gcc.gnu.org/pipermail/gcc-cvs/2022-April/362729.html .

[Bug fortran/78054] gfortran.dg/pr70673.f90 FAILs at -O0

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78054

--- Comment #11 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Wed, Apr 27, 2022 at 08:49:17PM +0000, tkoenig at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78054
> 
> --- Comment #10 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
> (In reply to anlauf from comment #9)
> > (In reply to Thomas Koenig from comment #8)
> > > Fixed on trunk by 
> > > 
> > > https://gcc.gnu.org/pipermail/gcc-cvs/2022-April/362724.html .
> > 
> > Thomas,
> > 
> > you'd better re-read Steve's analysis.
> > 
> > Your patch left the first
> > 
> >     a = a           ! This used to ICE.
> > 
> > which is invalid at runtime.  Try yourself running under valgrind.
> > 
> > Either remove this line too, or protect it with an if (allocated (a))
> 
> Thanks for pointing this out.
> 
> Removed with https://gcc.gnu.org/pipermail/gcc-cvs/2022-April/362729.html .
> 

Thanks Thomas!

[Bug fortran/78054] gfortran.dg/pr70673.f90 FAILs at -O0

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78054

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING

--- Comment #12 from anlauf at gcc dot gnu.org ---
Should be fixed since r12-8291-g58e4a744b6e8140499ed6c33a8e9a6557e102f74.

Please close if this can be confirmed.

[Bug fortran/78054] gfortran.dg/pr70673.f90 FAILs at -O0

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78054

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|WAITING                     |RESOLVED

--- Comment #13 from anlauf at gcc dot gnu.org ---
Closing.