public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "sgk at troutmask dot apl.washington.edu" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/93483] ICE in gfc_constructor_copy, at fortran/constructor.c:103
Date: Thu, 13 Oct 2022 21:39:26 +0000	[thread overview]
Message-ID: <bug-93483-4-JkCBqso7IF@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-93483-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93483

--- Comment #16 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Thu, Oct 13, 2022 at 08:56:55PM +0000, anlauf at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93483
> 
> --- Comment #15 from anlauf at gcc dot gnu.org ---
> (In reply to anlauf from comment #14)
> > Is it conceivable that a somewhat weaker form of simplification, which
> > addresses the parentheses as well as the basic unary and binary operators
> > could still be used for the time being?
> > 
> > There is simplify_intrinsic_op; it just needs to be made non-static.
> > And seems to work here, also for Mikael's example.
> > 
> > So on top of the posted patch,
> 
> Argh, this doesn't work.  My fault.
> 

gfc_simplify_expr will call simplify_intrinsic_op.  Thisi, I think,
leads to arith.cc:gfc_uplus and arith.cc:gfc_parentheses.  These
simply copy the expression to a new expression without trying to reduce
the expression, and then returns.  For unary plus, instead of copying
the expression, gfortran could copy the operand.  For parentheses,
one would need to walk the expression to see if it can be reduced.

  parent reply	other threads:[~2022-10-13 21:39 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-93483-4@http.gcc.gnu.org/bugzilla/>
2020-12-06 22:13 ` anlauf at gcc dot gnu.org
2020-12-07 21:52 ` anlauf at gcc dot gnu.org
2022-10-11 16:59 ` gscfq@t-online.de
2022-10-12 19:46 ` anlauf at gcc dot gnu.org
2022-10-13 16:35 ` kargl at gcc dot gnu.org
2022-10-13 18:43 ` anlauf at gcc dot gnu.org
2022-10-13 18:52 ` sgk at troutmask dot apl.washington.edu
2022-10-13 19:09 ` anlauf at gcc dot gnu.org
2022-10-13 19:26 ` sgk at troutmask dot apl.washington.edu
2022-10-13 19:35 ` mikael at gcc dot gnu.org
2022-10-13 19:55 ` anlauf at gcc dot gnu.org
2022-10-13 20:02 ` sgk at troutmask dot apl.washington.edu
2022-10-13 20:29 ` anlauf at gcc dot gnu.org
2022-10-13 20:56 ` anlauf at gcc dot gnu.org
2022-10-13 21:39 ` sgk at troutmask dot apl.washington.edu [this message]
2022-10-14 19:06 ` mikael at gcc dot gnu.org
2022-10-14 19:13 ` mikael at gcc dot gnu.org
2022-10-14 19:14 ` mikael at gcc dot gnu.org
2022-10-14 19:19 ` mikael at gcc dot gnu.org
2022-10-14 19:24 ` anlauf at gcc dot gnu.org
2022-10-14 20:14 ` anlauf at gcc dot gnu.org
2022-10-14 21:21 ` anlauf at gcc dot gnu.org
2022-10-15  9:28 ` mikael at gcc dot gnu.org
2022-10-15 13:55 ` anlauf at gcc dot gnu.org
2022-10-15 13:56 ` anlauf at gcc dot gnu.org
2022-10-15 17:38 ` mikael at gcc dot gnu.org
2022-10-15 19:56 ` anlauf at gcc dot gnu.org
2022-10-17 17:26 ` cvs-commit at gcc dot gnu.org
2022-10-17 17:39 ` anlauf at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-93483-4-JkCBqso7IF@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).