public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "anlauf at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/93483] ICE in gfc_constructor_copy, at fortran/constructor.c:103 Date: Thu, 13 Oct 2022 20:29:50 +0000 [thread overview] Message-ID: <bug-93483-4-h8nyQ9Dw7O@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-93483-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93483 --- Comment #14 from anlauf at gcc dot gnu.org --- Is it conceivable that a somewhat weaker form of simplification, which addresses the parentheses as well as the basic unary and binary operators could still be used for the time being? There is simplify_intrinsic_op; it just needs to be made non-static. And seems to work here, also for Mikael's example. So on top of the posted patch, diff --git a/gcc/fortran/array.cc b/gcc/fortran/array.cc index 9bec299f160..4e937a4990f 100644 --- a/gcc/fortran/array.cc +++ b/gcc/fortran/array.cc @@ -1207,7 +1207,7 @@ walk_array_constructor (gfc_typespec *ts, gfc_constructor_base head) e = c->expr; if (e->expr_type == EXPR_OP) - gfc_simplify_expr (e, 0); + simplify_intrinsic_op (e, 0); if (e->expr_type == EXPR_ARRAY && e->ts.type == BT_UNKNOWN && !e->ref && e->value.constructor) diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h index 10bb098d136..37dceacbb54 100644 --- a/gcc/fortran/gfortran.h +++ b/gcc/fortran/gfortran.h @@ -3627,6 +3627,7 @@ gfc_expr *gfc_build_conversion (gfc_expr *); void gfc_free_ref_list (gfc_ref *); void gfc_type_convert_binary (gfc_expr *, int); bool gfc_is_constant_expr (gfc_expr *); +bool simplify_intrinsic_op (gfc_expr *, int); bool gfc_simplify_expr (gfc_expr *, int); bool gfc_try_simplify_expr (gfc_expr *, int); int gfc_has_vector_index (gfc_expr *);
next prev parent reply other threads:[~2022-10-13 20:29 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-93483-4@http.gcc.gnu.org/bugzilla/> 2020-12-06 22:13 ` anlauf at gcc dot gnu.org 2020-12-07 21:52 ` anlauf at gcc dot gnu.org 2022-10-11 16:59 ` gscfq@t-online.de 2022-10-12 19:46 ` anlauf at gcc dot gnu.org 2022-10-13 16:35 ` kargl at gcc dot gnu.org 2022-10-13 18:43 ` anlauf at gcc dot gnu.org 2022-10-13 18:52 ` sgk at troutmask dot apl.washington.edu 2022-10-13 19:09 ` anlauf at gcc dot gnu.org 2022-10-13 19:26 ` sgk at troutmask dot apl.washington.edu 2022-10-13 19:35 ` mikael at gcc dot gnu.org 2022-10-13 19:55 ` anlauf at gcc dot gnu.org 2022-10-13 20:02 ` sgk at troutmask dot apl.washington.edu 2022-10-13 20:29 ` anlauf at gcc dot gnu.org [this message] 2022-10-13 20:56 ` anlauf at gcc dot gnu.org 2022-10-13 21:39 ` sgk at troutmask dot apl.washington.edu 2022-10-14 19:06 ` mikael at gcc dot gnu.org 2022-10-14 19:13 ` mikael at gcc dot gnu.org 2022-10-14 19:14 ` mikael at gcc dot gnu.org 2022-10-14 19:19 ` mikael at gcc dot gnu.org 2022-10-14 19:24 ` anlauf at gcc dot gnu.org 2022-10-14 20:14 ` anlauf at gcc dot gnu.org 2022-10-14 21:21 ` anlauf at gcc dot gnu.org 2022-10-15 9:28 ` mikael at gcc dot gnu.org 2022-10-15 13:55 ` anlauf at gcc dot gnu.org 2022-10-15 13:56 ` anlauf at gcc dot gnu.org 2022-10-15 17:38 ` mikael at gcc dot gnu.org 2022-10-15 19:56 ` anlauf at gcc dot gnu.org 2022-10-17 17:26 ` cvs-commit at gcc dot gnu.org 2022-10-17 17:39 ` anlauf at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-93483-4-h8nyQ9Dw7O@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).